* [PATCH 5.4 105/159] tty/serial: Migrate meson_uart to use has_sysrq [not found] <20231124171941.909624388@linuxfoundation.org> @ 2023-11-24 17:55 ` Greg Kroah-Hartman 2023-11-24 19:39 ` [PATCH 5.4 000/159] 5.4.262-rc1 review Naresh Kamboju 1 sibling, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2023-11-24 17:55 UTC (permalink / raw) To: stable Cc: Greg Kroah-Hartman, patches, Kevin Hilman, linux-arm-kernel, linux-amlogic, Dmitry Safonov, Sasha Levin 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Safonov <dima@arista.com> [ Upstream commit dca3ac8d3bc9436eb5fd35b80cdcad762fbfa518 ] The SUPPORT_SYSRQ ifdeffery is not nice as: - May create misunderstanding about sizeof(struct uart_port) between different objects - Prevents moving functions from serial_core.h - Reduces readability (well, it's ifdeffery - it's hard to follow) In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added. Initialise it in driver's probe and remove ifdeffery. Cc: Kevin Hilman <khilman@baylibre.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Signed-off-by: Dmitry Safonov <dima@arista.com> Link: https://lore.kernel.org/r/20191213000657.931618-22-dima@arista.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Stable-dep-of: 2a1d728f20ed ("tty: serial: meson: fix hard LOCKUP on crtscts mode") Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/tty/serial/meson_uart.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 849ce8c1ef392..4c3616cc00833 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -5,10 +5,6 @@ * Copyright (C) 2014 Carlo Caione <carlo@caione.org> */ -#if defined(CONFIG_SERIAL_MESON_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ) -#define SUPPORT_SYSRQ -#endif - #include <linux/clk.h> #include <linux/console.h> #include <linux/delay.h> @@ -716,6 +712,7 @@ static int meson_uart_probe(struct platform_device *pdev) port->mapsize = resource_size(res_mem); port->irq = res_irq->start; port->flags = UPF_BOOT_AUTOCONF | UPF_LOW_LATENCY; + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MESON_CONSOLE); port->dev = &pdev->dev; port->line = pdev->id; port->type = PORT_MESON; -- 2.42.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5.4 000/159] 5.4.262-rc1 review [not found] <20231124171941.909624388@linuxfoundation.org> 2023-11-24 17:55 ` [PATCH 5.4 105/159] tty/serial: Migrate meson_uart to use has_sysrq Greg Kroah-Hartman @ 2023-11-24 19:39 ` Naresh Kamboju 2023-11-25 15:45 ` Greg Kroah-Hartman 1 sibling, 1 reply; 3+ messages in thread From: Naresh Kamboju @ 2023-11-24 19:39 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, Daniel Díaz, dima, linux-amlogic, Linux ARM, Kevin Hilman On Sat, 25 Nov 2023 at 00:52, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > This is the start of the stable review cycle for the 5.4.262 release. > There are 159 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun, 26 Nov 2023 17:19:17 +0000. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.262-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y > and the diffstat can be found below. > > thanks, > > greg k-h As Daniel replied on 4.19 build failures, Following build warning / errors occurred on arm and arm64 on the stable-rc linux.5.4.y and linux-4.19.y. tty/serial: Migrate meson_uart to use has_sysrq [ Upstream commit dca3ac8d3bc9436eb5fd35b80cdcad762fbfa518 ] drivers/tty/serial/meson_uart.c: In function 'meson_uart_probe': drivers/tty/serial/meson_uart.c:728:13: error: 'struct uart_port' has no member named 'has_sysrq' 728 | port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MESON_CONSOLE); | ^~ Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> -- Linaro LKFT https://lkft.linaro.org _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5.4 000/159] 5.4.262-rc1 review 2023-11-24 19:39 ` [PATCH 5.4 000/159] 5.4.262-rc1 review Naresh Kamboju @ 2023-11-25 15:45 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2023-11-25 15:45 UTC (permalink / raw) To: Naresh Kamboju Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, Daniel Díaz, dima, linux-amlogic, Linux ARM, Kevin Hilman On Sat, Nov 25, 2023 at 01:09:43AM +0530, Naresh Kamboju wrote: > On Sat, 25 Nov 2023 at 00:52, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > This is the start of the stable review cycle for the 5.4.262 release. > > There are 159 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sun, 26 Nov 2023 17:19:17 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.262-rc1.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > As Daniel replied on 4.19 build failures, > Following build warning / errors occurred on arm and arm64 on the > stable-rc linux.5.4.y and linux-4.19.y. > > tty/serial: Migrate meson_uart to use has_sysrq > [ Upstream commit dca3ac8d3bc9436eb5fd35b80cdcad762fbfa518 ] > > drivers/tty/serial/meson_uart.c: In function 'meson_uart_probe': > drivers/tty/serial/meson_uart.c:728:13: error: 'struct uart_port' has > no member named 'has_sysrq' > 728 | port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MESON_CONSOLE); > | ^~ > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> Now fixed, thanks. greg k-h _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-25 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231124171941.909624388@linuxfoundation.org>
2023-11-24 17:55 ` [PATCH 5.4 105/159] tty/serial: Migrate meson_uart to use has_sysrq Greg Kroah-Hartman
2023-11-24 19:39 ` [PATCH 5.4 000/159] 5.4.262-rc1 review Naresh Kamboju
2023-11-25 15:45 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).