From: Christian Hewitt <christianshewitt@gmail.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm/meson: vclk: revert and re-fix vclk calculations
Date: Fri, 10 Jan 2025 07:44:56 +0000 [thread overview]
Message-ID: <20250110074458.3624094-1-christianshewitt@gmail.com> (raw)
Patch 1 reverts a previous fix for loss of HDMI sync when playing YUV420
@ 59.94 media. The patch does resolve a calculation issue. It also makes
all fractional rates invalid which is a bigger problem.
Patch 2 provides a proper fix after I figured out the actual root cause
of the original problem. This time the maths checks out.
Apologies to the stable team as the original patch has been applied to
a wide range of older and LTS kernels (as far as 5.10). Please let me
know if combining the two patches into a single 'fix the previous fix'
patch would be preferred?
Christian
Christian Hewitt (2):
Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates"
drm/meson: vclk: fix precision in vclk calculations
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 42 +++++++++++-----------
drivers/gpu/drm/meson/meson_vclk.c | 7 ++--
2 files changed, 25 insertions(+), 24 deletions(-)
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2025-01-10 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 7:44 Christian Hewitt [this message]
2025-01-10 7:44 ` [PATCH 1/2] Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates" Christian Hewitt
2025-01-10 10:13 ` Neil Armstrong
2025-01-10 7:44 ` [PATCH 2/2] drm/meson: vclk: fix precision in vclk calculations Christian Hewitt
2025-01-10 8:36 ` Maxime Ripard
2025-01-10 9:35 ` Christian Hewitt
2025-01-10 10:12 ` Neil Armstrong
2025-01-20 21:56 ` kernel test robot
2025-02-24 8:52 ` Neil Armstrong
2025-02-24 8:39 ` [PATCH 0/2] drm/meson: vclk: revert and re-fix " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110074458.3624094-1-christianshewitt@gmail.com \
--to=christianshewitt@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox