[PATCH AUTOSEL 6.16] pinctrl: meson: Fix typo in device table macro

[PATCH AUTOSEL 6.16] pinctrl: meson: Fix typo in device table macro

[Sasha Levin]

From: Alexey Gladkov <legion@kernel.org>

[ Upstream commit bd7c2312128e31d056d30d34d60503de056e15f0 ]

The typo when using the MODULE_DEVICE_TABLE macro was not noticeable
because the macro was defined only if the module was built as a separate
module.

Cc: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507220009.8HKbNP16-lkp@intel.com/
Signed-off-by: Alexey Gladkov <legion@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/e548b7761302defec15aa2098172eabb1ce1ad4a.1755170493.git.legion@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

**YES**

This commit should be backported to stable kernel trees for the
following reasons:

1. **Clear bug fix**: The commit fixes a typo where
   `MODULE_DEVICE_TABLE(of, aml_pctl_dt_match)` incorrectly referenced
   `aml_pctl_dt_match` instead of the actual device table name
   `aml_pctl_of_match` (line 1022-1025 shows the table is named
   `aml_pctl_of_match`).

2. **Prevents module loading failure**: This typo would cause the module
   to fail to load properly when built as a loadable module, as the
   MODULE_DEVICE_TABLE macro creates an alias for module autoloading.
   The incorrect reference means the device matching wouldn't work
   correctly for module loading.

3. **Small, contained change**: The fix is a simple one-line change that
   only corrects the typo - changing `aml_pctl_dt_match` to
   `aml_pctl_of_match`. There are no architectural changes or feature
   additions.

4. **Low regression risk**: This is a straightforward typo fix with
   minimal risk. The change only affects the MODULE_DEVICE_TABLE macro
   invocation and doesn't modify any functional code paths.

5. **Affects user functionality**: When the pinctrl driver is built as a
   module (CONFIG_PINCTRL_AMLOGIC_A4=m), this bug would prevent proper
   module autoloading and device matching, affecting users of Amlogic
   A4/S6/S7 SoCs.

6. **Recently introduced code**: The driver was added very recently
   (February 2025 based on commit 6e9be3abb78c2), and this typo was
   present from the initial submission. Fixing it in stable trees
   ensures users get a working driver.

The commit message indicates it was caught by the kernel test robot, and
the fix has already been reviewed by the subsystem maintainer (Neil
Armstrong). This is exactly the type of bug fix that stable kernels
should include - it fixes a real problem, is minimal in scope, and has
very low risk of introducing regressions.

 drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index 385cc619df13c..95525e66e5c00 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -1023,7 +1023,7 @@ static const struct of_device_id aml_pctl_of_match[] = {
 	{ .compatible = "amlogic,pinctrl-a4", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, aml_pctl_dt_match);
+MODULE_DEVICE_TABLE(of, aml_pctl_of_match);
 
 static struct platform_driver aml_pctl_driver = {
 	.driver = {
-- 
2.50.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic