Re: [PATCH net-next v1] dt-bindings: net: Convert icplus-ip101ag to yaml format

Rob Herring
2026-01-13T23:12:36Z

On Sun, Jan 11, 2026 at 12:55:44AM +0100, Martin Blumenstingl wrote:
> This allows for better validation of .dts.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../bindings/net/icplus,ip101ag.yaml | 75 +++++++++++++++++++
> .../bindings/net/icplus-ip101ag.txt | 19 -----
> 2 files changed, 75 insertions(+), 19 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/icplus-ip101ag.txt
>
> diff --git a/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml b/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
> new file mode 100644
> index 000000000000..f245516103b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/icplus,ip101ag.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IC Plus Corp. IP101A / IP101G Ethernet PHYs
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> + - Florian Fainelli <f.fainelli@gmail.com>
> + - Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> +
> +description: |
> + Bindings for IC Plus Corp. IP101A / IP101G Ethernet MII/RMII PHYs

Drop 'Bindings for'

> +
> + There are different models of the IP101G Ethernet PHY:
> + - IP101GR (32-pin QFN package)
> + - IP101G (die only, no package)
> + - IP101GA (48-pin LQFP package)
> +
> + There are different models of the IP101A Ethernet PHY (which is the
> + predecessor of the IP101G):
> + - IP101A (48-pin LQFP package)
> + - IP101AH (48-pin LQFP package)
> +
> + All of them share the same PHY ID.
> +
> +allOf:
> + - $ref: ethernet-phy.yaml#
> +
> +properties:
> + compatible:
> + contains:

Drop contains. The list(s) of allowed values should be exact.

> + enum:
> + - ethernet-phy-id0243.0c54
> +
> + icplus,select-rx-error:
> + type: boolean
> + description: |
> + Pin 21 ("RXER/INTR_32") will output the receive error status.
> + Interrupts are not routed outside the PHY in this mode.
> +
> + This is only supported for IP101GR (32-pin QFN package).
> +
> + icplus,select-interrupt:
> + type: boolean
> + description: |
> + Pin 21 ("RXER/INTR_32") will output the interrupt signal.
> +
> + This is only supported for IP101GR (32-pin QFN package).
> +
> +# RXER and INTR_32 functions are mutually exclusive
> +dependentSchemas:
> + icplus,select-rx-error:
> + properties:
> + icplus,select-interrupt: false
> + icplus,select-interrupt:
> + properties:
> + icplus,select-rx-error: false
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy1: ethernet-phy@1 {
> + compatible = "ethernet-phy-id0243.0c54";
> + reg = <1>;
> + icplus,select-interrupt;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/net/icplus-ip101ag.txt b/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
> deleted file mode 100644
> index a784592bbb15..000000000000
> --- a/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -IC Plus Corp. IP101A / IP101G Ethernet PHYs
> -
> -There are different models of the IP101G Ethernet PHY:
> -- IP101GR (32-pin QFN package)
> -- IP101G (die only, no package)
> -- IP101GA (48-pin LQFP package)
> -
> -There are different models of the IP101A Ethernet PHY (which is the
> -predecessor of the IP101G):
> -- IP101A (48-pin LQFP package)
> -- IP101AH (48-pin LQFP package)
> -
> -Optional properties for the IP101GR (32-pin QFN package):
> -
> -- icplus,select-rx-error:
> - pin 21 ("RXER/INTR_32") will output the receive error status.
> - interrupts are not routed outside the PHY in this mode.
> -- icplus,select-interrupt:
> - pin 21 ("RXER/INTR_32") will output the interrupt signal.
> --
> 2.52.0
>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org