Re: [PATCH v6 5/5] arm64: dts: amlogic: Add Amlogic S4 Audio

Jerome Brunet
2026-01-26T14:57:41Z

On lun. 26 janv. 2026 at 21:20, Jiebing Chen <jiebing.chen@amlogic.com> wrote:

> 在 2026/1/26 19:19, Jerome Brunet 写道:
>> [ EXTERNAL EMAIL ]
>>
>> On lun. 26 janv. 2026 at 06:01, Jiebing Chen via B4 Relay <devnull+jiebing.chen.amlogic.com@kernel.org> wrote:
>>
>>> From: Jiebing Chen <jiebing.chen@amlogic.com>
>>>
>>> Add basic audio driver support for the Amlogic S4 based
>>> Amlogic AQ222 board.
>>>
>>> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
>>> ---
>>> .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts | 222 +++++++++++++
>>> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 361 +++++++++++++++++++++
>>> 2 files changed, 583 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
>>> index 0a3f81ea0fb0..43493bc9da46 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
>>> @@ -75,6 +75,19 @@ vddio_ao1v8: regulator-vddio-ao1v8 {
>>> regulator-always-on;
>>> };
>>>
>>> + vcc5v_reg: regulator-vcc-5v {
>>> + compatible = "regulator-fixed";
>>> + vin-supply = <&main_12v>;
>>> + regulator-name = "VCC5V";
>>> + regulator-min-microvolt = <5000000>;
>>> + regulator-max-microvolt = <5000000>;
>>> + gpio = <&gpio GPIOH_7 GPIO_ACTIVE_HIGH>;
>>> + startup-delay-us = <7000>;
>>> + enable-active-high;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> /* SY8120B1ABC DC/DC Regulator. */
>>> vddcpu: regulator-vddcpu {
>>> compatible = "pwm-regulator";
>>> @@ -129,6 +142,215 @@ vddcpu: regulator-vddcpu {
>>> <699000 98>,
>>> <689000 100>;
>>> };
>>> +
>>> + dmics: audio-codec-1 {
>>> + compatible = "dmic-codec";
>>> + #sound-dai-cells = <0>;
>>> + num-channels = <2>;
>>> + wakeup-delay-ms = <50>;
>>> + sound-name-prefix = "MIC";
>>> + };
>>> +
>>> + dioo2133: audio-amplifier-0 {
>>> + compatible = "simple-audio-amplifier";
>>> + enable-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_HIGH>;
>>> + VCC-supply = <&vcc5v_reg>;
>>> + sound-name-prefix = "10U2";
>>> + };
>>> +
>>> + spdif_dir: audio-spdif-in {
>>> + compatible = "linux,spdif-dir";
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "DIR";
>>> + };
>>> +
>>> + spdif_dit: audio-spdif-out {
>>> + compatible = "linux,spdif-dit";
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "DIT";
>>> + };
>>> +
>>> + sound {
>>> + compatible = "amlogic,axg-sound-card";
>>> + model = "aq222";
>>> + audio-widgets = "Line", "Lineout";
>>> + audio-aux-devs = <&tdmout_a>, <&tdmout_b>, <&tdmout_c>,
>>> + <&tdmin_a>, <&tdmin_b>, <&tdmin_c>,
>>> + <&tdmin_lb>, <&dioo2133>;
>>> + audio-routing = "TDMOUT_A IN 0", "FRDDR_A OUT 0",
>>> + "TDMOUT_A IN 1", "FRDDR_B OUT 0",
>>> + "TDMOUT_A IN 2", "FRDDR_C OUT 0",
>>> + "TDM_A Playback", "TDMOUT_A OUT",
>>> + "TDMOUT_B IN 0", "FRDDR_A OUT 1",
>>> + "TDMOUT_B IN 1", "FRDDR_B OUT 1",
>>> + "TDMOUT_B IN 2", "FRDDR_C OUT 1",
>>> + "TDM_B Playback", "TDMOUT_B OUT",
>>> + "TDMOUT_C IN 0", "FRDDR_A OUT 2",
>>> + "TDMOUT_C IN 1", "FRDDR_B OUT 2",
>>> + "TDMOUT_C IN 2", "FRDDR_C OUT 2",
>>> + "TDM_C Playback", "TDMOUT_C OUT",
>>> + "SPDIFOUT_A IN 0", "FRDDR_A OUT 3",
>>> + "SPDIFOUT_A IN 1", "FRDDR_B OUT 3",
>>> + "SPDIFOUT_A IN 2", "FRDDR_C OUT 3",
>>> + "SPDIFOUT_B IN 0", "FRDDR_A OUT 4",
>>> + "SPDIFOUT_B IN 1", "FRDDR_B OUT 4",
>>> + "SPDIFOUT_B IN 2", "FRDDR_C OUT 4",
>>> + "TDMIN_A IN 0", "TDM_A Capture",
>>> + "TDMIN_A IN 1", "TDM_B Capture",
>>> + "TDMIN_A IN 2", "TDM_C Capture",
>>> + "TDMIN_A IN 3", "TDM_A Loopback",
>>> + "TDMIN_A IN 4", "TDM_B Loopback",
>>> + "TDMIN_A IN 5", "TDM_C Loopback",
>>> + "TDMIN_B IN 0", "TDM_A Capture",
>>> + "TDMIN_B IN 1", "TDM_B Capture",
>>> + "TDMIN_B IN 2", "TDM_C Capture",
>>> + "TDMIN_B IN 3", "TDM_A Loopback",
>>> + "TDMIN_B IN 4", "TDM_B Loopback",
>>> + "TDMIN_B IN 5", "TDM_C Loopback",
>>> + "TDMIN_C IN 0", "TDM_A Capture",
>>> + "TDMIN_C IN 1", "TDM_B Capture",
>>> + "TDMIN_C IN 2", "TDM_C Capture",
>>> + "TDMIN_C IN 3", "TDM_A Loopback",
>>> + "TDMIN_C IN 4", "TDM_B Loopback",
>>> + "TDMIN_C IN 5", "TDM_C Loopback",
>>> + "TDMIN_LB IN 3", "TDM_A Capture",
>>> + "TDMIN_LB IN 4", "TDM_B Capture",
>>> + "TDMIN_LB IN 5", "TDM_C Capture",
>>> + "TDMIN_LB IN 0", "TDM_A Loopback",
>>> + "TDMIN_LB IN 1", "TDM_B Loopback",
>>> + "TDMIN_LB IN 2", "TDM_C Loopback",
>>> + "TODDR_A IN 0", "TDMIN_A OUT",
>>> + "TODDR_B IN 0", "TDMIN_A OUT",
>>> + "TODDR_C IN 0", "TDMIN_A OUT",
>>> + "TODDR_A IN 1", "TDMIN_B OUT",
>>> + "TODDR_B IN 1", "TDMIN_B OUT",
>>> + "TODDR_C IN 1", "TDMIN_B OUT",
>>> + "TODDR_A IN 2", "TDMIN_C OUT",
>>> + "TODDR_B IN 2", "TDMIN_C OUT",
>>> + "TODDR_C IN 2", "TDMIN_C OUT",
>>> + "TODDR_A IN 3", "SPDIFIN Capture",
>>> + "TODDR_B IN 3", "SPDIFIN Capture",
>>> + "TODDR_C IN 3", "SPDIFIN Capture",
>>> + "TODDR_A IN 6", "TDMIN_LB OUT",
>>> + "TODDR_B IN 6", "TDMIN_LB OUT",
>>> + "TODDR_C IN 6", "TDMIN_LB OUT",
>>> + "10U2 INL", "ACODEC LOLP",
>>> + "10U2 INR", "ACODEC LORP",
>>> + "Lineout", "10U2 OUTL",
>>> + "Lineout", "10U2 OUTR";
>>> + clocks = <&clkc_pll CLKID_HIFI_PLL>,
>>> + <&clkc_pll CLKID_MPLL0>,
>>> + <&clkc_pll CLKID_MPLL1>;
>>> + assigned-clocks = <&clkc_pll CLKID_HIFI_PLL>,
>>> + <&clkc_pll CLKID_MPLL0>,
>>> + <&clkc_pll CLKID_MPLL1>;
>>> + assigned-clock-rates = <1179648000>,
>>> + <270950400>,
>>> + <338688000>;
>> Seems like you've got the 2 last PLLs serving the 44.1kHz rate family.
>> Why is this needed ?
>
> Hi, jermoe
>
> Considering that the sample rate is up to 176.4K

That's not really the question here and there are interfaces (internal
for example) for which it can go higher than that.

>
> PLL0 270.950400M max support 24bit *176.4k, 32ch for tdm mode
>
> Perhaps PLL1 PLL1 calculation error , it should be set up 361.2672M for
> 32bit * 176.4k * 32ch.
>
> In fact, most situations are limited by the speed of the IO pin.

... again, no everything goes through those pins.

>
> Can we remove MPLL1 here and keep MPLL0?

That's up to you really. I'm merely pointing out that out of the 3 clock
sources, 2 are setup to serve derivative of 44.1kHz, which is useless.

>
>>> +
>>> + dai-link-0 {
>>> + sound-dai = <&frddr_a>;
>>> + };
>>> +
>>> + dai-link-1 {
>>> + sound-dai = <&frddr_b>;
>>> + };
>>> +
>>> + dai-link-2 {
>>> + sound-dai = <&frddr_c>;
>>> + };
>>> +
>>> + dai-link-3 {
>>> + sound-dai = <&toddr_a>;
>>> + };
>>> +
>>> + dai-link-4 {
>>> + sound-dai = <&toddr_b>;
>>> + };
>>> +
>>> + dai-link-5 {
>>> + sound-dai = <&toddr_c>;
>>> + };
>>> +
>>> + dai-link-6 {
>>> + sound-dai = <&tdmif_a>;
>>> + dai-format = "i2s";
>>> + dai-tdm-slot-tx-mask-0 = <1 1>;
>>> + mclk-fs = <256>;
>>> + codec-0 {
>>> + sound-dai = <&tohdmitx TOHDMITX_I2S_IN_A>;
>>> + };
>>> + codec-1 {
>>> + sound-dai = <&toacodec TOACODEC_IN_A>;
>>> + };
>>> + };
>>> +
>>> + dai-link-7 {
>>> + sound-dai = <&tdmif_b>;
>>> + dai-format = "i2s";
>>> + dai-tdm-slot-tx-mask-0 = <1 1>;
>>> + mclk-fs = <256>;
>>> + codec-0 {
>>> + sound-dai = <&toacodec TOACODEC_IN_B>;
>>> + };
>>> + codec-1 {
>>> + sound-dai = <&tohdmitx TOHDMITX_I2S_IN_B>;
>>> + };
>>> + };
>>> +
>>> + /* 8ch HDMI interface */
>>> + dai-link-8 {
>>> + sound-dai = <&tdmif_c>;
>>> + dai-format = "i2s";
>>> + dai-tdm-slot-tx-mask-0 = <1 1>;
>>> + dai-tdm-slot-tx-mask-1 = <1 1>;
>>> + dai-tdm-slot-tx-mask-2 = <1 1>;
>>> + dai-tdm-slot-tx-mask-3 = <1 1>;
>>> + mclk-fs = <256>;
>>> + codec-0 {
>>> + sound-dai = <&tohdmitx TOHDMITX_I2S_IN_C>;
>>> + };
>>> + };
>>> +
>>> + /* spdif hdmi and coax output */
>>> + dai-link-9 {
>>> + sound-dai = <&spdifout_a>;
>>> +
>>> + codec-0 {
>>> + sound-dai = <&spdif_dit>;
>>> + };
>>> +
>>> + codec-1 {
>>> + sound-dai = <&tohdmitx TOHDMITX_SPDIF_IN_A>;
>>> + };
>>> + };
>>> +
>>> + /* spdif hdmi interface */
>>> + dai-link-10 {
>>> + sound-dai = <&spdifout_b>;
>>> +
>>> + codec {
>>> + sound-dai = <&tohdmitx TOHDMITX_SPDIF_IN_B>;
>>> + };
>>> + };
>>> +
>>> + /* spdif coax input */
>>> + dai-link-11 {
>>> + sound-dai = <&spdifin>;
>>> +
>>> + codec {
>>> + sound-dai = <&spdif_dir>;
>>> + };
>>> + };
>>> +
>>> + dai-link-12 {
>>> + sound-dai = <&toacodec TOACODEC_OUT>;
>>> +
>>> + codec {
>>> + sound-dai = <&acodec>;
>>> + };
>>> + };
>>> + };
>>> };
>>>
>>> &pwm_ef {
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>> index dfc0a30a6e61..a6c2c83eea16 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>> @@ -11,6 +11,11 @@
>>> #include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
>>> #include <dt-bindings/power/meson-s4-power.h>
>>> #include <dt-bindings/reset/amlogic,meson-s4-reset.h>
>>> +#include <dt-bindings/clock/axg-audio-clkc.h>
>>> +#include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h>
>>> +#include <dt-bindings/reset/amlogic,meson-g12a-audio-reset.h>
>>> +#include <dt-bindings/sound/meson-g12a-toacodec.h>
>>> +#include <dt-bindings/sound/meson-g12a-tohdmitx.h>
>>>
>>> / {
>>> cpus {
>>> @@ -863,4 +868,360 @@ emmc: mmc@fe08c000 {
>>> assigned-clock-rates = <24000000>;
>>> };
>>> };
>>> +
>>> + tdmif_a: audio-controller-0 {
>>> + compatible = "amlogic,axg-tdm-iface";
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TDM_A";
>>> + clocks = <&clkc_audio AUD_CLKID_MST_A_SCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_A_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_A_MCLK>;
>>> + clock-names = "sclk", "lrclk","mclk";
>>> + };
>>> +
>>> + tdmif_b: audio-controller-1 {
>>> + compatible = "amlogic,axg-tdm-iface";
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TDM_B";
>>> + clocks = <&clkc_audio AUD_CLKID_MST_A_SCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_B_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_B_MCLK>;
>>> + clock-names = "sclk", "lrclk","mclk";
>>> + };
>>> +
>>> + tdmif_c: audio-controller-2 {
>>> + compatible = "amlogic,axg-tdm-iface";
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TDM_C";
>>> + clocks = <&clkc_audio AUD_CLKID_MST_C_SCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_C_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_MST_C_MCLK>;
>>> + clock-names = "sclk", "lrclk","mclk";
>>> + };
>>> +};
>>> +
>>> +&apb4 {
>>> + acodec: audio-controller@1a000 {
>>> + compatible = "amlogic,t9015";
>>> + reg = <0x0 0x1a000 0x0 0x14>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "ACODEC";
>>> + clocks = <&clkc_periphs CLKID_ACODEC>;
>>> + clock-names = "pclk";
>>> + resets = <&reset RESET_ACODEC>;
>>> + AVDD-supply = <&vddio_ao1v8>;
>>> + };
>>> +
>>> + clkc_audio: clock-controller@330000 {
>>> + compatible = "amlogic,s4-audio-clkc";
>>> + reg = <0x0 0x330000 0x0 0xd8>,
>>> + <0x0 0x330e80 0x0 0x10>;
>>> + #clock-cells = <1>;
>>> + #reset-cells = <1>;
>>> + power-domains = <&pwrc PWRC_S4_AUDIO_ID>;
>>> + clocks = <&clkc_periphs CLKID_AUDIO>,
>>> + <&clkc_pll CLKID_MPLL0>,
>>> + <&clkc_pll CLKID_MPLL1>,
>>> + <&clkc_pll CLKID_MPLL2>,
>>> + <&clkc_pll CLKID_MPLL3>,
>>> + <&clkc_pll CLKID_HIFI_PLL>,
>>> + <&clkc_pll CLKID_FCLK_DIV3>,
>>> + <&clkc_pll CLKID_FCLK_DIV4>,
>>> + <&clkc_pll CLKID_FCLK_DIV5>;
>>> + clock-names = "pclk",
>>> + "mst_in0",
>>> + "mst_in1",
>>> + "mst_in2",
>>> + "mst_in3",
>>> + "mst_in4",
>>> + "mst_in5",
>>> + "mst_in6",
>>> + "mst_in7";
>>> + resets = <&reset RESET_AUDIO>;
>>> + };
>>> +
>>> + toddr_a: audio-controller@330100 {
>>> + compatible = "amlogic,sm1-toddr",
>>> + "amlogic,axg-toddr";
>> no s4 compat ?
>>
>>> + reg = <0x0 0x330100 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TODDR_A";
>>> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_TODDR_A>;
>>> + resets = <&arb AXG_ARB_TODDR_A>,
>>> + <&clkc_audio AUD_RESET_TODDR_A>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <8192>;
>>> + };
>>> +
>>> + toddr_b: audio-controller@330140 {
>>> + compatible = "amlogic,sm1-toddr",
>>> + "amlogic,axg-toddr";
>>> + reg = <0x0 0x330140 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TODDR_B";
>>> + interrupts = <GIC_SPI 33 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_TODDR_B>;
>>> + resets = <&arb AXG_ARB_TODDR_B>,
>>> + <&clkc_audio AUD_RESET_TODDR_B>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + toddr_c: audio-controller@330180 {
>>> + compatible = "amlogic,sm1-toddr",
>>> + "amlogic,axg-toddr";
>>> + reg = <0x0 0x330180 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TODDR_C";
>>> + interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_TODDR_C>;
>>> + resets = <&arb AXG_ARB_TODDR_C>,
>>> + <&clkc_audio AUD_RESET_TODDR_C>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + frddr_a: audio-controller@3301c0 {
>>> + compatible = "amlogic,sm1-frddr",
>>> + "amlogic,axg-frddr";
>>> + reg = <0x0 0x3301c0 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "FRDDR_A";
>>> + interrupts = <GIC_SPI 36 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_FRDDR_A>;
>>> + resets = <&arb AXG_ARB_FRDDR_A>,
>>> + <&clkc_audio AUD_RESET_FRDDR_A>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <512>;
>>> + };
>>> +
>>> + frddr_b: audio-controller@330200 {
>>> + compatible = "amlogic,sm1-frddr",
>>> + "amlogic,axg-frddr";
>>> + reg = <0x0 0x330200 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "FRDDR_B";
>>> + interrupts = <GIC_SPI 37 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_FRDDR_B>;
>>> + resets = <&arb AXG_ARB_FRDDR_B>,
>>> + <&clkc_audio AUD_RESET_FRDDR_B>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + frddr_c: audio-controller@330240 {
>>> + compatible = "amlogic,sm1-frddr",
>>> + "amlogic,axg-frddr";
>>> + reg = <0x0 0x330240 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "FRDDR_C";
>>> + interrupts = <GIC_SPI 38 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_FRDDR_C>;
>>> + resets = <&arb AXG_ARB_FRDDR_C>,
>>> + <&clkc_audio AUD_RESET_FRDDR_C>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + arb: reset-controller@330280 {
>>> + compatible = "amlogic,meson-sm1-audio-arb";
>>> + reg = <0x0 0x330280 0x0 0x4>;
>>> + #reset-cells = <1>;
>>> + clocks = <&clkc_audio AUD_CLKID_DDR_ARB>;
>>> + };
>>> +
>>> + tdmin_a: audio-controller@330300 {
>>> + compatible = "amlogic,sm1-tdmin";
>>> + reg = <0x0 0x330300 0x0 0x40>;
>>> + sound-name-prefix = "TDMIN_A";
>>> + resets = <&clkc_audio AUD_RESET_TDMIN_A>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMIN_A>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_A_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_A_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_A_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_A_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + tdmin_b: audio-controller@330340 {
>>> + compatible = "amlogic,sm1-tdmin";
>>> + reg = <0x0 0x330340 0x0 0x40>;
>>> + sound-name-prefix = "TDMIN_B";
>>> + resets = <&clkc_audio AUD_RESET_TDMIN_B>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMIN_B>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_B_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_B_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_B_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_B_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + tdmin_c: audio-controller@330380 {
>>> + compatible = "amlogic,sm1-tdmin";
>>> + reg = <0x0 0x330380 0x0 0x40>;
>>> + sound-name-prefix = "TDMIN_C";
>>> + resets = <&clkc_audio AUD_RESET_TDMIN_C>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMIN_C>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_C_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_C_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_C_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_C_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + tdmin_lb: audio-controller@3303c0 {
>>> + compatible = "amlogic,sm1-tdmin";
>>> + reg = <0x0 0x3303c0 0x0 0x40>;
>>> + sound-name-prefix = "TDMIN_LB";
>>> + resets = <&clkc_audio AUD_RESET_TDMIN_LB>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMIN_LB>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_LB_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_LB_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_LB_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMIN_LB_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + spdifin: audio-controller@330400 {
>>> + compatible = "amlogic,g12a-spdifin",
>>> + "amlogic,axg-spdifin";
>>> + reg = <0x0 0x330400 0x0 0x30>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "SPDIFIN";
>>> + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>,
>>> + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>;
>>> + clock-names = "pclk", "refclk";
>>> + resets = <&clkc_audio AUD_RESET_SPDIFIN>;
>>> + };
>>> +
>>> + spdifout_a: audio-controller@330480 {
>>> + compatible = "amlogic,g12a-spdifout",
>>> + "amlogic,axg-spdifout";
>>> + reg = <0x0 0x330480 0x0 0x50>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "SPDIFOUT_A";
>>> + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>,
>>> + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>;
>>> + clock-names = "pclk", "mclk";
>>> + resets = <&clkc_audio AUD_RESET_SPDIFOUT>;
>>> + };
>>> +
>>> + tdmout_a: audio-controller@330500 {
>>> + compatible = "amlogic,sm1-tdmout";
>>> + reg = <0x0 0x330500 0x0 0x40>;
>>> + sound-name-prefix = "TDMOUT_A";
>>> + resets = <&clkc_audio AUD_RESET_TDMOUT_A>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMOUT_A>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_A_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_A_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_A_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_A_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + tdmout_b: audio-controller@330540 {
>>> + compatible = "amlogic,sm1-tdmout";
>>> + reg = <0x0 0x330540 0x0 0x40>;
>>> + sound-name-prefix = "TDMOUT_B";
>>> + resets = <&clkc_audio AUD_RESET_TDMOUT_B>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMOUT_B>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_B_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_B_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_B_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_B_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + tdmout_c: audio-controller@330580 {
>>> + compatible = "amlogic,sm1-tdmout";
>>> + reg = <0x0 0x330580 0x0 0x40>;
>>> + sound-name-prefix = "TDMOUT_C";
>>> + resets = <&clkc_audio AUD_RESET_TDMOUT_C>;
>>> + clocks = <&clkc_audio AUD_CLKID_TDMOUT_C>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_C_SCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_C_SCLK_SEL>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_C_LRCLK>,
>>> + <&clkc_audio AUD_CLKID_TDMOUT_C_LRCLK>;
>>> + clock-names = "pclk", "sclk", "sclk_sel",
>>> + "lrclk", "lrclk_sel";
>>> + };
>>> +
>>> + spdifout_b: audio-controller@330680 {
>>> + compatible = "amlogic,g12a-spdifout",
>>> + "amlogic,axg-spdifout";
>>> + reg = <0x0 0x330680 0x0 0x50>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "SPDIFOUT_B";
>>> + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>,
>>> + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>;
>>> + clock-names = "pclk", "mclk";
>>> + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>;
>>> + };
>>> +
>>> + toacodec: audio-controller@330740 {
>>> + compatible = "amlogic,s4-toacodec",
>>> + "amlogic,g12a-toacodec";
>>> + reg = <0x0 0x330740 0x0 0x4>;
>>> + sound-name-prefix = "TOACODEC";
>>> + #sound-dai-cells = <1>;
>>> + resets = <&clkc_audio AUD_RESET_TOACODEC>;
>>> + };
>>> +
>>> + tohdmitx: audio-controller@330744 {
>>> + compatible = "amlogic,sm1-tohdmitx",
>>> + "amlogic,g12a-tohdmitx";
>>> + reg = <0x0 0x330744 0x0 0x4>;
>>> + #sound-dai-cells = <1>;
>>> + sound-name-prefix = "TOHDMITX";
>>> + resets = <&clkc_audio AUD_RESET_TOHDMITX>;
>>> + };
>>> +
>>> + toddr_d: audio-controller@330840 {
>>> + compatible = "amlogic,sm1-toddr",
>>> + "amlogic,axg-toddr";
>>> + reg = <0x0 0x330840 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "TODDR_D";
>>> + interrupts = <GIC_SPI 45 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_TODDR_D>;
>>> + resets = <&arb AXG_ARB_TODDR_D>,
>>> + <&clkc_audio AUD_RESET_TODDR_D>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + frddr_d: audio-controller@330880 {
>>> + compatible = "amlogic,sm1-frddr",
>>> + "amlogic,axg-frddr";
>>> + reg = <0x0 0x330880 0x0 0x2c>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "FRDDR_D";
>>> + interrupts = <GIC_SPI 46 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&clkc_audio AUD_CLKID_FRDDR_D>;
>>> + resets = <&arb AXG_ARB_FRDDR_D>,
>>> + <&clkc_audio AUD_RESET_FRDDR_D>;
>>> + reset-names = "arb", "rst";
>>> + amlogic,fifo-depth = <256>;
>>> + };
>>> +
>>> + pdm: audio-controller@331000 {
>>> + compatible = "amlogic,sm1-pdm",
>>> + "amlogic,axg-pdm";
>>> + reg = <0x0 0x331000 0x0 0x34>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "PDM";
>>> + clocks = <&clkc_audio AUD_CLKID_PDM>,
>>> + <&clkc_audio AUD_CLKID_PDM_DCLK>,
>>> + <&clkc_audio AUD_CLKID_PDM_SYSCLK>;
>>> + clock-names = "pclk", "dclk", "sysclk";
>>> + resets = <&clkc_audio AUD_RESET_PDM>;
>>> + };
>>> };
>> --
>> Jerome

--
Jerome