Re: [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

Jerome Brunet
2026-02-18T18:13:27Z

On mer. 18 févr. 2026 at 11:57, Ronald Claveau <linux-kernel-dev@aliel.fr> wrote:

> Add PLL for the clock controller of the Amlogic T7 SoC family.

Assuming the 3 first patch are actually needed (I don't think they are)
I think patch 2 and 3 should be squashed together

>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
> .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> index 49c61f65deff..6a1598e6c359 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> @@ -23,6 +23,7 @@ properties:
> - amlogic,t7-mpll
> - amlogic,t7-hdmi-pll
> - amlogic,t7-mclk-pll
> + - amlogic,t7-fpll
>
> reg:
> maxItems: 1
> @@ -42,6 +43,7 @@ properties:
> - const: in0
> - const: in1
> - const: in2
> + - const: xtal

Fishy. Maybe it will get more clear with a more detailed commit description

> minItems: 1
>
> required:
> @@ -72,11 +74,12 @@ allOf:
> contains:
> enum:
> - amlogic,t7-gp0-pll
> - - amlogic,t7-gp1--pll
> + - amlogic,t7-gp1-pll

Indeed that's not good ! but you need specific patch for this, and Fixes
tag. You can send this separately.

> - amlogic,t7-hifi-pll
> - amlogic,t7-pcie-pll
> - amlogic,t7-mpll
> - amlogic,t7-hdmi-pll
> + - amlogic,t7-fpll
>
> then:
> properties:

--
Jerome