Re: [PATCH v2 1/8] dt-bindings: thermal: amlogic: Add support for T7

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 3361 bytes --]

On Mon, Apr 13, 2026 at 12:52:42PM +0200, Ronald Claveau wrote:
> Add the amlogic,t7-thermal compatible for the Amlogic T7 thermal sensor.
> 
> Unlike existing variants which use a phandle to the ao-secure syscon,
> the T7 relies on a secure monitor interface described by a phandle and
> a sensor index argument.
> 
> The T7 integrates multiple thermal sensors, all accessed through the
> same SMC call. The sensor index argument is required to identify which
> sensor's calibration data the secure monitor should return, as a single
> SM_THERMAL_CALIB_READ command serves all of them.
> 
> Introduce the amlogic,secure-monitor property as a phandle-array and
> make amlogic,ao-secure or amlogic,secure-monitor conditionally required
> depending on the compatible.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
>  .../bindings/thermal/amlogic,thermal.yaml          | 42 ++++++++++++++++++++--
>  1 file changed, 40 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> index 70b273271754b..1c096116b2dda 100644
> --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> @@ -21,7 +21,9 @@ properties:
>                - amlogic,g12a-cpu-thermal
>                - amlogic,g12a-ddr-thermal
>            - const: amlogic,g12a-thermal
> -      - const: amlogic,a1-cpu-thermal
> +      - enum:
> +          - amlogic,a1-cpu-thermal
> +          - amlogic,t7-thermal
>  
>    reg:
>      maxItems: 1
> @@ -42,12 +44,39 @@ properties:
>    '#thermal-sensor-cells':
>      const: 0
>  
> +  amlogic,secure-monitor:
> +    description: phandle to the secure monitor
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: phandle to the secure monitor
> +          - description: sensor index to get specific calibration data
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>    - clocks
> -  - amlogic,ao-secure
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - amlogic,a1-cpu-thermal
> +              - amlogic,g12a-thermal
> +    then:
> +      required:
> +        - amlogic,ao-secure
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: amlogic,t7-thermal

This can just be replaced by a else I think.

> +    then:
> +      required:
> +        - amlogic,secure-monitor
>  
>  unevaluatedProperties: false
>  
> @@ -62,4 +91,13 @@ examples:
>          #thermal-sensor-cells = <0>;
>          amlogic,ao-secure = <&sec_AO>;
>      };
> +  - |
> +    a73_tsensor: temperature-sensor@20000 {

Can drop the label here, it has no users.

Otherwise, seems fine.

Cheers,
Conor.

pw-bot: changes-requested

> +        compatible = "amlogic,t7-thermal";
> +        reg = <0x0 0x20000 0x0 0x50>;
> +        interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&clkc_periphs CLKID_TS>;
> +        #thermal-sensor-cells = <0>;
> +        amlogic,secure-monitor = <&sm 1>;
> +    };
>  ...
> 
> -- 
> 2.49.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic