From: sashiko-bot@kernel.org
To: "Xianwei Zhao" <xianwei.zhao@amlogic.com>
Cc: conor+dt@kernel.org, robh@kernel.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH 3/3] arm64: dts: amlogic: a9: Add reset controller support
Date: Thu, 09 Jul 2026 08:35:49 +0000 [thread overview]
Message-ID: <20260709083550.403D61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709-a9-reset-v1-3-fd7cf039b853@amlogic.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The AO reset controller node uses a non-generic name 'ao-reset-controller@2000' which fails standard schema validation.
--
--- Patch [3]: [PATCH 3/3] arm64: dts: amlogic: a9: Add reset controller support ---
commit 0f045fcc683de25785c6ca1a6df4d983c07bc9b4
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>
arm64: dts: amlogic: a9: Add reset controller support
This commit adds reset controller descriptions for the Amlogic A9 SoC.
It includes the corresponding reset IDs header and device tree nodes for
both the main and ao reset controllers.
[ ... ]
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
> --- a/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
[ ... ]
> @@ -204,6 +212,12 @@ aobus: bus@ffa00000 {
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0xffa00000 0x0 0x100000>;
>
> + ao_reset: ao-reset-controller@2000 {
[Severity: Low]
Could this node use the generic name reset-controller@2000 instead? Standard
device tree schema validation expects reset controllers to match the generic
pattern ^reset-controller(@.*)?$. Using ao-reset-controller@2000 will likely
trigger a validation warning when running make dtbs_check.
> + compatible = "amlogic,a9-ao-reset";
> + reg = <0x0 0x2000 0x0 0xc>;
> + #reset-cells = <1>;
> + };
> +
> aobus_pinctrl: pinctrl@4000 {
> compatible = "amlogic,pinctrl-a9";
> #address-cells = <2>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-a9-reset-v1-0-fd7cf039b853@amlogic.com?part=3
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-07-09 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 8:26 [PATCH 0/3] reset: support reset for Amlogic A9 SoC Xianwei Zhao via B4 Relay
2026-07-09 8:26 ` [PATCH 1/3] dt-bindings: reset: amlogic: Add A9 reset compatibles Xianwei Zhao via B4 Relay
2026-07-09 17:40 ` Conor Dooley
2026-07-09 8:26 ` [PATCH 2/3] reset: amlogic: Add A9 AO reset controller support Xianwei Zhao via B4 Relay
2026-07-09 8:26 ` [PATCH 3/3] arm64: dts: amlogic: a9: Add " Xianwei Zhao via B4 Relay
2026-07-09 8:35 ` sashiko-bot [this message]
2026-07-09 9:31 ` Xianwei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709083550.403D61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox