Re: [PATCH 14/15] drm/drm_simple: remove deprecated drm_simple_encoder_init function

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch successfully removes `drm_simple_encoder_init()` but fails to remove its corresponding completed task from the GPU TODO list.
--

--- Patch [14]: [PATCH 14/15] drm/drm_simple: remove deprecated drm_simple_encoder_init function ---
commit 7fd5be63f48ba2540ec1b5b7dc137c54a85997f8
Author: Diogo Silva <diogompaissilva@gmail.com>

drm/drm_simple: remove deprecated drm_simple_encoder_init function

This patch removes the deprecated drm_simple_encoder_init() helper since all
driver users have been converted to drm_encoder_init(). It also open-codes
the remaining internal use to prevent any new users.

> diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c
> index 8e1d07b9f1e30..7878b9d7d5248 100644
> --- a/drivers/gpu/drm/drm_simple_kms_helper.c
> +++ b/drivers/gpu/drm/drm_simple_kms_helper.c

[ ... ]

> diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_kms_helper.h
> index cb672ce0e856d..c95f86ff355ff 100644
> --- a/include/drm/drm_simple_kms_helper.h
> +++ b/include/drm/drm_simple_kms_helper.h
> @@ -68,10 +68,6 @@ int drm_simple_display_pipe_init(struct drm_device *dev,
>  			const uint64_t *format_modifiers,
>  			struct drm_connector *connector);
>  
> -int drm_simple_encoder_init(struct drm_device *dev,
> -			    struct drm_encoder *encoder,
> -			    int encoder_type);
> -
>  void *__drmm_simple_encoder_alloc(struct drm_device *dev, size_t size,
>  				  size_t offset, int encoder_type);
>  

[Severity: Low]
This isn't a bug, but since this patch successfully removes the
drm_simple_encoder_init() helper, should it also remove the corresponding
completed task from Documentation/gpu/todo.rst?

Leaving the item in the TODO list might confuse future contributors since the
refactoring effort is now complete.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com?part=14

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic