From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E200CC44530 for ; Mon, 20 Jul 2026 15:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9IXusVLPlsI/2kiebNa0Irvjem/wEj4JDsBfroqG60w=; b=cN5Or8jEMi1gKT 1MyGfY0pwZTV5DSYiyrZWpiWzsmbXISGA/hzi/4F6+1a9gqMGi0NEXnKwhifnAWhNc+GL3lA6ApyG Q7LmLPs5gRz5D33rydbp484ZsE+UnKHJKiMHK5wTuLtqRNBdj1njc3J8NSWzfIpXcnG/RAcVqBkF9 Gq4mM5vZXpu9dGpCTKjdMzDZO4Yptn9XH+SZdoZYQrLBx2V2tA0S4H3D+k3FOwirRqF69LcXqIK0t uCEM1XabZ9uAbhdO5wYMkBIPZ1rcZPIxyA6rA7yXwE1i+gYoWfHr7W2s++Ya9w7AZKWUQkfSkueJw GYbvSi372Qtqr5LdBp3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq6y-00000007Du7-27Sd; Mon, 20 Jul 2026 15:40:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq6x-00000007Ds8-1CGe for linux-amlogic@bombadil.infradead.org; Mon, 20 Jul 2026 15:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=hTB0Lo6KAGt3BbAf6fgIVkW/EL 7aADMLlrRACAmeg2HojsRgJyOzaCLmZk9mjjik0b8mHUmQ2Qvcu7i0teLlqc8A9zx8ewxE5ArUZsL /rULmbaVxGwi75T5MTFX5YlhWmWeprK1udD+V2Ct/Gbybm3OjidRP2iCv0pAns/aHcQPSeligZXzR FG6bA65+lVOP700IqgMjBIW1L+o9i1qvuxmBSo1vEQiwXez8JZOBTtt/u6QpGBfKnIT6aUMLtZfGT JbbXSCJpc5rBokf2v8LFHliKdL4a15t2Gd3aVs/Gq9CvAeH2SLGi9AfW++Y3/1ndTvxYtHyVvgPBG zj81L+AQ==; Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1wlq6u-0000000GkBv-1x3q for linux-amlogic@lists.infradead.org; Mon, 20 Jul 2026 15:40:54 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-476a130c138so6779638f8f.0 for ; Mon, 20 Jul 2026 08:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562050; x=1785166850; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=B6a6qJyyt8oIc1WHf8CL3fFHHKeukD0QIKO9M1jiN0vff7qqJUq+t9mOJMXU7xM96P zScC26k6O1wPkCz08axL0XEz0Orhz/ehobld90NpmW9+wj4k/KO89q/qgoDw6QuiO+rX QxRRqLL9wepq4JMzaGZybX2JxN9DpKo4jbB5jiSstplWr/fm6MknpRUnalRFiwNWAq+1 cObfZDSLLMdoeIWmME5DM6Fizhuo68s+d2piGQVKnrkGyCwSco6OLAlcsvTfaM1VnqAm yZENZE21ryUOxnUX5xLFPdaeGDNXEtt1Xa7Aqx4899MZonwvrRrO7qpHAfzStXmKBh5q P5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562050; x=1785166850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=p0K4SU0+L4R/3AcraytTbXb1LrLnXNngN7ggiLwAfgqMGTcppFKXtQYesYPCCEJltI hLaylAIh5b1PJcTJjcSReryGu4XiLBqBBOC/qKk1WmHwskOhcg1eMarbkpAlJm1+ZhmJ //tlcNhddrwMYRl4dVq7vO77QDG/QW90zWRbO6BobJaW2lWYIXHLEs84ZYWQbk+M7iHS eGfhiftgTM1B9GbSnlDpEMUC6caWU8svUHsLeISf8jjWe+ILa+IgCG+e5RUPuvRANs8Q 8wvpIqD5ghU2kq89+xKqQ6BOO3sUKC1SPpgnbivt84Gj4JYLkpbQgJAoeaQMFDHVjonH BUKA== X-Forwarded-Encrypted: i=1; AHgh+RrX8xHNvN2HOo0ywZ0tk3flEDTYnIc6G7HCe4WW8G12ccA5FmdanKOOl65sGbXuOyS07Fmy7b0LS9+bb9R/@lists.infradead.org X-Gm-Message-State: AOJu0Yxpiivl7Qs2GKXjJ5Qlosu/08IGjSsbP3gsBqNaYD2e7AZFwnRv 8MmJyGMS5wHbdEWtHFLay6eJXw9w8n59FMpOGhPKne3p8Q61ysF6EN4h X-Gm-Gg: AR+sD10nFICtfsxf8nZBSsxkVfz5Jp98HJavK6R4kk8kBNBUYk6pthgsdUV8wqosH5l UXitaeWHFrtxdEnwpg92wyfSaQJTb84YwlTDNHti8y7+OhN9rhjuTH6uqo911KgEAOzRIoUsrst MkPl/923970zaI5KTe0FVomXoXqQ07w0Yzryj46gLOR79zhcnQcrTDkVOYK/nDU7NxN0sP6Pe/L iZC8kOGWOoRaU2RczFSIEmUMZK4LDFzNIUqwOwM9L6wTHzuAZgvvvwnEzrBvk3AagwN0U46ivsY EIInFfnCfA27jJYCnVlQahtpu63L7hDpGVKNBkxuC1FcuQoC0zyFiFsDenEhfccp6+pARUj8TuR Lf3BYTU5HDTFCxbV0eU+9zPX6GILy+Qf5gCPpKdKmM4XrclsWouqWqt9uT6VMlOaBeBjFgO/ujU W2WgTy1XXFIw== X-Received: by 2002:a5d:5885:0:b0:46e:1815:6a83 with SMTP id ffacd0b85a97d-47f62318f12mr16050393f8f.29.1784562049630; Mon, 20 Jul 2026 08:40:49 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:49 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:33 +0200 Subject: [PATCH v2 01/15] drm/exynos: remove dependency on DRM simple helpers MIME-Version: 1.0 Message-Id: <20260720-drm_simple_encoder_init-v2-1-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_164052_671755_1C76FF3C X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 14 ++++++++++++-- 5 files changed, 54 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..957382223956 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + drm_err(drm_dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..de4a80158746 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include