Re: [PATCH v6 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented addition of an `optee` node placed at the incorrect level in the devicetree hierarchy.
--

--- Patch [5]: [PATCH v6 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs ---
commit 613b0bbb17703610934daa7467b942478e1bb9c6
Author: Zhentao Guo <zhentao.guo@amlogic.com>

arm64: dts: amlogic: Add video decoder driver support for S4 SOCs

This commit adds a vdec node and related canvas node to enable Amlogic
V4L2 stateless video decoder support. It also includes an undocumented
addition of an OP-TEE node.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 2a6fbd5308362..04fa52b357a20 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -96,6 +96,11 @@ saradc: adc@fe026000 {
>  		status = "disabled";
>  	};
>  
> +	optee {
> +		compatible = "linaro,optee-tz";
> +		method = "smc";
> +	};
> +

[Severity: Medium]
Is this optee node addition intentional in this patch? The commit message
only mentions adding the vdec node, making this an undocumented change.

Additionally, standard devicetree conventions and OP-TEE bindings expect
the optee node to reside within the /firmware node. Should this be moved
into the existing firmware node rather than being placed at the root level?

>  	soc {
>  		compatible = "simple-bus";
>  		#address-cells = <2>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-b4-s4-vdec-upstream-v6-0-6072a7ee7428@amlogic.com?part=5

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic