From: Neil Armstrong <neil.armstrong@linaro.org>
To: Anand Moon <linux.amoon@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org,
Matthias Kaehlcke <mka@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub
Date: Wed, 18 Jan 2023 09:26:42 +0100 [thread overview]
Message-ID: <21daccb8-9e27-af65-4b90-4bae062be559@linaro.org> (raw)
In-Reply-To: <20230118044418.875-3-linux.amoon@gmail.com>
On 18/01/2023 05:44, Anand Moon wrote:
> On Odroid c1 previously use gpio-hog to reset the usb hub,
> switch to used on board usb hub reset to enable the usb hub
> and enable power to usb hub.
>
> Add usb hub regulator as per the schematic.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v2 - drop the vendor name from compatible string.
> - move the hub node to USB controller node.
> - drop the usb_otg_pwr since it only liked to OTG port
> and link p5v0 to the vdd-supply.
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 04356bc639fa..d1f9ce4742a8 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -281,19 +281,6 @@ &gpio_ao {
> "J7 Header Pin 6", "J7 Header Pin 5",
> "J7 Header Pin 7", "HDMI_CEC",
> "SYS_LED", "", "";
> -
> - /*
> - * WARNING: The USB Hub on the Odroid-C1/C1+ needs a reset signal
> - * to be turned high in order to be detected by the USB Controller.
> - * This signal should be handled by a USB specific power sequence
> - * in order to reset the Hub when USB bus is powered down.
> - */
> - usb-hub {
> - gpio-hog;
> - gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
> - output-high;
> - line-name = "usb-hub-reset";
> - };
> };
>
> &ir_receiver {
> @@ -381,5 +368,16 @@ &usb1_phy {
> };
>
> &usb1 {
> + dr_mode = "host";
> + #address-cells = <1>;
> + #size-cells = <0>;
> status = "okay";
> +
> + hub@1 {
> + /* Genesys Logic GL852G usb hub */
> + compatible = "usb5e3,610";
> + reg = <1>;
> + vdd-supply = <&p5v0>;
> + reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
> + };
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-18 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 4:44 [PATCH v2 0/9] Used onboard HUB to reset and add power to hub Anand Moon
2023-01-18 4:44 ` [PATCH v2 1/9] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2023-01-18 8:17 ` Krzysztof Kozlowski
2023-01-18 4:44 ` [PATCH v2 2/9] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Anand Moon
2023-01-18 8:26 ` Neil Armstrong [this message]
2023-01-18 4:44 ` [PATCH v2 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2023-01-18 8:27 ` Neil Armstrong
2023-01-18 4:44 ` [PATCH v2 4/9] usb: misc: onboard_usb_hub: add Genesys Logic GL852G hub support Anand Moon
2023-01-18 17:18 ` Matthias Kaehlcke
2023-01-18 4:44 ` [PATCH v2 5/9] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2023-01-18 4:44 ` [PATCH v2 6/9] dt-bindings: usb: Add binding for Via lab VL817 hub controller Anand Moon
2023-01-18 8:19 ` Krzysztof Kozlowski
2023-01-18 11:55 ` Anand Moon
2023-01-18 4:44 ` [PATCH v2 7/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c4 Anand Moon
2023-01-18 8:29 ` Neil Armstrong
2023-01-18 11:55 ` Anand Moon
2023-01-18 13:24 ` neil.armstrong
2023-01-19 7:26 ` Anand Moon
2023-01-18 4:44 ` [PATCH v2 8/9] usb: misc: onboard_usb_hub: add VIA LAB VL817 hub support Anand Moon
2023-01-18 17:22 ` Matthias Kaehlcke
2023-01-18 4:44 ` [PATCH v2 9/9] arm64: defconfig: Enable USB onboard HUB driver Anand Moon
2023-01-18 8:29 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21daccb8-9e27-af65-4b90-4bae062be559@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox