From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87977C4167B for ; Sun, 3 Dec 2023 20:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ewMxq9XZxRuN6e1xAUN7jCZ958r1D7tzn/oei9z46wM=; b=vn7DqPrKqg2WYCdoUVYeBkK0LB GlOl8ktuj9i2ro45r/HYhFgAXSIKdrJYfVgMBiY0r80C+fPV19JX/RSbukXn3vf3nBy1v2sADgw9G HyIwoGJjg/BXZB0Zlr1Dtf2kQm2xwdDb+mTozeLK7p590SwziNcTrEoTfSugtnJHGYr2g25LfY4yS CPcIa5gwhLBLI6wadALtj2cZo4VN199UQ2cuFHi6qBC0qxU6OcgvkNiz/nr/3BMkRX1NNFtSclg8i h65L5Gz5STeICQpWmOFMTM2GfPP905DM7NPbqKL1LiOeCVZG73l8N2Wfz4maQ4FfKeFxWUT/Y2AAe tTts+Ovw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r9t2O-002YvY-0l; Sun, 03 Dec 2023 20:26:00 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r9t2K-002Yuz-3B; Sun, 03 Dec 2023 20:25:58 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1701635155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mWJ+aNdDgla6aB8RfWwYvr7B5kGqGCRxqh6xKbSq2wc=; b=PVR0CCV1WRc971ftwf+fTnXvVPx9DB7HXgFoRLGzcnfa4K5fnch4TEMseMxptkpcKSEKZN wGstlWhvUlT0yKzlPJG/ytbfQIzn+nkyRAmIpRK+Mo7YCMKn3LaVElBpqW01N+iZWreVlo U6F0t1DevvvJBTYe7uvafeYl8ebUbFjeJXzBik1Y4gCgqz/dnIpa9RsATQIMWRgV6gpfOr e87Fq2YjDXArbOJscUyA6s4lZc9lGsqUlK8V4amOLod0sYbJpE3OYL3uszJpVI9tSqBTux yChagRYXgjU2tWdJSaXom91KIuRMtnVDJD1L6KBb8IV1Xi3gcvuEciJ1WM7Z8w== Date: Sun, 03 Dec 2023 21:25:54 +0100 From: Dragan Simic To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Andrew Lunn , Arnd Bergmann , Bjorn Andersson , Chen-Yu Tsai , Dmitry Baryshkov , Jonathan Corbet , Michal Simek , Neil Armstrong , Nishanth Menon , Olof Johansson , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Heiko Stuebner , Laurent Pinchart , Konrad Dybcio , Geert Uytterhoeven , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4] docs: dt-bindings: add DTS Coding Style document In-Reply-To: <20231203174622.18402-1-krzysztof.kozlowski@linaro.org> References: <20231203174622.18402-1-krzysztof.kozlowski@linaro.org> Message-ID: <2223b302fc43959a61578aae9cc3a15a@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231203_122557_222282_F4B8D416 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org > +Order of Properties in Device Node > +---------------------------------- > + > +The following order of properties in device nodes is preferred: > + > +1. compatible > +2. reg > +3. ranges > +4. Standard/common properties (defined by common bindings, e.g. > without > + vendor-prefixes) > +5. Vendor-specific properties > +6. status (if applicable) > +7. Child nodes, where each node is preceded with a blank line Another small suggestion... It would be good to put the property names found in the list items, such as "compatible" and "status", into quotation marks, to make it obvious what they are. That way, the list would also be more consistent with the property names mentioned in the sentence right below. > + > +The "status" property is by default "okay", thus it can be omitted. > + > +The above-described ordering follows this approach: > + > +1. Most important properties start the node: compatible then bus > addressing to > + match unit address. > +2. Each node will have common properties in similar place. > +3. Status is the last information to annotate that device node is or > is not > + finished (board resources are needed). _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic