From: Christian Hewitt <christianshewitt@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] WIP: arm64: dts: meson: drop broadcom compatible from reference board SDIO nodes
Date: Wed, 27 Nov 2024 08:05:33 +0400 [thread overview]
Message-ID: <2B479B54-2784-4D75-BEE8-23A52EEFBF17@gmail.com> (raw)
In-Reply-To: <027767d4-89e7-4665-b840-294a84a89869@linaro.org>
> On 24 Nov 2024, at 8:11 pm, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> On 24/11/2024 09:34, Christian Hewitt wrote:
>> Drop the Broadcom compatible and use a generic sdio identifier with the Amlogic
>
> 1. Heh, what? Why? This is not really explained and does not look
> sensible at all.
> 2. What is "generioc sdio identifier"?
>
>> reference boards. This allows a wider range of Android STB devices with QCA9377
>> and RTL8189ES/FS chips to have working WiFi when booting from the reference dtb
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
>
>> files. There is no observed impact on Broadcom devices.
>
> So how does it allow wider range of devices to have working wifi?
Sending patches while recovering from a 100km Triathlon last weekend
resulted in some formatting and submission mistakes - sorry for that :(
I’ll send a v2 shortly with reduced subject/line length and a better
description of the change and reasoning.
Christian
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2024-11-27 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 8:34 [PATCH] WIP: arm64: dts: meson: drop broadcom compatible from reference board SDIO nodes Christian Hewitt
2024-11-24 16:11 ` Krzysztof Kozlowski
2024-11-27 4:05 ` Christian Hewitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B479B54-2784-4D75-BEE8-23A52EEFBF17@gmail.com \
--to=christianshewitt@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox