Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing

From: Christian Hewitt <christianshewitt@gmail.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	MMC <linux-mmc@vger.kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	AML <linux-amlogic@lists.infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
Date: Sat, 1 Apr 2023 10:38:53 +0400	[thread overview]
Message-ID: <2E930ABF-DA2A-4BB0-A2A2-56495305118D@gmail.com> (raw)
In-Reply-To: <20211223171202.8224-3-s.shtylyov@omp.ru>

> On 23 Dec 2021, at 9:11 pm, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> 
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
> 
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 8f36536cb1b6..c765653ee4d0 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> 	}
> 
> 	host->irq = platform_get_irq(pdev, 0);
> -	if (host->irq <= 0) {
> -		ret = -EINVAL;
> +	if (host->irq < 0) {
> +		ret = host->irq;
> 		goto free_host;
> 	}
> 

Can I ask if this patch/series [0] has been superseded or forgotten or ??

The series it depended upon [1] appears to have been merged a year ago as I
can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
and its ilk”) in upstream code. I’ve had this patch in my testing kernel for
12+ months now with no observable negative impacts so am wondering if it can
be resent and merged or I should drop the patch from my tree?

Thx. Christian

[0] https://www.spinics.net/lists/linux-mmc/msg68102.html
[1] https://marc.info/?l=linux-kernel&m=163623041902285

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic