From: Johannes Berg <johannes@sipsolutions.net>
To: Ai Chao <aichao@kylinos.cn>,
perex@perex.cz, tiwai@suse.com,
kuninori.morimoto.gx@renesas.com, lgirdwood@gmail.com,
broonie@kernel.org, jbrunet@baylibre.com,
neil.armstrong@linaro.org, khilman@baylibre.com,
martin.blumenstingl@googlemail.com, shengjiu.wang@gmail.com,
Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
srinivas.kandagatla@linaro.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, imx@lists.linux.dev,
kernel@pengutronix.de, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ASoC: aoa: Use helper function for_each_child_of_node_scoped()
Date: Thu, 22 May 2025 12:04:23 +0200 [thread overview]
Message-ID: <3fa189cfc0a52572008590efbf5f4ad05c81dbc6.camel@sipsolutions.net> (raw)
In-Reply-To: <20250522050300.519244-3-aichao@kylinos.cn>
On Thu, 2025-05-22 at 13:02 +0800, Ai Chao wrote:
> The for_each_child_of_node_scoped() helper provides a scope-based
> clean-up functionality to put the device_node automatically, and
> as such, there is no need to call of_node_put() directly.
>
> Thus, use this helper to simplify the code.
> - for_each_child_of_node(dev->ofdev.dev.of_node, np) {
> + for_each_child_of_node_scoped(dev->ofdev.dev.of_node, np) {
> if (of_device_is_compatible(np, "i2sbus") ||
> of_device_is_compatible(np, "i2s-modem")) {
> got += i2sbus_add_dev(dev, control, np);
Given the structure of this code, this either fixes a leak, or is wrong.
I really don't know which of those two it is, it's been decades, but
either way it's not a change that simply "simplif[ies] the code".
johannes
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-05-22 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 5:02 [PATCH v2 0/6] Use helper function for_each_child_of_node_scoped() Ai Chao
2025-05-22 5:02 ` [PATCH v2 1/6] ASoC: ppc: " Ai Chao
2025-05-22 10:00 ` Mark Brown
2025-05-22 5:02 ` [PATCH v2 2/6] ASoC: aoa: " Ai Chao
2025-05-22 10:04 ` Johannes Berg [this message]
2025-05-23 10:51 ` Christophe Leroy
2025-05-26 8:53 ` Ai Chao
2025-05-22 5:02 ` [PATCH v2 3/6] ASoC: renesas: " Ai Chao
2025-05-22 5:02 ` [PATCH v2 4/6] ASoC: meson: " Ai Chao
2025-05-22 5:02 ` [PATCH v2 5/6] ASoC: imx-card: " Ai Chao
2025-05-22 5:02 ` [PATCH v2 6/6] ASoC: qcom: " Ai Chao
2025-05-22 12:37 ` Dmitry Baryshkov
[not found] <2aq0nyvyf7t-2aq4hsc7kp6@nsmail7.0.0--kylin--1>
2025-05-23 10:40 ` [PATCH v2 2/6] ASoC: aoa: " Johannes Berg
2025-05-26 8:12 ` Ai Chao
2025-05-26 8:13 ` Johannes Berg
2025-05-26 8:20 ` Ai Chao
2025-05-26 8:21 ` Johannes Berg
2025-05-30 9:30 ` Ai Chao
2025-05-28 19:23 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa189cfc0a52572008590efbf5f4ad05c81dbc6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Xiubo.Lee@gmail.com \
--cc=aichao@kylinos.cn \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox