From mboxrd@z Thu Jan 1 00:00:00 1970 From: arvind.yadav.cs@gmail.com (Arvind Yadav) Date: Sat, 18 Nov 2017 15:03:47 +0530 Subject: [PATCH 5/6 v2] mmc: sh_mmcif: Handle return value of platform_get_irq In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> References: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> Message-ID: <59e155d8c3eff4adf39cd343c56e52530020f64d.1510997223.git.arvind.yadav.cs@gmail.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/mmc/host/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 53fb18b..481f2c4 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev) irq[0] = platform_get_irq(pdev, 0); irq[1] = platform_get_irq(pdev, 1); - if (irq[0] < 0) { + if (irq[0] <= 0 || irq[1] <= 0) { dev_err(dev, "Get irq error\n"); return -ENXIO; } -- 2.7.4