From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (jbrunet at baylibre.com) Date: Tue, 24 Jul 2018 12:03:10 +0200 Subject: [PATCH] ASoC: meson: axg-spdifout: select SND_PCM_IEC958 In-Reply-To: <20180724093705.1691747-1-arnd@arndb.de> References: <20180724093705.1691747-1-arnd@arndb.de> Message-ID: <59fdcf671ffd0ef60e4d982ba269f853089ee7da.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, 2018-07-24 at 11:36 +0200, Arnd Bergmann wrote: > When CONFIG_SND_PCM_IEC958 is disabled, we get a link error for the > new driver: > > sound/soc/meson/axg-spdifout.o: In function `axg_spdifout_hw_params': > axg-spdifout.c:(.text+0x650): undefined reference to > `snd_pcm_create_iec958_consumer_hw_params' I used arm64 defconfig to do all my test and this symbol was selected by the HDMI codec driver, which is probably why missed it. Thanks a lot for fixing the problem Arnd. > > The other users use 'select', so we should do the same here. > > Fixes: 53eb4b7aaa04 ("ASoC: meson: add axg spdif output") > Signed-off-by: Arnd Bergmann Acked-by: Jerome Brunet