From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0DC9CA0EE4 for ; Wed, 13 Aug 2025 07:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W0aajGl4yHwrLvGoweNcPypLYvfifV8mqdBQsWprl+Y=; b=PqQan+nKprZRgD UTIKWv1uy82dm0WD/EhAeLfpP51uLXdH+kYtLjSWfKXLir02l3YORhElz1SQH4O1WNzVMUoshQwSD fUSWDYXdmZL4BdEVZ+Sllly8ppR5m71KZ7iibmwWpxuux5d5uDvdUwA3INbmO2ep9UCasmwtFL57I llJseY070kMESb/hl67WDIeEnIZZFjdsG3VtlRNvLKhcLm7AzE/iDJ/XSfLcLpy03i2doHDOGAogx Zw5MvIeRptu5wNNbiPcYonw3+4CgfVe2Ser5Agh0NnVTEmPnv9EOJHJRTAE81WogwYNOyHp7pHZgS 6b1JRs6X9x0xyDwwf7Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1um6K5-0000000D0CD-1jgC; Wed, 13 Aug 2025 07:55:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1um62i-0000000Cwsl-1ysA for linux-amlogic@bombadil.infradead.org; Wed, 13 Aug 2025 07:37:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=6iImFGHV7XQXKsjJsxQOLqElkvvjbpXd/F2IlDq2zwI=; b=SLbAg5YhpmqGjV1VgPacHY213r ZDNREoIZEJAbcwpBLhkeognLniJN1E/M30NOCmiWmmvCjUYcVZ4TXRr5SNNDz0qrFhHzCp5GiJVC/ O3scKKDBV5Bj4huJaZDmxy/LPoyZz1FdcoOw/LlgegZ49FUdZAFzbeO4SCGkRdiWeLuFpZm280ELV 0ve4xOMF8BQNHVd1Dv03RtNRmxi4IcJJmgHwY9FScSvRUkPUv3jjK3gFZnjWv6qpG5p3v3p5mxoa+ rNo5t+pkjPneM3uFQi9CWBG6+IHXRFkWDE1vzUhEA9zzIfXnmbMhnkaHcnBeL5FxsVmIzOMlCTM5B N5uDYmww==; Received: from nyc.source.kernel.org ([147.75.193.91]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1um62f-0000000FzH3-2Mhq for linux-amlogic@lists.infradead.org; Wed, 13 Aug 2025 07:37:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 628E1A56EC3; Wed, 13 Aug 2025 07:36:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63CFDC4CEEB; Wed, 13 Aug 2025 07:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755070618; bh=yd7WnsqfEHhrl3xdnaa0V6HrvSWXxNrKc3LtxXpEtkM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FH+1mJ9d4zEdDwHjhFN812mwVyPsKVQ4gSbWptxq6FcPOCmBt/6cp6URfl7TkxAat ZPEg3PKLgL27y5yTnQFZ1N56+3IVfHZHr9OKce2Nh78vVtax6oC9xqnvJjKpA2PjPp yy6uKPgjhquEowS/C+s2O7QFP5FjdVEeYLVNIXQq8IA6rLkMqXD2Sq7ok0H3hyNW+4 /9/5L6F+h/sIHXKH9cIYGzbw6K4Q2x4F8gJlbQy5V37h54XoYMWd974qCR+xMMgmF7 JHo82Xf/O+8gmXIeN4eGCPAkEx3GNaAMa3ibbp3Zap3m07su+E7F/UABg3kO/sxUrA +Jqf/PrOi+tTA== Message-ID: <5cc336bc-f071-41d2-b59a-af0df23af00b@kernel.org> Date: Wed, 13 Aug 2025 09:36:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] spi: dt-bindings: add doc for Amlogic A113L2 SFC To: Xianwei Zhao Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liang Yang , Feng Chen , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org References: <20250808-spifc-v1-0-ff4e30e26a6b@amlogic.com> <20250808-spifc-v1-1-ff4e30e26a6b@amlogic.com> <20250808-adamant-fat-raven-38c8b3@kuoka> <7fab19de-8ed1-4fe5-b2a4-a7e9c13d8424@amlogic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <7fab19de-8ed1-4fe5-b2a4-a7e9c13d8424@amlogic.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250813_083701_894598_4E7F38AC X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 13/08/2025 08:13, Xianwei Zhao wrote: >>> +allOf: >>> + - $ref: /schemas/spi/spi-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: amlogic,a4-spifc >>> + >>> + reg: >>> + items: >>> + - description: core registers >>> + - description: parent clk control registers >> >> Why are you poking to parent node or to clock registers? This looks like >> mixing up device address spaces. >> > > The SPIFC bus clock multiplexes EMMC modules, so the corresponding > frequency division register is also in EMMC module. The SPIFC and the > EMMC modules cannot be used simultaneously. Then obviously you cannot put here EMMC or parent registers. It looks really like you miss proper hardware representation. > >>> + >>> + reg-names: >>> + items: >>> + - const: core >>> + - const: pclk >>> + >>> + clocks: >>> + items: >>> + - description: clock gate >> >> Are you sure this is separate clock input to this device? >> > > This clock is used by the APB interface to access the SPIFC registers. So APB clock? Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic