From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65275C4167B for ; Thu, 7 Dec 2023 12:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RQcuMh2dPVBT+vmbp5MnQ0BfuMdp9qwJuc3LyGF8ZBU=; b=aINtn7Vcfasdw/ dMPlTyTVTkcO5dzpMeM9NMN80GqpDrnjg8uiUkBFNSsXpVpgwyiuj5SfjK/9uprr9jOJWirYR4Hws eEtfHxhGGYwVCWMHHQLz4d2EQcA1CU+iBfCofptBvpOHpKGBk0raHIHn2HVs0hc2iAWjyTyMRvVj4 4e9banz2sP/5F4MlyeaFt8tE7um92cND4QQ9wnKc3WK3bL6de3HMIuiCAnIWf5qF51wVJPB5Mr7lK s9/6O/yQSNETaSV/3VW8ioSuBG09drz71ou+oH8HxgIkRvYDH/LPfhqdKwFlT9f21hCced/k1y6X+ /+7UyDIKC7Y6m6iVfrPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBDge-00CpBd-0c; Thu, 07 Dec 2023 12:41:04 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBDgb-00CpB7-1v for linux-amlogic@lists.infradead.org; Thu, 07 Dec 2023 12:41:03 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a1f37fd4b53so39731366b.1 for ; Thu, 07 Dec 2023 04:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701952859; x=1702557659; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ukN90Di1G2R4M3iUHGuDrVWfWD5h0aTfPPTqZizy9y8=; b=tEFIzNEuWGQz24NkFUuiEtX9xsRD26z05AMiG9kPwrVOeVOkl5chGemY4gk+RsDQb8 LOMD8pQvsP29+dlSTDmKf7VMu87f6LPkUtkNoh0b4J87OWn/g/R/iNeoeKkDz218dU7V GWcDdCENBelZdK2VCzrjzPepFikoOyZGXmd4o4IAA/eldzByADnHHjH6SRHoqVC/jdUS ho/lbpjhOmZ+fHX1UGKSadwjm6y9W2LlmApZzOjXDR0fw9pBAX64X2kfp5fOT9YAaWcm 0rxjJELXVXbd3YIGowC7B4f4a7eSLfKPDs9Uxhtaz9VZvkegrUfFNWiTC6jMQ/C30/yW 4v8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701952859; x=1702557659; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ukN90Di1G2R4M3iUHGuDrVWfWD5h0aTfPPTqZizy9y8=; b=ZKhi7RX/z7HPXlo1cPzuqkrTie8PEy4AeJKHdMwxY6cTDGIECUhVmL5EuGX58O18Kd skhVQXGRgGVmalHL+TN2kApk7APA6UQux05bVRQ5EolRUMvq93vrRx7EbZxlkbkRzlK/ aBSoJMnWpCVRUctcG64lc/Cvn/vS/VymIZZRZuBo3HHuM+/n6ZUCc2wKICfbJq0e00FL uOma6dKvHTI0fttgO+sShfM5PcZq4zN4vdzEdLpJB6ewRUGjUGjcZUT4sabVuKdRfVT9 R17aH0Xqpa06uO0HJwZ+FFzVGZEByFnWbSP1w+igAkGxcOQi0FY9m1caN3flQ8Tu5xAd CN/w== X-Gm-Message-State: AOJu0Yx8hwxww0SGlCcWbUTFsmm2EoiP9Oh5odb+obhf+rWsvznIVgei bX0FgcclMoFDnYaKO9eEYlhbuA== X-Google-Smtp-Source: AGHT+IG43Ix3H4WQbq/IkviZiMqnIWharU7qBkTL7bxP9W+ryA5kt3uxVxSyBnQWoOeqCvZ1aw8+aA== X-Received: by 2002:a17:906:1113:b0:a1c:9dc1:3042 with SMTP id h19-20020a170906111300b00a1c9dc13042mr1393818eja.1.1701952859422; Thu, 07 Dec 2023 04:40:59 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id lt10-20020a170906fa8a00b00a015eac52dcsm777725ejb.108.2023.12.07.04.40.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 04:40:58 -0800 (PST) Message-ID: <604e653d-c1e2-45c7-b121-8a6b4be5c6bb@linaro.org> Date: Thu, 7 Dec 2023 13:40:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub Content-Language: en-US To: Anand Moon Cc: Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Icenowy Zheng , Neil Armstrong , linux-amlogic@lists.infradead.org, Conor Dooley , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231204144429.45197-1-linux.amoon@gmail.com> <20231204144429.45197-2-linux.amoon@gmail.com> <20231206135311.GA2043711-robh@kernel.org> <21673bfd-bb87-4c7d-a53f-337c263f3a00@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_044101_637754_884D913D X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 07/12/2023 13:33, Anand Moon wrote: > Hi Krzysztof > > On Thu, 7 Dec 2023 at 14:00, Krzysztof Kozlowski > wrote: >> >> On 06/12/2023 18:14, Anand Moon wrote: >>> Hi Rob, >>> >>> On Wed, 6 Dec 2023 at 19:23, Rob Herring wrote: >>>> >>>> On Mon, Dec 04, 2023 at 08:14:25PM +0530, Anand Moon wrote: >>>>> Add the binding example for the USB3.1 Genesys Logic GL3523 >>>>> integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed >>>>> hub. >>>>> >>>>> For onboard hub controllers that support USB 3.x and USB 2.0 hubs >>>>> with shared resets and power supplies, this property is used to identify >>>>> the hubs with which these are shared. >>>>> >>>>> GL3523 has built-in 5V to 3.3V and 5V to 1.2V regulators, which serves >>>>> power to the USB HUB, it uses 5V power regulator. >>>>> >>>>> Reviewed-by: Conor Dooley >>>>> Signed-off-by: Anand Moon >>>>> --- >>>>> V6: fix the description of the regulators >>>>> Updated the commit message for regulator updates. >>>>> add reviewed by Conor Dooley >>>>> [1] https://lore.kernel.org/all/20231130053130.21966-2-linux.amoon@gmail.com/ >>>>> v5: upgrade peer-hub description : Conor Dooley >>>>> [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] >>>>> v4: Fix the description of peer-hub and update the commit message. >>>>> Schematics of the Odroid N2+ >>>>> https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf >>>>> V3: fix the dt_binding_check error, added new example for Genesys GL3523 >>>>> v2: added Genesys GL3523 binding >>>>> v1: none >>>>> --- >>>>> .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- >>>>> 1 file changed, 61 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml >>>>> index ee08b9c3721f..c6f63a69396d 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml >>>>> @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller >>>>> maintainers: >>>>> - Icenowy Zheng >>>>> >>>>> -allOf: >>>>> - - $ref: usb-device.yaml# >>>>> - >>>>> properties: >>>>> compatible: >>>>> enum: >>>>> @@ -27,12 +24,46 @@ properties: >>>>> >>>>> vdd-supply: >>>>> description: >>>>> - the regulator that provides 3.3V core power to the hub. >>>>> + The regulator that provides 3.3V or 5.0V core power to the hub. >>>>> + >>>>> + peer-hub: >>>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>>> + description: >>>>> + For onboard hub controllers that support USB 3.x and USB 2.0 hubs >>>>> + with shared resets and power supplies, this property is used to identify >>>>> + the hubs with which these are shared. >>>>> >>>>> required: >>>>> - compatible >>>>> - reg >>>>> >>>>> +allOf: >>>>> + - $ref: usb-device.yaml# >>>>> + - if: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - usb5e3,608 >>>>> + then: >>>>> + properties: >>>>> + peer-hub: false >>>>> + vdd-supply: false >>>>> + reset-gpios: true >>>>> + >>>>> + - if: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - usb5e3,610 >>>>> + - usb5e3,620 >>>>> + then: >>>>> + properties: >>>>> + peer-hub: true >>>>> + vdd-supply: true >>>>> + reset-gpios: true >>>> >>>> No need for this if schema. The default is they are allowed. >>>> >>> >>> If I move reset-gpios to required, I observe the below warning. >>> >>> DTC_CHK Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb >>> /home/alarm/linux-amlogic-5.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: >>> hub@1: 'reset-gpio' is a required property >>> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# >> >> Where are the properties defined? If you open the binding you see: >> nowhere. You cannot define properties in some variant with "true". >> Please define all of them in top-level and only narrow/constrain when >> applicable. >> > What I meant is the example below, required meant applicable for both > the binding > But it shows me the above warning. My explanation stands... So again: >> Please define all of them in top-level and only narrow/constrain when >> applicable. Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic