From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F312C19F2C for ; Tue, 2 Aug 2022 12:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RhYX37OI8CIqyLuXmZzjT0MdXlkBjAfvy1Ty8pu5Iv4=; b=hnNZVmIKbZ9AGi mcGNs0TGtBna2No0E+UcIrPeG8KvSilvP5ZXnogfW6nwayiBWRP4f4yehmMim/vrDw+c/wf07MsoU /HojyxqPHpJwHGOrm2CzSQJr9y5dUDX1CzTw83CxyUiMtXj0rFfdZkT5hkKfrh0ChmHkhp6ad0tHM JzTuqBAT3WS8KsKdA/p15eJuRxkS6FXY2u46BaH0Z0gy+cDl6YaenFo02c4GDFN40KfJ1yAthIf5l U0HiMYs3FHQOTyN8zdwUxg0eVJ5u/zeBJmcdfpF+iUNraccH5gLcksjS9Z+ijsIlqsKzUbF+I6B1P QW3VKeQ4trKXWDX/YjeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIqml-00Dp2U-Fr; Tue, 02 Aug 2022 12:14:07 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIqmU-00Doly-TM for linux-amlogic@lists.infradead.org; Tue, 02 Aug 2022 12:13:53 +0000 Received: by mail-lf1-x129.google.com with SMTP id c17so3154846lfb.3 for ; Tue, 02 Aug 2022 05:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wULxbsFCsO2mWrH1kUgZI39H39Fg7/Dp3JHxKstJL5w=; b=EapWLVMYRopIPrmUKWyWH2kAktnoZuyQiFxSnUGnAm2RX/uVkzChEsKWao/PShY7/1 1vbrASNFKANYzAcRwdV7gqzkin//gHK2GmpDYsMVObW4YABwrCSpaINBp6kUdjP1afEZ iI4P4akwdwJlZGu+K/t7+ysdcqDZn6iVwfrJTyDz53NLvY71711JxNxBa/h/3uxiRWL/ rM+AnmCR3pHa+FdKQzZPWysUqZEV5FGncWvveW49o1RXmVE0Aqybe422Xx2uVmJe7hBb P2u4vSDYYfySTnJmYwYuinfDjcwDq5YTwIq/1LiuXyfBYg8XVBHUat36CWjmaAFJfm1P ZnZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wULxbsFCsO2mWrH1kUgZI39H39Fg7/Dp3JHxKstJL5w=; b=CUZm6E4P81tsyBsnr8y9nQNpRVaczF8q7XPSx4ahgytAixyAVNTyUbzxW+Anr6/TgV 4rfFJ7QLn1sG9nN5123lnlo462iJtYyvqe6M6epXlE0b0CJ9GBfe4hlL+yZ97rbyBVoA UCrVFOjYxxSb8P/noqi/zHVv/3JDwEa2VMujXHiu8JZezW8lSLhH8kY5koq8U7ZzT1Ru Rv0IzvRlKwrIyeJ7mPhJpjYOKjyUhy7oVcE9trycFo/HH6tXkhWZOWzEIpvbPmbVl7TB kvnNUmpYNAtY0xKjdl7LSTvxuFJ3hGoarhfBT7NRTWgvgJzIAogzjNXl7pbh+g1YFOIm IOHQ== X-Gm-Message-State: ACgBeo0Sdu8OYaHf198q7e9flKQjxAU7JjheOQ6iBJcruEZb8qdPim7W CvLIvpst6TEeLW4myxcpkC0VPQ== X-Google-Smtp-Source: AA6agR4+VPCL3CF9Zzr8gFl9yGLK6jXfEOZBDb20OqWPvS8Z8zJbaesexcOruBvxvOr7AubCzNyF3g== X-Received: by 2002:a05:6512:3989:b0:48a:e4de:cc36 with SMTP id j9-20020a056512398900b0048ae4decc36mr6227240lfu.207.1659442425220; Tue, 02 Aug 2022 05:13:45 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id f15-20020a05651232cf00b0048b17b0db44sm46652lfg.61.2022.08.02.05.13.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 05:13:44 -0700 (PDT) Message-ID: <64c9ffc1-6f4b-7ddb-01ab-1ddf9ba628db@linaro.org> Date: Tue, 2 Aug 2022 14:13:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 4/4] dt-binding: perf: Add Amlogic DDR PMU Content-Language: en-US To: Jiucheng Xu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy References: <20220801060049.1655177-1-jiucheng.xu@amlogic.com> <20220801060049.1655177-4-jiucheng.xu@amlogic.com> <0893fab6-a7e1-bfa7-2497-239e044cc7ed@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_051351_010487_727DF407 X-CRM114-Status: GOOD ( 32.08 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 02/08/2022 11:25, Jiucheng Xu wrote: > > On 2022/8/2 16:04, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 01/08/2022 08:00, Jiucheng Xu wrote: >>> Add binding documentation for the Amlogic G12 series DDR >>> performance monitor unit. >>> >>> Signed-off-by: Jiucheng Xu >>> --- >>> Changes v2 -> v3: >>> - Remove oneOf >>> - Add descriptions >>> - Fix compiling warning >>> >>> Changes v1 -> v2: >>> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >>> - Delete "model", "dmc_nr", "chann_nr" new properties >>> - Fix compiling error >>> --- >>> .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 51 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 52 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> new file mode 100644 >>> index 000000000000..961656d4db6e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> @@ -0,0 +1,51 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> You still did not test the bindings... >> >> You received such comment (with instructions how to do it) and still >> decided to send untested bindings. >> >> That's not how submission procces should look like. >> >> NAK, till you send something which you actually test. >> >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > > Thanks for your time. I think I got a wrong understanding. > > As the binding doc says, I run the following command to check: > > # make dt_binding_check DT_SCHEMA_FILES=amlogic,g12_ddr_pmu.yaml ARCH=arm64 Ah, cool, thanks. > > I saw the warning/errors in v2 patch, and thanks to your comments let > them gone. > > But I didn't see any warning/errors keywords printing in v3 except the > message as below: > > "$id: relative path/filename doesn't match actual path or filename". > > > I admit I didn't understand this prompt. I found the doc in example says > that: > > # $id is a unique identifier based on the filename. There may or may not > be a > # file present at the URL. > > So I thought that was not warning/errors prompt. Unfortunately, it is and warning message. The final part of this ID is directory and filename - these must match real file path. > > Today, I find the root cause of the warning/errors prompt. > > I think I have fixed it and the building log is so quiet. > > > This is my first upstream patch, TBH I even didn't know what is binding > before. > > In order to upstream my driver, I try to learn how to write binding scheme. > > It looks like I still did terribly. > > I think my stupid misunderstanding get you angry. I'm sorry for wasting > your time and comments. Apologies for being harsh. We all make mistakes and hopefully learn from them. > > I will re-submit v4 to fix it. > Awesome, thank you! Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic