From: Neil Armstrong <narmstrong@baylibre.com>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>,
linux-amlogic@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [RFC PATCH 3/4] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
Date: Mon, 18 Nov 2019 11:26:21 +0100 [thread overview]
Message-ID: <65a64f28-c1fe-0ce2-d954-e96bc1924001@baylibre.com> (raw)
In-Reply-To: <20191117175606.5050-4-mohammad.rasim96@gmail.com>
On 17/11/2019 18:56, Mohammad Rasim wrote:
> This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design
>
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../boot/dts/amlogic/meson-gxbb-kii-pro.dts | 39 +++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 84afecba9ec0..a795a170dcab 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
> new file mode 100644
> index 000000000000..b63dabb7bf97
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> +/* Copyright (c) 2019 Mohammad Rasim <mohammad.rasim96@gmail.com>
> +*/
> +
> +/dts-v1/;
> +
> +#include "meson-gxbb-p20x.dtsi"
> +
> +/ {
> + compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
> + model = "Videostrong KII Pro";
> +
> +
> +};
> +
> +&uart_A {
> + status = "okay";
> + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
> + pinctrl-names = "default";
> + uart-has-rtscts;
> +
> + bluetooth {
> + compatible = "brcm,bcm4335a0";
Use "brcm,bcm43438-bt" here if the I/F is compatible.
> + };
> +};
> +
> +ðmac {
> + status = "okay";
> + pinctrl-0 = <ð_rmii_pins>;
> + pinctrl-names = "default";
> + phy-mode = "rmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0>, <10000>, <1000000>;
> + snps,reset-active-low> +};
> +
> +
>
Did you try to determine the PHY and add a PHY node aswell ? The reset stuff could go in the PHY node.
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-11-18 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:56 [RFC v2 PATCH 0/4] add support for videostrong KII Pro Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 1/4] dt-bindings: Add vendor prefix for Videostrong Technology Co., Ltd Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong
2019-11-17 17:56 ` [RFC PATCH 2/4] dt-bindings: net: Add compatible for BCM4335A0 bluetooth module Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong
2019-11-18 17:53 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 3/4] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-11-18 10:26 ` Neil Armstrong [this message]
2019-11-18 19:21 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 4/4] Bluetooth: btbcm: Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-18 10:04 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a64f28-c1fe-0ce2-d954-e96bc1924001@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mohammad.rasim96@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox