From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A866D42B8C for ; Tue, 12 Nov 2024 14:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XaonHna3iatjG6+0AE27R8QilcyQQuRf+ptXLUMM3Zs=; b=oIdXzJb0B1JLqNSirK/i0IDIL0 xaCpnYN5B64yjwofoz6g7I6cgBX7c2DFv53jaaHTkTkzBoGujk95yXRyMRfZkV78Ci1JFG8c1frpy GKID1HGAfQRR3ITtDQaVyaymKgpLrU4mSSf89c++Me0eR/RKURDWbl6+wkoyXLmOKolU3BMntH2mV ie7IQwVjrQP3TIgSdqPRRF2yCfOTFZnpUfEWdaHEW0h4xG5PdgcMPY59fbhICCDCsVR3T921SZFFz 7cUFHd5htTXSLL4EzoiaVQotk79nJDqQeTppDOMWoaMzR3OHrhthZUWQIcsmTdzxE0vc9++WA0qTY aGMAtOvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAs9a-00000003oFH-2kye; Tue, 12 Nov 2024 14:46:02 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAqwf-00000003Z0f-1gS1 for linux-amlogic@lists.infradead.org; Tue, 12 Nov 2024 13:28:38 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-37d43a9bc03so3903030f8f.2 for ; Tue, 12 Nov 2024 05:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731418116; x=1732022916; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=YsaZoX49/UTmnCYipmJYozRv1F9KJT6zGJ2FPgwHPM0=; b=PI9d/JlrFZbqqSYlUH/RfFAkrbgtL40FNYV3MFBSENTDmAgU42SMMnDx/7YWYHpoi6 YoUduQGg7d6OVHmgUJFwq6uQs7uF7E0VkzhkipXSI3x5zrWmmgWTyiqdB9CKqg8SnWtU xvCVMPsaPpCTFER3v+v5B23yAxcxykq55MOyNFECj6kbitjD2NiQS/h679sDz3qLOaEw ZSXIr4jx/iizlseazybTatfkvEM9NkJkQZrh6p0ei8G2YBSWOV0yOhAPzBuVhSruvrIb gpyP9sOTJJ8IkqoHXPMFgsNPhlEcAAsf9P3+UewqUiEI0AJw3TwgEKoFKuMr2ZVxwub0 PTzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731418116; x=1732022916; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YsaZoX49/UTmnCYipmJYozRv1F9KJT6zGJ2FPgwHPM0=; b=tPYIQorf1F4S1vwReprM1IrZfe0OA01oolTRcpPCH6zB3nci3AMVVi6lQvx/7P9Uzt rSbxuzgwJwpGzJDsS+zCkbEDZ6uXEd1H6Bla4hfICtLit87cLKFJGADvCO2EmWBI2rIg xKS14YaU/iifNZ20L7AkZHpOMXWoIEkkfkC3/FLDeSroczMJfu3bcekY1fsZ83tFLSHx 2yOJjFMP8DZ22JFIwvF9iiuxJUt8CZOWnMDWeIEG1UktwgZif5g6ytlLTRFNROXNgu01 sKPuBvaC81K8lz8vY6njNH2lkrW3X0pATp12mNOgR5reM2zyCK8Pala/4eJjbdsDCEUQ QCyg== X-Forwarded-Encrypted: i=1; AJvYcCWJz9/ReyDfnrhtfYMqjZ/FTEjxEj9g5S9xkx3UxsfPoZSau2jWiyTyhHPfvxRyxJmWd0jBvWdwHcDXSvdB@lists.infradead.org X-Gm-Message-State: AOJu0Ywb4DymMWctAMMyx0j0RU03OK1mvDhyfzdSyANXH9uOMvNDTn5O jJ+qMpqKwwZHgEQDKGq0zZ3n6XNsRvtWW7DLPF0zeArpomstCZbOn1tFKho5oDA= X-Google-Smtp-Source: AGHT+IGcxUmMqHN8a/cQuWmNKDKEmC6I6tUTcWYjNJv51eGA/I3ZpzDc+lB74YRdvxBPxcRvqG1PMg== X-Received: by 2002:a05:6000:186e:b0:382:b57:f0b5 with SMTP id ffacd0b85a97d-3820b57f16amr747635f8f.12.1731418115692; Tue, 12 Nov 2024 05:28:35 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:860c:aff4:d0e9:9db8? ([2a01:e0a:982:cbb0:860c:aff4:d0e9:9db8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381eda04111sm15330046f8f.92.2024.11.12.05.28.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 05:28:35 -0800 (PST) Message-ID: <69918f77-c0d6-4151-b725-e5051f0f6680@linaro.org> Date: Tue, 12 Nov 2024 14:28:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v5 3/5] pinctrl: meson: add interface of of_xlate To: xianwei.zhao@amlogic.com, Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241112-a4_pinctrl-v5-0-3460ce10c480@amlogic.com> <20241112-a4_pinctrl-v5-3-3460ce10c480@amlogic.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241112-a4_pinctrl-v5-3-3460ce10c480@amlogic.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_052837_501397_25CDC7B4 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 12/11/2024 11:26, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao > > Amlogic pinctrl software framework use system API of_gpio_simple_xlate > which only support linear one-to-one correspondence to translate gpiospec > to the GPIO number and flags before. It can not meet the non-linear needs. > Add the interface satisfies the underlying driver to implement the > transformation to meet the needs of various scenarios. > > Signed-off-by: Xianwei Zhao > --- > drivers/pinctrl/meson/pinctrl-meson.c | 4 ++++ > drivers/pinctrl/meson/pinctrl-meson.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c > index 253a0cc57e39..fc0c0bef38c0 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.c > +++ b/drivers/pinctrl/meson/pinctrl-meson.c > @@ -620,6 +620,10 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc) > pc->chip.base = -1; > pc->chip.ngpio = pc->data->num_pins; > pc->chip.can_sleep = false; > + if (pc->data->of_xlate) { > + pc->chip.of_gpio_n_cells = pc->data->of_gpio_n_cells; > + pc->chip.of_xlate = pc->data->of_xlate; > + } > > ret = gpiochip_add_data(&pc->chip, pc); > if (ret) { > diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h > index 7883ea31a001..cbb3f22552b9 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.h > +++ b/drivers/pinctrl/meson/pinctrl-meson.h > @@ -120,6 +120,10 @@ struct meson_pinctrl_data { > const struct pinmux_ops *pmx_ops; > const void *pmx_data; > int (*parse_dt)(struct meson_pinctrl *pc); > + int (*of_xlate)(struct gpio_chip *gc, > + const struct of_phandle_args *gpiospec, > + u32 *flags); > + int of_gpio_n_cells; > }; > > struct meson_pinctrl { > Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic