* [PATCH 2/6 v3] mmc: s3cmci: Fix platform_get_irq's error checking
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
@ 2017-11-19 4:52 ` Arvind Yadav
2017-12-15 9:17 ` Ulf Hansson
2017-11-19 4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Arvind Yadav @ 2017-11-19 4:52 UTC (permalink / raw)
To: linus-amlogic
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/s3cmci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index f7f157a..36daee1 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1658,7 +1658,7 @@ static int s3cmci_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq == 0) {
+ if (host->irq <= 0) {
dev_err(&pdev->dev, "failed to get interrupt resource.\n");
ret = -EINVAL;
goto probe_iounmap;
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 2/6 v3] mmc: s3cmci: Fix platform_get_irq's error checking
2017-11-19 4:52 ` [PATCH 2/6 v3] mmc: s3cmci: " Arvind Yadav
@ 2017-12-15 9:17 ` Ulf Hansson
0 siblings, 0 replies; 13+ messages in thread
From: Ulf Hansson @ 2017-12-15 9:17 UTC (permalink / raw)
To: linus-amlogic
On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/s3cmci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index f7f157a..36daee1 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -1658,7 +1658,7 @@ static int s3cmci_probe(struct platform_device *pdev)
> }
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq == 0) {
> + if (host->irq <= 0) {
> dev_err(&pdev->dev, "failed to get interrupt resource.\n");
> ret = -EINVAL;
> goto probe_iounmap;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-19 4:52 ` [PATCH 2/6 v3] mmc: s3cmci: " Arvind Yadav
@ 2017-11-19 4:52 ` Arvind Yadav
2017-11-22 12:02 ` Adrian Hunter
2017-12-15 9:17 ` Ulf Hansson
2017-11-19 4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
` (3 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-11-19 4:52 UTC (permalink / raw)
To: linus-amlogic
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sdhci-acpi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index b988997..0d9965b 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
host->hw_name = "ACPI";
host->ops = &sdhci_acpi_ops_dflt;
host->irq = platform_get_irq(pdev, 0);
+ if (host->irq <= 0) {
+ err = -EINVAL;
+ goto err_free;
+ }
host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
resource_size(iomem));
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq
2017-11-19 4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
@ 2017-11-22 12:02 ` Adrian Hunter
2017-12-15 9:17 ` Ulf Hansson
1 sibling, 0 replies; 13+ messages in thread
From: Adrian Hunter @ 2017-11-22 12:02 UTC (permalink / raw)
To: linus-amlogic
On 19/11/17 06:52, Arvind Yadav wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/sdhci-acpi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index b988997..0d9965b 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
> host->hw_name = "ACPI";
> host->ops = &sdhci_acpi_ops_dflt;
> host->irq = platform_get_irq(pdev, 0);
> + if (host->irq <= 0) {
> + err = -EINVAL;
> + goto err_free;
> + }
>
> host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
> resource_size(iomem));
>
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq
2017-11-19 4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-22 12:02 ` Adrian Hunter
@ 2017-12-15 9:17 ` Ulf Hansson
1 sibling, 0 replies; 13+ messages in thread
From: Ulf Hansson @ 2017-12-15 9:17 UTC (permalink / raw)
To: linus-amlogic
On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/sdhci-acpi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index b988997..0d9965b 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
> host->hw_name = "ACPI";
> host->ops = &sdhci_acpi_ops_dflt;
> host->irq = platform_get_irq(pdev, 0);
> + if (host->irq <= 0) {
> + err = -EINVAL;
> + goto err_free;
> + }
>
> host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
> resource_size(iomem));
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-19 4:52 ` [PATCH 2/6 v3] mmc: s3cmci: " Arvind Yadav
2017-11-19 4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
@ 2017-11-19 4:52 ` Arvind Yadav
2017-11-20 6:45 ` Viresh Kumar
2017-12-15 9:17 ` Ulf Hansson
2017-11-19 4:52 ` [PATCH 6/6 v3] mmc: sunxi-mmc: " Arvind Yadav
` (2 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-11-19 4:52 UTC (permalink / raw)
To: linus-amlogic
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sdhci-spear.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..e04485e 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = &sdhci_pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+ if (host->irq <= 0) {
+ ret = -EINVAL;
+ goto err_host;
+ }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
sdhci = sdhci_priv(host);
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq
2017-11-19 4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
@ 2017-11-20 6:45 ` Viresh Kumar
2017-12-15 9:17 ` Ulf Hansson
1 sibling, 0 replies; 13+ messages in thread
From: Viresh Kumar @ 2017-11-20 6:45 UTC (permalink / raw)
To: linus-amlogic
On 19-11-17, 10:22, Arvind Yadav wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/sdhci-spear.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index 8c0f884..e04485e 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
> host->hw_name = "sdhci";
> host->ops = &sdhci_pltfm_ops;
> host->irq = platform_get_irq(pdev, 0);
> + if (host->irq <= 0) {
> + ret = -EINVAL;
> + goto err_host;
> + }
> host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
>
> sdhci = sdhci_priv(host);
Hope this is the last one to Ack :)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq
2017-11-19 4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
2017-11-20 6:45 ` Viresh Kumar
@ 2017-12-15 9:17 ` Ulf Hansson
1 sibling, 0 replies; 13+ messages in thread
From: Ulf Hansson @ 2017-12-15 9:17 UTC (permalink / raw)
To: linus-amlogic
On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/sdhci-spear.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index 8c0f884..e04485e 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
> host->hw_name = "sdhci";
> host->ops = &sdhci_pltfm_ops;
> host->irq = platform_get_irq(pdev, 0);
> + if (host->irq <= 0) {
> + ret = -EINVAL;
> + goto err_host;
> + }
> host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
>
> sdhci = sdhci_priv(host);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
` (2 preceding siblings ...)
2017-11-19 4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
@ 2017-11-19 4:52 ` Arvind Yadav
2017-12-15 9:18 ` Ulf Hansson
2017-12-07 0:58 ` [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Kevin Hilman
2017-12-15 9:17 ` Ulf Hansson
5 siblings, 1 reply; 13+ messages in thread
From: Arvind Yadav @ 2017-11-19 4:52 UTC (permalink / raw)
To: linus-amlogic
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sunxi-mmc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index cc98355d..c926ac8 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
goto error_assert_reset;
host->irq = platform_get_irq(pdev, 0);
+ if (host->irq <= 0) {
+ ret = -EINVAL;
+ goto error_assert_reset;
+ }
+
return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq
2017-11-19 4:52 ` [PATCH 6/6 v3] mmc: sunxi-mmc: " Arvind Yadav
@ 2017-12-15 9:18 ` Ulf Hansson
0 siblings, 0 replies; 13+ messages in thread
From: Ulf Hansson @ 2017-12-15 9:18 UTC (permalink / raw)
To: linus-amlogic
On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of host->irq.
>
> drivers/mmc/host/sunxi-mmc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index cc98355d..c926ac8 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
> goto error_assert_reset;
>
> host->irq = platform_get_irq(pdev, 0);
> + if (host->irq <= 0) {
> + ret = -EINVAL;
> + goto error_assert_reset;
> + }
> +
> return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
> sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
` (3 preceding siblings ...)
2017-11-19 4:52 ` [PATCH 6/6 v3] mmc: sunxi-mmc: " Arvind Yadav
@ 2017-12-07 0:58 ` Kevin Hilman
2017-12-15 9:17 ` Ulf Hansson
5 siblings, 0 replies; 13+ messages in thread
From: Kevin Hilman @ 2017-12-07 0:58 UTC (permalink / raw)
To: linus-amlogic
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking
2017-11-19 4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
` (4 preceding siblings ...)
2017-12-07 0:58 ` [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Kevin Hilman
@ 2017-12-15 9:17 ` Ulf Hansson
5 siblings, 0 replies; 13+ messages in thread
From: Ulf Hansson @ 2017-12-15 9:17 UTC (permalink / raw)
To: linus-amlogic
On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes in v2 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
> return -EINVAL instead of irq.
>
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e0862d3..32a6a22 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1208,7 +1208,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (!irq) {
> + if (irq <= 0) {
> dev_err(&pdev->dev, "failed to get interrupt resource.\n");
> ret = -EINVAL;
> goto free_host;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread