From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: neil.armstrong@linaro.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: amlogic: a4: add power domain controller node
Date: Tue, 28 May 2024 17:00:11 +0800 [thread overview]
Message-ID: <70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com> (raw)
In-Reply-To: <c97b12bb-8b56-4129-a292-588226a0ec42@linaro.org>
Hi Neil,
Thanks for your quickly reply.
On 2024/5/28 16:46, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> On 28/05/2024 10:39, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Add power domain controller node for Amlogic A4 SoC
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 4 ++++
>> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 5 +++++
>> 2 files changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> index b6106ad4a072..eebde77ae5b4 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> @@ -27,6 +27,10 @@ xtal: xtal-clk {
>> #clock-cells = <0>;
>> };
>>
>> + sm: secure-monitor {
>> + compatible = "amlogic,meson-gxbb-sm";
>> + };
>> +
>> soc {
>> compatible = "simple-bus";
>> #address-cells = <2>;
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> index 73ca1d7eed81..917c05219b9c 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -37,4 +37,9 @@ cpu3: cpu@3 {
>> enable-method = "psci";
>> };
>> };
>> +
>> + pwrc: power-controller {
>> + compatible = "amlogic,a4-pwrc";
>> + #power-domain-cells = <1>;
>> + };
>
> pwrc is supposed to be a child of secure-monitor.
>
Considered writing it like this when I wrote this.
Here are two approaches: one is to include secure-monitor in the comm
dtsi and fill power-controller by aliases in dtsi of each chip, while
the other is to directly include secure-monitor in the dtsi of each
chip. Which one do you suggest?
> Neil
>
>> };
>>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-05-28 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 8:39 [PATCH 0/3] Power: A4: add power domain driver Xianwei Zhao via B4 Relay
2024-05-28 8:39 ` [PATCH 1/3] dt-bindings: power: add Amlogic A4 power domains Xianwei Zhao via B4 Relay
2024-05-28 9:01 ` Krzysztof Kozlowski
2024-05-28 8:39 ` [PATCH 2/3] pmdomain: amlogic: Add support for A4 power domains controller Xianwei Zhao via B4 Relay
2024-05-28 8:41 ` Neil Armstrong
2024-05-28 8:39 ` [PATCH 3/3] arm64: dts: amlogic: a4: add power domain controller node Xianwei Zhao via B4 Relay
2024-05-28 8:46 ` Neil Armstrong
2024-05-28 9:00 ` Xianwei Zhao [this message]
2024-05-28 9:08 ` neil.armstrong
2024-05-28 9:17 ` Xianwei Zhao
2024-06-06 9:21 ` [PATCH 0/3] Power: A4: add power domain driver Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).