From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Maxime Jourdan <mjourdan@baylibre.com>,
devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs
Date: Wed, 20 Mar 2019 09:49:31 +0100 [thread overview]
Message-ID: <703bf558-a0f7-e64b-bf0b-bb619c16d4c3@baylibre.com> (raw)
In-Reply-To: <20190213095835.17448-1-jbrunet@baylibre.com>
On 13/02/2019 10:58, Jerome Brunet wrote:
> Remove the bindings ID of the clock input of the controller. These
> clocks are purely internal to the controller, exposing them was a
> mistake. Actually, these should not even be in the provider and have
> IDs to begin with.
>
> Unexpose these IDs before:
> * someone starts using them (even if there no valid reason to do so)
> * the actual clocks are removed. The fact that they exist is just the
> result of an ugly hack. This will be resolved in CCF when we can
> reference DT directly in parent table.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/axg-audio.h | 20 ++++++++++++++++++++
> include/dt-bindings/clock/axg-audio-clkc.h | 20 --------------------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/clk/meson/axg-audio.h b/drivers/clk/meson/axg-audio.h
> index 7191b39c9d65..644f0b0fddf2 100644
> --- a/drivers/clk/meson/axg-audio.h
> +++ b/drivers/clk/meson/axg-audio.h
> @@ -60,6 +60,26 @@
> #define AUD_CLKID_MST5 6
> #define AUD_CLKID_MST6 7
> #define AUD_CLKID_MST7 8
> +#define AUD_CLKID_SLV_SCLK0 9
> +#define AUD_CLKID_SLV_SCLK1 10
> +#define AUD_CLKID_SLV_SCLK2 11
> +#define AUD_CLKID_SLV_SCLK3 12
> +#define AUD_CLKID_SLV_SCLK4 13
> +#define AUD_CLKID_SLV_SCLK5 14
> +#define AUD_CLKID_SLV_SCLK6 15
> +#define AUD_CLKID_SLV_SCLK7 16
> +#define AUD_CLKID_SLV_SCLK8 17
> +#define AUD_CLKID_SLV_SCLK9 18
> +#define AUD_CLKID_SLV_LRCLK0 19
> +#define AUD_CLKID_SLV_LRCLK1 20
> +#define AUD_CLKID_SLV_LRCLK2 21
> +#define AUD_CLKID_SLV_LRCLK3 22
> +#define AUD_CLKID_SLV_LRCLK4 23
> +#define AUD_CLKID_SLV_LRCLK5 24
> +#define AUD_CLKID_SLV_LRCLK6 25
> +#define AUD_CLKID_SLV_LRCLK7 26
> +#define AUD_CLKID_SLV_LRCLK8 27
> +#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_MST_A_MCLK_SEL 59
> #define AUD_CLKID_MST_B_MCLK_SEL 60
> #define AUD_CLKID_MST_C_MCLK_SEL 61
> diff --git a/include/dt-bindings/clock/axg-audio-clkc.h b/include/dt-bindings/clock/axg-audio-clkc.h
> index fd9c362099d9..eafb0de8466b 100644
> --- a/include/dt-bindings/clock/axg-audio-clkc.h
> +++ b/include/dt-bindings/clock/axg-audio-clkc.h
> @@ -7,26 +7,6 @@
> #ifndef __AXG_AUDIO_CLKC_BINDINGS_H
> #define __AXG_AUDIO_CLKC_BINDINGS_H
>
> -#define AUD_CLKID_SLV_SCLK0 9
> -#define AUD_CLKID_SLV_SCLK1 10
> -#define AUD_CLKID_SLV_SCLK2 11
> -#define AUD_CLKID_SLV_SCLK3 12
> -#define AUD_CLKID_SLV_SCLK4 13
> -#define AUD_CLKID_SLV_SCLK5 14
> -#define AUD_CLKID_SLV_SCLK6 15
> -#define AUD_CLKID_SLV_SCLK7 16
> -#define AUD_CLKID_SLV_SCLK8 17
> -#define AUD_CLKID_SLV_SCLK9 18
> -#define AUD_CLKID_SLV_LRCLK0 19
> -#define AUD_CLKID_SLV_LRCLK1 20
> -#define AUD_CLKID_SLV_LRCLK2 21
> -#define AUD_CLKID_SLV_LRCLK3 22
> -#define AUD_CLKID_SLV_LRCLK4 23
> -#define AUD_CLKID_SLV_LRCLK5 24
> -#define AUD_CLKID_SLV_LRCLK6 25
> -#define AUD_CLKID_SLV_LRCLK7 26
> -#define AUD_CLKID_SLV_LRCLK8 27
> -#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_DDR_ARB 29
> #define AUD_CLKID_PDM 30
> #define AUD_CLKID_TDMIN_A 31
>
Applied to next/drivers
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-03-20 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:58 [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs Jerome Brunet
2019-02-13 11:40 ` Maxime Jourdan
2019-02-28 18:27 ` Rob Herring
2019-03-20 8:49 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703bf558-a0f7-e64b-bf0b-bb619c16d4c3@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjourdan@baylibre.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).