From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E21C8C00140 for ; Fri, 5 Aug 2022 09:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q9VHlFJ4JZMTJ5Z5uQjZXrSRF8heG2K4949r0l7SOHY=; b=jTP6troQG/HhswKPOQcCTSszxk NLs7BmcD/NI2ORnrXA+zq1c4k5EvZCRtFnDirrgEKPM4E9zTfKhwlHho5nDMjLNP4xq/DSusGbBp7 ASYw/jiVVbkwSLO9bKg4GA3gHzok+qAVEtw4ZepBVu44Iun3K0yPOEyql4PHqQFEKReGkX2kqtY7B h9YcwqjhCX7g0Er5pvSU8Yn4XMjxgbPaudXMPSGjaYJU5u7FFhb2W8K/pcG+s7Qi2xP3LM5rI3Sxk 5s2NzP044R23usxQvetEf5oXuIRjbRSbx3G4viWDyoz6ZpBaqriuh50wlaADzVWW9rMyoYc9gY43J ZbLXS0bQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJtlK-00DfIz-8B; Fri, 05 Aug 2022 09:36:58 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJtl9-00DfDx-5F; Fri, 05 Aug 2022 09:36:48 +0000 Received: from [10.18.29.47] (10.18.29.47) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 5 Aug 2022 17:36:44 +0800 Message-ID: <759c681e-ec03-4230-b34e-0b2ee67ac870@amlogic.com> Date: Fri, 5 Aug 2022 17:36:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V3 5/6] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT Content-Language: en-US To: Krzysztof Kozlowski , , , , , , Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-6-yu.tu@amlogic.com> <60f30470-ca14-1e12-3ed2-7b34c7a93f8a@linaro.org> From: Yu Tu In-Reply-To: <60f30470-ca14-1e12-3ed2-7b34c7a93f8a@linaro.org> X-Originating-IP: [10.18.29.47] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220805_023647_253542_A9B5A461 X-CRM114-Status: UNSURE ( 9.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thank you for your reply. On 2022/8/5 17:16, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 05/08/2022 10:57, Yu Tu wrote: >> Added information about the S4 SOC Peripheral Clock controller in DT. >> >> Signed-off-by: Yu Tu >> --- >> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26 +++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> index a816b1f7694b..71be1dda15a2 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> @@ -6,6 +6,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> / { >> cpus { >> @@ -100,6 +102,30 @@ clkc_pll: pll-clock-controller@8000 { >> #clock-cells = <1>; >> }; >> >> + clkc_periphs: periphs-clock-controller { > > Node names should be generic, so "clock-controller" > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > You miss here unit address. Test your DTS with dtbs check and with > regular compile with W=1. I will change to clkc_periphs: clock-controller@0 {. Is that okay? > > > Best regards, > Krzysztof > > . _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic