Re: [PATCH RFC v2 05/11] ASoC: dt-bindings: amlogic: add schema for audin-formatter and audin-toddr

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/04/2026 16:57, Valerio Setti wrote:
> Add schema for "amlogic,meson-gx-audin-decoder-i2s" and
> "amlogic,meson-gx-audin-fifo" modules which are used to
> provide I2S audio input support to the Meson GX platform.
> 
> Signed-off-by: Valerio Setti <vsetti@baylibre.com>
> ---
>  .../sound/amlogic,meson-gx-audin-decoder-i2s.yaml  | 49 +++++++++++++++++
>  .../sound/amlogic,meson-gx-audin-fifo.yaml         | 63 ++++++++++++++++++++++
>  2 files changed, 112 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-decoder-i2s.yaml b/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-decoder-i2s.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..eaf57603e1ecf5944ffdcf7a1b6146d1a0295696
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-decoder-i2s.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/amlogic,meson-gx-audin-decoder-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic GX AUDIN I2S Input Decoder
> +
> +maintainers:
> +  - Valerio Setti <vsetti@baylibre.com>
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  $nodename:
> +    pattern: "^audio-controller@.*"

Drop

> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +  compatible:
> +    items:
> +      - enum:
> +          - amlogic,meson-gxbb-audin-decoder-i2s
> +      - const: amlogic,meson-gx-audin-decoder-i2s

Compatible is always the first property.

> +
> +  reg:
> +    maxItems: 1

Reg follows. Please look at DTS coding style or other bindings.

> +
> +  sound-name-prefix: true

Drop

> +
> +required:
> +  - "#sound-dai-cells"
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

unevaluatedProperties

> +
> +examples:
> +  - |
> +    audio-controller@a040 {
> +      compatible = "amlogic,meson-gxbb-audin-decoder-i2s",
> +                   "amlogic,meson-gx-audin-decoder-i2s";
> +      #sound-dai-cells = <0>;
> +      sound-name-prefix = "AUDIN I2S Decoder";
> +      reg = <0xa040 0x4>;

One register-wide block? I have doubts this is a separate device

> +      status = "disabled";

Drop, examples must not be disabled.


Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic