From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F09C3DA6D for ; Fri, 23 May 2025 10:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g0Em5apyJt8psZjFl5FQz6GbiUHCaiRW2qzMEZZpAd8=; b=Kf0LySReRNEp5v UoFfb6A0oRPgz4M6FaTgUQIYb9hgqfnoVemts+ejRb9hInodYKVrMm3JszoA4BDhyFqFPrso+GxSc gFatif7FzwZARqxQKDkSUpdTFF3I74KF7M84kXwHP3WTrmz30NbwnXuFk4aqYLs9MPlEsQgwXHSUe wx/uf+TujvUz4K5qjF3lb3/FaJncId1iZ03g1bMaZBzfhfmMJNPUkkTXJxGtphJmqUkjrh3MF+3AX gCNdNk2WUHVJGv6WJ2I7gOzKP9/ZL6TRED2r0T1syOs/rEr/4xjcbZcGhWDKnMAkhQ6DUv7x/tFNl bVbUW/hE0xsz3FSMDerg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIPrV-00000003cjQ-0G15; Fri, 23 May 2025 10:42:49 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIPpK-00000003cWq-2OcI; Fri, 23 May 2025 10:40:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=K2JQO+uYU43rONsrKzctsDigqQZ79oxfKv9WnQ4M8rs=; t=1747996831; x=1749206431; b=hZ7dZRInJ/Ma+5SrzqJlypknwP1EN0GbvkfKWYqdFNMwGov guj66rx83b2i/Gt78g869SwRDEEqsZhotv0huSnTMZ/pt9NuMMb8GzXbDnplODz9+3viG6KScQN4D SFLCkJqpMdK6wz8Xv80G/9sXBgGu00waf88Bw9fl0p2bFWXK8u0EDuqeuKWu4HXiGr1vJLMhlmJ2/ s6IzlQpzW1vmHoaE1cp83uszya6t2gSxKuNsEpvl/2c/aNJFze9Am34yD8YK//aehhHmRkHnEWAXR nFz70S1ctrlh2kkcVgBlMA8rrnfhVm/Tk5gasyAAsDP0m6Y1/mGhOoZ8e/Jv8V8Q==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1uIPp5-00000001O1N-1Ky4; Fri, 23 May 2025 12:40:19 +0200 Message-ID: <7e708dcc98c6f0f615b1b87d190464cfe78be668.camel@sipsolutions.net> Subject: Re: [PATCH v2 2/6] ASoC: aoa: Use helper function for_each_child_of_node_scoped() From: Johannes Berg To: =?UTF-8?Q?=E8=89=BE=E8=B6=85?= , perex , tiwai , "kuninori.morimoto.gx" , lgirdwood , broonie , jbrunet , "neil.armstrong" , khilman , "martin.blumenstingl" , "shengjiu.wang" , "Xiubo.Lee" , festevam , nicoleotsuka , shawnguo , "s.hauer" , "srinivas.kandagatla" Cc: linux-sound , linux-kernel , linuxppc-dev , linux-renesas-soc , linux-arm-kernel , linux-amlogic , imx , kernel , linux-arm-msm Date: Fri, 23 May 2025 12:40:18 +0200 In-Reply-To: <2aq0nyvyf7t-2aq4hsc7kp6@nsmail7.0.0--kylin--1> References: <2aq0nyvyf7t-2aq4hsc7kp6@nsmail7.0.0--kylin--1> User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_034034_607669_25B78958 X-CRM114-Status: UNSURE ( 4.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, [you should avoid HTML] > "simplifies the code" is no need to callof_node_put() . Fair. Except that's not what you _actually_ changed here. Like I said, either it's buggy before or after. johannes _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic