From: Kevin Hilman <khilman@baylibre.com>
To: Jianxin Pan <jianxin.pan@amlogic.com>
Cc: , Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller
Date: Thu, 17 Jan 2019 11:29:54 -0800 [thread overview]
Message-ID: <7hbm4fccb1.fsf@baylibre.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1901161112090.1655@nanos.tec.linutronix.de>
[ + Jianxin since Yixun is no longer at Amlogic ]
Thomas Gleixner <tglx@linutronix.de> writes:
> On Mon, 12 Nov 2018, Thomas Gleixner wrote:
>
> Gentle ping.
>
>> Yixun,
>>
>> On Fri, 10 Nov 2017, Yixun Lan wrote:
>>
>> > +/*
>> > + *
>> > + * Copyright (c) 2016 BayLibre, SAS.
>> > + * Author: Neil Armstrong <narmstrong@baylibre.com>
>> > + *
>> > + * Copyright (c) 2017 Amlogic, inc.
>> > + * Author: Yixun Lan <yixun.lan@amlogic.com>
>> > + *
>> > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD)
>>
>> There are two things wrong:
>>
>> 1) The placement. See Documentation/process/license-rules.rst
>>
>> 2) BSD is not a valid license id. You really have to decide which BSD
>> variant to use.
>>
>> Please get that fixed as especially #2 is broken. The goal of using SPDX is
>> to provide reliable license information for compliance tools.
>
> This still is broken:
>
> # scripts/spdxcheck.py include/dt-bindings/
> include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD
Jianxin, can you fix this and clarify which BSD license was intended by
Amlogic?
If this isn't fixed soon, I will cleanup and remove the BSD part and
Amlogic can clarify with a subsequent patch.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-17 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 8:46 [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller Yixun Lan
2017-11-10 8:46 ` [PATCH 2/3] reset: meson-axg: add compatible string for Meson-AXG SoC Yixun Lan
2017-11-17 13:08 ` Neil Armstrong
2017-12-13 14:07 ` Yixun Lan
2017-12-13 16:01 ` Philipp Zabel
2017-12-14 3:14 ` Yixun Lan
2017-11-17 13:08 ` [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller Neil Armstrong
2018-11-12 19:20 ` Thomas Gleixner
2019-01-16 10:14 ` Thomas Gleixner
2019-01-17 19:29 ` Kevin Hilman [this message]
2019-01-17 19:31 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hbm4fccb1.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox