Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID

Neil Armstrong
2020-10-20T16:11:26Z

On 20/10/2020 16:49, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> On 20/10/2020 14:01, Jerome Brunet wrote:
>>> From: Anand Moon <linux.amoon@gmail.com>
>>>
>>> Add reset external reset of the ethernet mac controller
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> [...]
>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Neil, do we need this in u-boot also? I seem to have network issues in
> u-boot on board with external PHY running mainline u-boot.

Yes, U-boot supports it, but simply does "reset_deassert", so I don't think
it would have any impact, the real issue is the PHY reset.

Without a proper reset line, no idea how to do that cleanly.

Neil

>
> Kevin