* [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value
[not found] <20201210091756.18057-1-Sergey.Semin@baikalelectronics.ru>
@ 2020-12-10 9:17 ` Serge Semin
2020-12-11 19:06 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Serge Semin @ 2020-12-10 9:17 UTC (permalink / raw)
To: Felipe Balbi, Krzysztof Kozlowski, Florian Fainelli, Rob Herring,
Greg Kroah-Hartman, Kevin Hilman, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl
Cc: devicetree, linux-usb, linux-kernel, Serge Semin, Serge Semin,
linux-amlogic, linux-arm-kernel
In accordance with the DWC USB3 bindings the property is supposed to have
uint32 type. It's erroneous from the DT schema and driver points of view
to declare it as boolean. As Neil suggested set it to 0x20 so not break
the platform and to make the dtbs checker happy.
Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 8514fe6a275a..a6127002573b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -2384,7 +2384,7 @@ dwc3: usb@ff500000 {
interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
dr_mode = "host";
snps,dis_u2_susphy_quirk;
- snps,quirk-frame-length-adjustment;
+ snps,quirk-frame-length-adjustment = <0x20>;
snps,parkmode-disable-ss-quirk;
};
};
--
2.29.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value
2020-12-10 9:17 ` [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
@ 2020-12-11 19:06 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2020-12-11 19:06 UTC (permalink / raw)
To: Serge Semin, Felipe Balbi, Krzysztof Kozlowski, Florian Fainelli,
Rob Herring, Greg Kroah-Hartman, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl
Cc: devicetree, linux-usb, linux-kernel, Serge Semin, Serge Semin,
linux-amlogic, linux-arm-kernel
Serge Semin <Sergey.Semin@baikalelectronics.ru> writes:
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
>
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Queuing for fixes after adding:
Fixes: 9baf7d6be730 ("arm64: dts: meson: g12a: Add G12A USB nodes")
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-11 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201210091756.18057-1-Sergey.Semin@baikalelectronics.ru>
2020-12-10 9:17 ` [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
2020-12-11 19:06 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).