From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CB4C43387 for ; Thu, 17 Jan 2019 21:15:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3183620855 for ; Thu, 17 Jan 2019 21:15:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JePABHCf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="SWzUPuuJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3183620855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eJXPrvvst/7kL/Ma0QprM0Ksn+GF+5R5PWCzZ7nsk+A=; b=JePABHCfNTvq7r ystNuduO+csFFLjEgIrJU7Vwbzfrewa6dqzCmvA9td0HlrkFyW6LgKPLbuFi4q6DXLFjb2Rejg9r9 MjK0BWYQ5aUI8geiY9MYW5V4PcbE77fU06Nn6OPljg/ca5G6J69uLb6YcB5I2kpfJk7FgoqM6N0ua JVISF684Z4vHIHupC3TShKNaRJsr1BCiFko07es+u5xr2shzPyISKUPeVQjc7TvWCXtPNWLQ488yG nhYZKldRLE3KNNoUaJ0NA4yorcPWuptIx0TTx3uLVBf3jhOhCQ9ytGmMMM+nHvM6dyAsF7QRS5stH 42ArPFq1xoJrNC4ilpxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkF08-0003pQ-61; Thu, 17 Jan 2019 21:15:00 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkEzs-0003dM-5p for linux-amlogic@lists.infradead.org; Thu, 17 Jan 2019 21:14:47 +0000 Received: by mail-pl1-x644.google.com with SMTP id 101so5298534pld.6 for ; Thu, 17 Jan 2019 13:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YCDg3/5yEtTopD+BNlUnVHLNXenmfq39AHu1q2YrYY4=; b=SWzUPuuJmrVIzmZwKxfGJwNzqxD8oUPbomcGp+U1sqRFAYBaIUwl355LRTCRa5uh4N 3aWK3P1xOVmqcNx3zhVaIP8XQN2gFcbwpmIQRCPuPCbnXqQeF0OYZesA0mktT5RvgqQz Pf6oC18fb/lGA2Lvcq399bIogVcfJLrGZm+oDgWO8F2cpquJYcQgpOxLR0hbikzVSEtF zAXiAVGfFvurB1P8QFAicZVxu3R5UDFTTprvVZG0YhGW6ZqGEd64DFVrPhhw5JL35zYc lKK/ISA1uEvn67sHiEeL0CBemzIIo4Y21rHQBmk3QZJwM7ChhedgUKfrH1UOUpUrbf+C tsng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YCDg3/5yEtTopD+BNlUnVHLNXenmfq39AHu1q2YrYY4=; b=UnfFZBcI3n3ip+nyoCBGz5YnLU55S5fOQ3wz3//s3IhAL18vSz9latQYDnBY8Bmbtm GKvKoF6snqaFFJjsRl8FG0dEYE4JbfAQxrF2TtIlRpCL+Z/IWrCIjJ+6iHA82Qpgetf5 wYMspo5/KDIiTaMupPqqrJF022qATLxl4lP+rKxgRtOEqFoGwUNN6kjW80HC5kV7Fq7c mpiaktYn9ZGgDH5oRsBRnueESk+pOENqiAO1lws1oplfc2dVlZ7vZ173w7yRWsL+JSBM LEcCHo81q8K8aMINPmF/zN48myMJqNfmNJGTgp2+7oSWqK9O0ji8IyWaYDtN5gjlwPEo Verw== X-Gm-Message-State: AJcUukeguZ06EDfPgCyoyhQyrFQ98vxXku7nn1aERO2Na8YgQzmADcdS Z7ELhp5ynKuZkuBGr/JBtE7mQA== X-Google-Smtp-Source: ALg8bN4VwKGwv6Qdvh6tBtKiOmQDz0J4GpLSiPd2S2G1bAk362s5l4eTrorDInZEXh6nSGvVJJTWzg== X-Received: by 2002:a17:902:9a47:: with SMTP id x7mr16433596plv.126.1547759683228; Thu, 17 Jan 2019 13:14:43 -0800 (PST) Received: from localhost ([2601:602:9200:a1a5:e076:9fe9:59e2:1e0b]) by smtp.googlemail.com with ESMTPSA id a195sm5769529pfa.7.2019.01.17.13.14.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 13:14:42 -0800 (PST) From: Kevin Hilman To: Anand Moon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning In-Reply-To: <20190113153022.5040-1-linux.amoon@gmail.com> References: <20190113153022.5040-1-linux.amoon@gmail.com> Date: Thu, 17 Jan 2019 13:14:41 -0800 Message-ID: <7hy37j9ebi.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_131444_237819_BFAB1C7D X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Blumenstingl , Neil Armstrong , Rob Herring , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Anand, Anand Moon writes: > Override the dr_mode from "host" to "peripheral" for dwc2 > usb_phy0->usb0 initilization of OTG Micro-B type. > Changes fix the below warning for phy poweron failed --> -22 > > Changes fix the initialization of c9000000.usb phy > > [ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed! > [ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22 > [ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 > [ 1.222953] Modules linked in: > [ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3 > [ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT) > [ 1.237794] Workqueue: events deferred_probe_work_func > [ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO) > [ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8 > [ 1.252280] lr : regulator_put+0x34/0x48 > [ 1.256159] sp : ffff00001176bb00 > [ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000 > [ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0 > [ 1.269959] x25: 0000000000000000 x24: 0000000000000009 > [ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500 > [ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700 > [ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f > [ 1.291004] x17: 0000000000000000 x16: 0000000000000000 > [ 1.296265] x15: 0000000000000400 x14: 0000000000000400 > [ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff > [ 1.306788] x11: 0000000000000038 x10: 0000000000000040 > [ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8 > [ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00 > [ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00 > [ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00 > [ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001 > [ 1.338356] Call trace: > [ 1.340773] _regulator_put.part.11+0xf0/0xf8 > [ 1.345085] regulator_put+0x34/0x48 > [ 1.348621] regulator_bulk_free+0x30/0x50 > [ 1.352675] devm_regulator_bulk_release+0x18/0x20 > [ 1.357421] release_nodes+0x1b0/0x220 > [ 1.361127] devres_release_all+0x34/0x50 > [ 1.365094] really_probe+0xec/0x290 > [ 1.368630] driver_probe_device+0x54/0xe8 > [ 1.372684] __device_attach_driver+0xb8/0xe8 > [ 1.376997] bus_for_each_drv+0x78/0xc8 > [ 1.380792] __device_attach+0xd4/0x130 > [ 1.384587] device_initial_probe+0x10/0x18 > [ 1.388727] bus_probe_device+0x90/0x98 > [ 1.392522] deferred_probe_work_func+0x6c/0xa0 > [ 1.397010] process_one_work+0x1e0/0x318 > [ 1.400975] worker_thread+0x228/0x428 > [ 1.404684] kthread+0x124/0x128 > [ 1.407876] ret_from_fork+0x10/0x18 > [ 1.411410] ---[ end trace de5fd1b262c1f56a ]--- > [ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 > [ 1.425123] Modules linked in: > [ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3 > [ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT) > [ 1.441340] Workqueue: events deferred_probe_work_func > > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) Minor nit: the shortlog should be in double quotes. I fixed it up manually, so nothing you need to do, but just for future reference. This was found by some automated checking recently added to the linux-next tree. Kevin > Tested-by: Kevin Hilman > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Cc: Neil Armstrong > Signed-off-by: Anand Moon > --- > Rebased on Kevin's amlogic/v5.0/fixes branch > Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/ > - Split the patch into two part > - Fix the commit message > - Added Tested by Kevin Hilman > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 1cc9dc68ef00..25a36d117183 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -302,6 +302,7 @@ > > &usb0 { > status = "okay"; > + dr_mode = "peripheral"; > }; > > &usb1 { > -- > 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic