From: Arseniy Krasnov <avkrasnov@sberdevices.ru>
To: Rob Herring <robh@kernel.org>
Cc: Liang Yang <liang.yang@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 2/3] dt-bindings: nand: meson: make ECC properties dependent
Date: Fri, 14 Jul 2023 22:22:53 +0300 [thread overview]
Message-ID: <840a9364-352d-b79b-6e7a-c54912e2297a@sberdevices.ru> (raw)
In-Reply-To: <20230714155553.GA3913802-robh@kernel.org>
On 14.07.2023 18:55, Rob Herring wrote:
> On Tue, Jul 11, 2023 at 03:21:28PM +0300, Arseniy Krasnov wrote:
>> ECC properties 'nand-ecc-strength' and 'nand-ecc-step-size' depends on
>> each other, so they must be both either set or not set.
>
> Is that true for all drivers or just meson?
As Miquel Raynal suggested, this will be implemented only for Meson driver at this moment.
Here is link with reply:
https://lore.kernel.org/linux-mtd/20230705065434.297040-1-AVKrasnov@sberdevices.ru/T/#m88705a0039fb30c18a9bb2b03a1add5f7e212a3b
Thanks, Arseniy
>
>> In first case
>> ECC core will try to use these values if possible (by checking ECC caps
>> provided by driver), in second case ECC core will select most optimal
>> values for both properties.
>>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>> ---
>> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> index e81757c9e0ed..4f6e56542a7e 100644
>> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> @@ -58,6 +58,10 @@ patternProperties:
>> meson-gxl-nfc 8, 16, 24, 30, 40, 50, 60
>> meson-axg-nfc 8
>>
>> + dependencies:
>> + nand-ecc-strength: ['nand-ecc-step-size']
>> + nand-ecc-step-size: ['nand-ecc-strength']
>> +
>> required:
>> - compatible
>> - reg
>> --
>> 2.35.0
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-07-14 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 12:21 [RFC PATCH v3 0/3] support 512B ECC step size for Meson NAND Arseniy Krasnov
2023-07-11 12:21 ` [RFC PATCH v3 1/3] dt-bindings: nand: meson: support for 512B ECC step size Arseniy Krasnov
2023-07-15 16:19 ` Miquel Raynal
2023-07-11 12:21 ` [RFC PATCH v3 2/3] dt-bindings: nand: meson: make ECC properties dependent Arseniy Krasnov
2023-07-14 15:55 ` Rob Herring
2023-07-14 19:22 ` Arseniy Krasnov [this message]
2023-07-14 20:44 ` Rob Herring
2023-07-11 12:21 ` [RFC PATCH v3 3/3] mtd: rawnand: meson: support for 512B ECC step size Arseniy Krasnov
2023-07-15 16:15 ` [RFC PATCH v3 0/3] support 512B ECC step size for Meson NAND Miquel Raynal
2023-07-15 17:48 ` Arseniy Krasnov
2023-07-16 13:24 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=840a9364-352d-b79b-6e7a-c54912e2297a@sberdevices.ru \
--to=avkrasnov@sberdevices.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox