From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01F29C6FD1F for ; Sun, 19 Mar 2023 16:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xcVJ2pN3d3OWtMawfyNbAdpEyHsfGEUBgkyvCO0yYY8=; b=bwTxw9SMlimMHl xLW88RLhrT5JRHRvlLam8rVgZeR85M54ptZHm5LonYloLecAkxrd7fLVAa14lgnK4gQFvDPIFhVYd 6SrY8fYY6vCITvQTDrucebNOaGLavHai9h5dtUrxHqm4DIwWBj4ZHxNOe6x56rAbOrAqYMoI/0++X H4aUrN9m9bAuouyc6nXfshS+gpympgJnLDblzapLGUcgoJEBie9K+67k6EF5KaMtWWh3MDvb7Lz+9 b7/U4Q3s7NY8vjOb7cpUb7E3nbBzlqd3W8VaYQ85vwu3IBv6NJxDTbPkDd8YHpvm6e1oUTA5j7ab1 LosCI00A+JyOWg3NR74g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdvUt-006zCI-1w; Sun, 19 Mar 2023 16:03:03 +0000 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcjy2-00FsoL-0Y; Thu, 16 Mar 2023 09:32:15 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E58EF21852; Thu, 16 Mar 2023 09:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678959130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=H9aXq6XWzgXy3V6gUMaMgKEQOC4u2wwCwuM31XT6epw3vcSavDTpG7v1DmpLitT3aAzvrb Uij7YtTtCMzKsnoVFyM4P36fE8radT/BVqUmJO5oz33vf5WRPcRwuHN+AiCd+tOxzXuyQp 7HO6F55yqLXCARRi8VELwLEQafIfemA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678959130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=vrFmJJMHnJyGAG4vQo3kBbAm10wkR+7Kjjsf57BxURiziFHRuM5x12k5OToJ7bvAHK8XWM BGwhhqI50dx0VBCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE806133E0; Thu, 16 Mar 2023 09:32:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9o+MNRjiEmRkRAAAMHmgww (envelope-from ); Thu, 16 Mar 2023 09:32:08 +0000 Date: Thu, 16 Mar 2023 10:32:08 +0100 Message-ID: <87ttylhwiv.wl-tiwai@suse.de> From: Takashi Iwai To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , V sujith kumar Reddy , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Gaosheng Cui , Thierry Reding , Jonathan Hunter , Mohan Kumar , Geoff Levand , Takashi Sakamoto , Michael Ellerman , Charles Keepax , Vijendar Mukunda , syed saba kareem , Mario Limonciello , Meng Tang , Martin =?ISO-8859-2?Q?Povi=B9er?= , Codrin Ciubotariu , Peter Rosin , Ray Jui , Scott Branden , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Alexander Sverdlin , Kuninori Morimoto , Richard Fitzgerald , James Schulman , David Rhodes , Lucas Tanure , Srinivas Kandagatla , Banajit Goswami , Miaoqian Lin , Colin Ian King , Aidan MacDonald , Zhang Qilong , Marek Szyprowski , Liang He , Shengjiu Wang , Xiubo Li , Shawn Guo , Sascha Hauer , Yang Yingliang , Minghao Chi , Kai Vehmanen , Bard Liao , Pierre-Louis Bossart , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Akihiko Odaki , Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= , Andy Shevchenko , Hans de Goede , Moises Cardona , Zhen Ni , Mauro Carvalho Chehab , Andrey Turkin , Muralidhar Reddy , Zhu Ning , Gongjun Song , Shuming Fan , Yong Zhi , Lior Amsalem , Andrew Lunn , Hezi Shahmoon , Neta Zur Hershkovits , Marcin Wojtas , Matthias Brugger , Jiasheng Jiang , Ricardo Ribalda , Trevor Wu , Dan Carpenter , Jerome Brunet , Neil Armstrong , Kevin Hilman , Heiko Stuebner , Nicolas Frattaroli , Krzysztof Kozlowski , Sylwester Nawrocki , Linh Phung , Shang XiaoJing , Lad Prabhakar , Biju Das , Orson Zhai , Baolin Wang , Chunyan Zhang , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Mikhail Rudenko , Li Chen , Ban Tao , Sameer Pujar , YueHaibing , Jiapeng Chong , Li kunyu , Peter Ujfalusi , Jarkko Nikula , Kunihiko Hayashi , Masami Hiramatsu , Christophe JAILLET , Arnd Bergmann , Linus Walleij , Michal Simek , Max Filippov , alsa-devel@alsa-project.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, asahi@lists.linux.dev, Broadcom internal kernel review list , patches@opensource.cirrus.com, Fabio Estevam , Nicolin Chen , NXP Linux Team , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_023214_381539_DEEAB321 X-CRM114-Status: GOOD ( 20.80 ) X-Mailman-Approved-At: Sun, 19 Mar 2023 09:02:31 -0700 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, 15 Mar 2023 16:04:52 +0100, Uwe Kleine-K=F6nig wrote: > = > Hello, > = > this series adapts the platform drivers below sound/ to use the .remove_n= ew() > callback. Compared to the traditional .remove() callback .remove_new() re= turns > no value. This is a good thing because the driver core doesn't (and canno= t) > cope for errors during remove. The only effect of a non-zero return value= in > .remove() is that the driver core emits a warning. The device is removed = anyhow > and an early return from .remove() usually yields a resource leak. > = > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > = > The first two patches simplify a driver each to return zero unconditional= ly, > and then all drivers are trivially converted to .remove_new(). > = > There are nearly no interdependencies in this patch set---only 1 <- 11 and > 2 <- 16. So even if some individual problems are found (I don't expect th= at), > the other patches can (and from my POV should) still be applied. > = > Best regards > Uwe > = > Uwe Kleine-K=F6nig (173): (snip) For the whole series, Acked-by: Takashi Iwai thanks, Takashi _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic