Linux-Amlogic Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
	Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Kalle Valo <kvalo@kernel.org>, Eric Dumazet <edumazet@google.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
	Alexander Prutskov <alep@cypress.com>,
	Wright Feng <wright.feng@cypress.com>,
	Joseph chuang <jiac@cypress.com>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Angus Ainslie <angus@akkea.ca>
Cc: linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-amlogic@lists.infradead.org
Subject: Re: Unsupported WiFi adapter on S905X2 board
Date: Mon, 6 Mar 2023 10:17:22 +0100	[thread overview]
Message-ID: <895a3812-e490-cc40-0f8e-a88e166e8f24@linaro.org> (raw)
In-Reply-To: <05977cbb-8a8f-0a67-b4bd-b265dbb83280@free.fr>

Hi Mark,

On 03/03/2023 19:19, Marc Gonzalez wrote:
> Hello,
> 
> I think there's an unsupported device in this system:
> 
> # cat /sys/bus/sdio/devices/mmc2:0001:1/uevent
> OF_NAME=wifi
> OF_FULLNAME=/soc/sd@ffe03000/wifi@1
> OF_COMPATIBLE_0=brcm,bcm4329-fmac
> OF_COMPATIBLE_N=1
> SDIO_CLASS=00
> SDIO_ID=02D0:AAE7
> SDIO_REVISION=0.0
> MODALIAS=sdio:c00v02D0dAAE7
> 
> 0xaae7 = 43751
> 
> Isn't there some overlap between
> include/linux/mmc/sdio_ids.h
> and
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> ?
> 
> (Relevant commit: d2587c57ffd8dc)
> 
> Looking at all the occurrences of 43752 to insert a 43751,
> could someone comment whether this looks reasonable?
> 

<snip>


I think you should send this as a patch as RFC to trigger a review.

Neil


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2023-03-06  9:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 18:19 Unsupported WiFi adapter on S905X2 board Marc Gonzalez
2023-03-06  9:17 ` Neil Armstrong [this message]
2023-03-06 10:24   ` [RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization Marc Gonzalez
2023-03-06 10:41     ` Marc Gonzalez
2023-03-07 14:40       ` Marc Gonzalez
2023-03-07 23:15         ` Franky Lin
2023-03-08 12:47           ` Marc Gonzalez
2023-03-08 17:21             ` Franky Lin
2023-03-08 17:37               ` Neil Armstrong
2023-03-22 17:40               ` Marc Gonzalez
2023-04-04 15:59                 ` Marc Gonzalez
2023-03-09 10:16     ` Marc Gonzalez
2023-03-09 12:13       ` Marc Gonzalez
2023-03-09 14:29         ` Ulf Hansson
2023-03-09 16:45           ` Marc Gonzalez
2023-03-09 17:51           ` Marc Gonzalez
2023-03-13 13:55             ` Marc Gonzalez
2023-03-13 14:41               ` Marc Gonzalez
2023-03-13 14:53                 ` Marc Gonzalez
2023-03-13 17:09               ` Marc Gonzalez
2023-03-13 20:04                 ` Martin Blumenstingl
2023-03-13 21:42                   ` Marc Gonzalez
2023-03-14  7:27                     ` Ulf Hansson
     [not found]                       ` <c7e48c6f-530b-7198-b8bb-fc927a2fdc66@free.fr>
2023-03-14 11:08                         ` Ulf Hansson
2023-03-14 16:37                           ` Marc Gonzalez
2023-03-15 20:55                             ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895a3812-e490-cc40-0f8e-a88e166e8f24@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=alep@cypress.com \
    --cc=angus@akkea.ca \
    --cc=aspriel@gmail.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=edumazet@google.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=jbrunet@baylibre.com \
    --cc=jiac@cypress.com \
    --cc=khilman@baylibre.com \
    --cc=kvalo@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=pieter-paul.giesberts@broadcom.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox