From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7520C61D97 for ; Wed, 22 Nov 2023 15:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6tv9N3NZNvwbpO9S7uQ4lE28epZ83clNb1QCZCKdaTw=; b=uyZTzhsmWcVSxF KExSgHycz3ELybxv1fmyb01TZivtQqWOO+4dcTnkBpmYc8wjtdCpzAyqehbDb0SjCKL6FpcK5gF99 /Nlb7Hcg8JGzgdTfsMGTlk0J4deuUAz/5pfnRWE7tHw8fzCqFqPo/o/g7LJ5Lew1zO29WLg1lUGDl qMNGMZ9v8fVQStHdzurcR0VLyYOvYJmmGNOqvvN0nKF4bM+/vuhOi3/bZbNbrHCCFyAN7rrUdrmle tm301m3TIiZxxtTzEKQrR65ZRquW9JS7oH9CkwS1b5ICVBi4SaCBAzLvRSqRUeLk1vqZXuJOjONr7 f5FbTHQCU8Nq73ysziWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5orl-002CoV-15; Wed, 22 Nov 2023 15:10:13 +0000 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5orh-002Cmq-38 for linux-amlogic@lists.infradead.org; Wed, 22 Nov 2023 15:10:11 +0000 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-778927f2dd3so347495885a.2 for ; Wed, 22 Nov 2023 07:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700665807; x=1701270607; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8tg8v0wjgB6LXPnF0igxmM4a2qP5aiK535KGZNUnjRw=; b=Tm6+Rt9BfjpaR1Dv6T7f3zR2kQxl1SbgCZQ6lLWpJB5Fw+LunsImlDcP5dXVV/T5UK ha2HVjzyi4v7CVWzeKr+ZA+2QfWP+Gf/JfayI3SvAEWvnJ7rd6ePd5pHu1ZgmVbzm6ts 2caL91Cp6jCoP5P3wbSg31PQnM9mawE4NzTD//RO8WbJp3dL+F4cqAK10QvRjWI9bJXl eXZUwdvYoyWZ+Nj8RyvXz20ZzFd94KeJSIsx8mkocWZRuNxlXWjiT8/BnHHogpl8ONhp CS4XE67H5RBLOlP5EBkQRn/bUUu++YwRbygCeXFnPafusjtx+Nyfmo86/t3glyuvBBl9 QgQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700665807; x=1701270607; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tg8v0wjgB6LXPnF0igxmM4a2qP5aiK535KGZNUnjRw=; b=ooLKw7BJN78OehMqxyjz1deTedlqDLgHt3yNJlFjjSH0GHhymjkqE+e691KhOJ5HkK W2T4al+WVm8+cSj6cmbJFXr0x7bYrB0o21ae12l8sKRmSetlaFpAOVq7JB95WFvBU7fL 9iSJyMVpl8eiaWpx9oZt6/Q9GAroXwV18cBSO9mQXsSE0dHv5/WEn8/yQ08Cv7EsntqV DndH4syIitiIiv71JuRMxSgGAYAzjhdsmzvRjMkoIybnjT0vZ2XM+gEhM8mBY+BJkkwL /RNE/Dgtj6nQeaBu8e8bG55lxp2Qzs2p6rMiv2Z+0zRXfqOi3c1Q3Rqq/uv3Lk0UTEm0 ig8w== X-Gm-Message-State: AOJu0Yz7EkUI4AMze4lSg7j6BStbyVUXKUuGoq9UEdjEIi6usYgeNpPk VxgC388MtnNT1ri1dIVCGX/+bg== X-Google-Smtp-Source: AGHT+IEuFT6h2b6jLXcvAMUG78/b/s/0PQ98pgAIrmfCulB9BuSVvha7x2D+Hk3/bEppyd5PyhrAEw== X-Received: by 2002:a05:620a:4482:b0:775:985e:f5c2 with SMTP id x2-20020a05620a448200b00775985ef5c2mr2681917qkp.17.1700665807502; Wed, 22 Nov 2023 07:10:07 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id b3-20020ac86783000000b004196a813639sm4480285qtp.17.2023.11.22.07.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 07:10:07 -0800 (PST) Message-ID: <8a3a44b4-adef-4872-b08e-fbde3f563858@linaro.org> Date: Wed, 22 Nov 2023 16:10:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] arm: dts: amlogic: migrate pwms to new meson8 v2 binding Content-Language: en-US To: Jerome Brunet Cc: Thierry Reding , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao References: <20231117125919.1696980-1-jbrunet@baylibre.com> <20231117125919.1696980-6-jbrunet@baylibre.com> <1jsf4xeskb.fsf@starbuckisacylon.baylibre.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <1jsf4xeskb.fsf@starbuckisacylon.baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_071010_020189_72F7C7D7 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 22/11/2023 15:52, Jerome Brunet wrote: > > On Wed 22 Nov 2023 at 09:39, Krzysztof Kozlowski wrote: > >> On 17/11/2023 13:59, Jerome Brunet wrote: >>> Update Amlogic based SoC PWMs to meson8-pwm-v2 compatible >> >> Why? Your commit msg must explain this. You break users of this DTS on >> older kernels and also this makes it impossible to apply via different >> branches in the same cycle. All this needs explanation and proper >> justification. Your message tells here nothing, because "what" is quite >> obvious. >> > > I provided all the explanation possible through the different commits of > this series. I can re-state here if it helps DTS commits stand on their own and must not go via same branch as driver, so how does driver commit msg help Git history? > >>> >>> Signed-off-by: Jerome Brunet >>> --- >>> arch/arm/boot/dts/amlogic/meson.dtsi | 4 ++-- >>> arch/arm/boot/dts/amlogic/meson8.dtsi | 16 +++++++++++++--- >>> arch/arm/boot/dts/amlogic/meson8b-ec100.dts | 2 -- >>> arch/arm/boot/dts/amlogic/meson8b-mxq.dts | 2 -- >>> arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts | 2 -- >>> arch/arm/boot/dts/amlogic/meson8b.dtsi | 16 +++++++++++++--- >>> 6 files changed, 28 insertions(+), 14 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi >>> index 8e3860d5d916..80cc004ad5fe 100644 >>> --- a/arch/arm/boot/dts/amlogic/meson.dtsi >>> +++ b/arch/arm/boot/dts/amlogic/meson.dtsi >>> @@ -83,14 +83,14 @@ i2c_A: i2c@8500 { >>> }; >>> >>> pwm_ab: pwm@8550 { >>> - compatible = "amlogic,meson-pwm"; >>> + compatible = "amlogic,meson8-pwm-v2"; >> >> That's breaking users of this DTS (old kernel, out of tree, other >> projects) for no real reasons without explanation. > > "amlogic,meson-pwm" will continue to match, meaning of bindings is unchanged No, because new DTS does not have amlogic,meson-pwm, thus all existing users see breakage. > > How do you propose to fix badly designed bindings then ? Justify and introduce incompatible changes, breaking the ABI. Anyway this is a requirement, because, as I said in other reply, you cannot have compatible for software model! > > if we cant even introduce a new compatible to fix things up. It is supposed to > stay and broken till the end of time ? No, you cannot introduce new compatible for new OS. Fix the bindings instead with proper justification. We did it many times, what's the problem here? Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic