From: Neil Armstrong <narmstrong@baylibre.com>
To: Vyacheslav Bocharov <adeep@lexina.in>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: meson: update SDIO in dts for JetHub D1
Date: Fri, 25 Mar 2022 18:33:28 +0100 [thread overview]
Message-ID: <934c32f1-5fc3-7b38-3fee-0c75de928302@baylibre.com> (raw)
In-Reply-To: <20220325165501.81551-4-adeep@lexina.in>
Hi,
On 25/03/2022 17:55, Vyacheslav Bocharov wrote:
> Fix the dts to match board's reference design:
> - update vddio_boot regulator to 3.3v (Wi-Fi SDIO module)
> - add vccq_1v8 regulator with 1.8v for eMMC SDIO
>
> In the first revision of JetHub D1 the vccq_1v8 regulator was 3.3v.
> All installed eMMC modules were tested to work in HS200 mode at 3.3v
> supply voltage. In the next revisions of the board eMMC will be
> powered with 1.8v according to the standard.
>
> Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in>
> ---
> .../dts/amlogic/meson-axg-jethome-jethub-j100.dts | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> index 66c1eeba8f48..bc00d672a357 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> @@ -81,12 +81,22 @@ vddio_ao18: regulator-vddio_ao18 {
> vddio_boot: regulator-vddio_boot {
> compatible = "regulator-fixed";
> regulator-name = "VDDIO_BOOT";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vddao_3v3>;
> + regulator-always-on;
> + };
> +
> + vccq_1v8: regulator-vccq_1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "VCCQ_1V8";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> vin-supply = <&vddao_3v3>;
> regulator-always-on;
> };
>
> +
> usb_pwr: regulator-usb_pwr {
> compatible = "regulator-fixed";
> regulator-name = "USB_PWR";
> @@ -248,8 +258,7 @@ &sd_emmc_b {
>
> bus-width = <4>;
> cap-sd-highspeed;
> - sd-uhs-sdr104;
> - max-frequency = <200000000>;
> + max-frequency = <50000000>;
This changes should be in a separate commit
> non-removable;
> disable-wp;
>
> @@ -282,7 +291,7 @@ &sd_emmc_c {
> mmc-pwrseq = <&emmc_pwrseq>;
>
> vmmc-supply = <&vcc_3v3>;
> - vqmmc-supply = <&vddio_boot>;
> + vqmmc-supply = <&vccq_1v8>;
> };
>
> /* UART Bluetooth */
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-03-25 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 16:54 [PATCH 0/3] arm64: meson: update dts for JetHub devices Vyacheslav Bocharov
2022-03-25 16:54 ` [PATCH 1/3] arm64: meson: add dts bluetooth node for JetHub H1 Vyacheslav Bocharov
2022-03-25 17:32 ` Neil Armstrong
2022-03-25 16:55 ` [PATCH 2/3] arm64: meson: dts: update serial alias in dts for JetHub D1 Vyacheslav Bocharov
2022-03-25 16:55 ` [PATCH 3/3] arm64: meson: update SDIO " Vyacheslav Bocharov
2022-03-25 17:33 ` Neil Armstrong [this message]
2022-03-25 17:34 ` [PATCH 0/3] arm64: meson: update dts for JetHub devices Neil Armstrong
2022-03-26 7:42 ` Vyacheslav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=934c32f1-5fc3-7b38-3fee-0c75de928302@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=adeep@lexina.in \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox