From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A9A0C61D92 for ; Wed, 22 Nov 2023 08:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LCXhYL4LKI7/H1GJ+edKoPGjGniF9avnm/a0GtRay4=; b=BZmCV5y/r2POwN nDh6ZUBTJ5RfWBFHsD3LMcgNtDsqYBy8pevQJu9cyJp6P6k83p2zpwk5poFTdOQSsq2/s5e48uZ/R ip26m+iBXa5vFxTeNZgnttDoVCg7hmrY4hvMJ3Hagbs/vIwHdZ1bMcgPqkph1g7507AXD6WPW+4IS t4RltIBUug2o53xqwXTD+fygL1QIXed6Lk+hdRP4+7fIUjLzNaEKvoZpfC1yhOwKM3I0iGkITL4Dv vNgJvb43pBHcvfA4LN9NBOLR2acRk/QXmZwzdEA9KgeigVQoSPh5h2w68z+0FMG56nyMBK1+cu3Hj BHx/Joxe91ZsnXxin/Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5ijq-0014tG-2W; Wed, 22 Nov 2023 08:37:38 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5ijo-0014rg-0S for linux-amlogic@lists.infradead.org; Wed, 22 Nov 2023 08:37:37 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a03a9009572so100543966b.3 for ; Wed, 22 Nov 2023 00:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700642254; x=1701247054; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ClevquIILT9Dw98LF7v9mlLpGssByUybIwS8U3rsj2k=; b=sZro3PILkWsSs1o9B3IYPkvxRvpf5vqMG+Ptp6+v7m8unpCeJ8ire5ZjhJqjHNk9OA +pFlPNeXt4u0NoNsFIgcmckQyu/3CQM75NssGsVj72xCzFYmiDRTDPDzCs0PHlRe3Xwl WDB8LsMX1RBuQ1pCQQWW/2rPjQbXe854LBarxz9hmxXfGSsFciqt6HoIXmDvxqF8s9Gf BfD8JCXB/YYJtey6dddgsRuTAEnT/wYCUlZqwNdRHdJAuzDLFnm3v+47GirEwY0pWDwb oK5ZgYd0JIpPIHAyMgMobC6OoKNe9ua+m+2j1dv4U98Qv3HlVvz/6SW9cbaF6t3y55mp kTSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700642254; x=1701247054; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ClevquIILT9Dw98LF7v9mlLpGssByUybIwS8U3rsj2k=; b=i84hRRzMOHvaJKWDd2iARqQVM5TcN0/3RXDaghkcerhKcNCJDtuI6+M3YDI75i+GQa MjM0qALWvbIPI2tfZ32LIYiZLvi2u2het9U++9DCso98t0OoQJI2xR02V2c57+20cq7/ efTclXhDhch2K5X6B49G4UUWvw9VhC71D/XDiNkK2qKW6rL+lk5FXP36FgG2gze0zmVi WArl9z5wScuvKZAejmw36rOFg+5AciF7AyUIK8KPePD4Bvu+WiXNczkJfuuwqiG8fy4C tQblDmAX8GyNLJtAHUZ/qkTs7IkDs8wJwwaQVDobcp43QjQpfj8Pm93gt7rbHdJE6y6A 0EDg== X-Gm-Message-State: AOJu0YzMKpTJ/tWAxg6vFOQIXQ1AmusniKM5wv2pBTHRJ8v5k0/4jetG wIiRrstyET7Gts+CHqZrUji7VQ== X-Google-Smtp-Source: AGHT+IE/yhfWwhrh6s9XnWN3u8Tg6TjcSusL1srd3gxRABTqB7FomfyOyHPn3tHQ9sk+6gbDMVJGSg== X-Received: by 2002:a17:906:2208:b0:9e7:c1cd:a4dd with SMTP id s8-20020a170906220800b009e7c1cda4ddmr801352ejs.3.1700642254441; Wed, 22 Nov 2023 00:37:34 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id w12-20020a1709060a0c00b00a0451425108sm512078ejf.126.2023.11.22.00.37.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 00:37:34 -0800 (PST) Message-ID: <94e69281-93e1-41cd-9cf5-81cbbc15572c@linaro.org> Date: Wed, 22 Nov 2023 09:37:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type Content-Language: en-US To: Jerome Brunet , neil.armstrong@linaro.org Cc: Rob Herring , JunYi Zhao , devicetree@vger.kernel.org, Rob Herring , Conor Dooley , Kevin Hilman , Thierry Reding , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, Krzysztof Kozlowski References: <20231117125919.1696980-1-jbrunet@baylibre.com> <20231117125919.1696980-3-jbrunet@baylibre.com> <170040994064.269288.960284011884896046.robh@kernel.org> <4608012c-059f-4d6a-914b-e85ad0c32ff0@linaro.org> <1j5y1wg3sb.fsf@starbuckisacylon.baylibre.com> <2e7a65da-5c1d-4dd4-ac69-7559a53afdf3@linaro.org> <1j1qckg21u.fsf@starbuckisacylon.baylibre.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <1j1qckg21u.fsf@starbuckisacylon.baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_003736_230824_22A964D1 X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 20/11/2023 11:04, Jerome Brunet wrote: >>>>>> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 36 +++++++++++++++++-- >>>>>> 1 file changed, 34 insertions(+), 2 deletions(-) >>>>>> >>>>> Reviewed-by: Rob Herring >>>>> >>>> >>>> I'm puzzled, isn't it recommended to have a per-soc compatible now ? Yes, it is. >>> I have specifically addressed this matter in the description, >>> haven't I ? What good would it do in this case ? There is nothing about compatible naming in commit msg. >> >> Yes you did but I was asked for the last year+ that all new compatible >> should be soc specific (while imprecise, in our care soc family should be ok), >> with a possible semi-generic callback with an IP version or a first soc >> implementing the IP. >> >>> Plus the definition of a SoC is very vague. One could argue that >>> the content of the list bellow are vaguely defined families. Should we >>> add meson8b, gxl, gxm, sm1 ? ... or even the actual SoC reference ? >>> This list gets huge for no reason. >> >> I think in our case soc family is reasonable since they share same silicon >> design. >> >>> We know all existing PWM of this type are the same. We have been using >>> them for years. It is not a new support we know nothing about. >>> >>>> >>>> I thought something like: >>>> - items: >>>> - enum: >>>> - amlogic,gxbb-pwm >>>> - amlogic,axg-pwm >>>> - amlogic,g12a-pwm >>>> - const: amlogic,pwm-v1 >>> I'm not sure I understand what you are suggesting here. >>> Adding a "amlogic,pwm-v1" for the obsolete compatible ? No amlogic DT >>> has that and I'm working to remove this type, so I don't get the point. >>> >>>> >>>> should be preferred instead of a single amlogic,meson8-pwm-v2 ? >>> This is named after the first SoC supporting the type. >>> Naming it amlogic,pwm-v2 would feel weird with the s4 coming after. >>> Plus the doc specifically advise against this type of names. >> >> The -v2 refers to a pure software/dt implementation versioning and not >> an HW version, so I'm puzzled and I requires DT maintainers advice here. >> >> Yes meson8b is the first "known" platform, even if I'm pretty sure meson6 has Yes, this should be SoC-based compatible, unless you have clear versioning scheme by SoC/IP block vendor. You named it not a HW version, which kind of answers to the "unless" case - that's not hardware version. > > This is not my point. I picked this name because I have to pick a > specific device based one. Not because it is actually the first or > not. I don't see a problem with meson6 being compatible with > meson8-pwm-v2, if that ever comes along. No, the point is not to use "v2". Use SoC compatibles. > > I think the binding here satisfy the rule that it should be specific, > and the intent that goes with it: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/writing-bindings.rst?h=v6.7-rc2#n42 > >> the same pwm architecture, this is why "amlogic,pwm-v1" as fallback seems more >> reasonable and s4 and later pwm could use the "amlogic,pwm-v2" >> fallback. > > That is not how understand this: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/writing-bindings.rst?h=v6.7-rc2#n82 > Again, where the "v2" is defined? Where is any document explaining the mapping between version blocks and SoC parts? Why do you list here only major version? Blocks almost always have also minor (e.g. v2.0). Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic