From: Heiner Kallweit <hkallweit1@gmail.com>
To: Erico Nunes <nunes.erico@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: Da Xue <da@lessconfused.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org, linux-amlogic@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Vyacheslav <adeep@lexina.in>, Qi Duan <qi.duan@amlogic.com>
Subject: Re: [RFC/RFT PATCH] net: stmmac: do not poke MAC_CTRL_REG twice on link up
Date: Mon, 29 Aug 2022 20:25:05 +0200 [thread overview]
Message-ID: <99839201-6c30-b455-2f32-ea0f992427fc@gmail.com> (raw)
In-Reply-To: <CAK4VdL0pWFga4V1jR8B4oHjXmbBm7dU6BB8pdh0Hymd2sAiqiw@mail.gmail.com>
On 29.08.2022 12:29, Erico Nunes wrote:
> On Mon, Aug 29, 2022 at 12:02 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>>>>> Jerome, can you confirm that after this commit the following is no longer needed?
>>>>> 2c87c6f9fbdd ("net: phy: meson-gxl: improve link-up behavior")
>>
>> This never had any meaningful impact for me. I have already reverted it
>> for testing.
>>
>> I'm all for reverting it
>>
>>>>>
>>>>> Then I'd revert it, referencing the successor workaround / fix in stmmac.
> If we are considering to revert that, I would like to trigger some
> tests on my S805X CI board farm as well, to ensure it won't regress
> later. That was one of the original reasons for that patch.
>
> Since there are some more changes referenced in this thread, can
> someone clarify what is the desired state to test? Just revert
> 2c87c6f9fbdd on top of linux-next, or also apply some other patch?
Yes, just revert 2c87c6f9fbdd on top of linux-next.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-08-29 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 10:14 [RFC/RFT PATCH] net: stmmac: do not poke MAC_CTRL_REG twice on link up Jerome Brunet
2022-07-13 9:24 ` Da Xue
2022-07-15 6:58 ` Da Xue
2022-08-26 9:51 ` Heiner Kallweit
2022-08-26 15:45 ` Da Xue
2022-08-26 20:36 ` Heiner Kallweit
2022-08-27 20:23 ` Da Xue
2022-08-29 7:39 ` Neil Armstrong
2022-08-29 10:01 ` Jerome Brunet
2022-08-29 10:29 ` Erico Nunes
2022-08-29 18:25 ` Heiner Kallweit [this message]
2022-09-13 7:55 ` Erico Nunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99839201-6c30-b455-2f32-ea0f992427fc@gmail.com \
--to=hkallweit1@gmail.com \
--cc=adeep@lexina.in \
--cc=alexandre.torgue@foss.st.com \
--cc=da@lessconfused.com \
--cc=jbrunet@baylibre.com \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nunes.erico@gmail.com \
--cc=peppe.cavallaro@st.com \
--cc=qi.duan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox