From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: xieqinick@gmail.com
Cc: robh+dt@kernel.org, Neil Armstrong <narmstrong@baylibre.com>,
khilman@baylibre.com, jbrunet@baylibre.com,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
nick@khadas.com, artem@khadas.com
Subject: Re: [PATCH 1/6] arm64: dts: meson: vim3: add serial aliases
Date: Sat, 5 Jun 2021 11:52:35 +0200 [thread overview]
Message-ID: <CAFBinCCsix8MJKzsapmNA-Fe9wKk7xZMsLj9bGWZ_GskiqZLoA@mail.gmail.com> (raw)
In-Reply-To: <20210605062313.418343-2-xieqinick@gmail.com>
On Sat, Jun 5, 2021 at 8:23 AM <xieqinick@gmail.com> wrote:
>
> From: Nick Xie <nick@khadas.com>
>
> Add serial aliases for Khadas VIM3/3L.
>
> Signed-off-by: Nick Xie <nick@khadas.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 66d67524b031..4686ea7abe0b 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -13,6 +13,10 @@
> / {
> aliases {
> serial0 = &uart_AO;
> + serial1 = &uart_A;
uart_A is used for the Bluetooth module so with mainline Linux it will
not get a /dev/ttyAMLx character device
For that reason we are not adding an alias for uart_A when a new
board.dts is added
I suggest that you also drop this alias here because it is not visible
to the user ever
Same applies to VIM1 and VIM2 as well
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-06-05 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 6:23 [PATCH 0/6] Add serial and i2c aliases for Khadas VIM boards xieqinick
2021-06-05 6:23 ` [PATCH 1/6] arm64: dts: meson: vim3: add serial aliases xieqinick
2021-06-05 9:52 ` Martin Blumenstingl [this message]
2021-06-05 6:23 ` [PATCH 2/6] arm64: dts: meson: vim1: update " xieqinick
2021-06-05 6:23 ` [PATCH 3/6] arm64: dts: meson: vim2: " xieqinick
2021-06-05 6:23 ` [PATCH 4/6] arm64: dts: meson: vim3: add i2c aliases xieqinick
2021-06-05 9:56 ` Martin Blumenstingl
2021-06-05 6:23 ` [PATCH 5/6] arm64: dts: meson: vim1: " xieqinick
2021-06-05 6:23 ` [PATCH 6/6] arm64: dts: meson: vim2: " xieqinick
2021-06-07 7:01 ` [PATCH 0/6] Add serial and i2c aliases for Khadas VIM boards Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCsix8MJKzsapmNA-Fe9wKk7xZMsLj9bGWZ_GskiqZLoA@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=artem@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
--cc=xieqinick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).