* [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check [not found] <20220819060801.10443-1-jinpu.wang@ionos.com> @ 2022-08-19 6:07 ` Jack Wang 2022-08-26 12:46 ` LABBE Corentin 2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang 1 sibling, 1 reply; 5+ messages in thread From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw) To: linux-kernel Cc: Corentin Labbe, Herbert Xu, David S. Miller, linux-crypto, linux-amlogic dma_map_sg return 0 on error. Cc: Corentin Labbe <clabbe@baylibre.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Cc: linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c index e79514fce731..af017a087ebf 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c @@ -177,7 +177,7 @@ static int meson_cipher(struct skcipher_request *areq) if (areq->src == areq->dst) { nr_sgs = dma_map_sg(mc->dev, areq->src, sg_nents(areq->src), DMA_BIDIRECTIONAL); - if (nr_sgs < 0) { + if (!nr_sgs) { dev_err(mc->dev, "Invalid SG count %d\n", nr_sgs); err = -EINVAL; goto theend; @@ -186,14 +186,14 @@ static int meson_cipher(struct skcipher_request *areq) } else { nr_sgs = dma_map_sg(mc->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE); - if (nr_sgs < 0 || nr_sgs > MAXDESC - 3) { + if (!nr_sgs || nr_sgs > MAXDESC - 3) { dev_err(mc->dev, "Invalid SG count %d\n", nr_sgs); err = -EINVAL; goto theend; } nr_sgd = dma_map_sg(mc->dev, areq->dst, sg_nents(areq->dst), DMA_FROM_DEVICE); - if (nr_sgd < 0 || nr_sgd > MAXDESC - 3) { + if (!nr_sgd || nr_sgd > MAXDESC - 3) { dev_err(mc->dev, "Invalid SG count %d\n", nr_sgd); err = -EINVAL; goto theend; -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check 2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check Jack Wang @ 2022-08-26 12:46 ` LABBE Corentin 0 siblings, 0 replies; 5+ messages in thread From: LABBE Corentin @ 2022-08-26 12:46 UTC (permalink / raw) To: Jack Wang Cc: linux-kernel, Herbert Xu, David S. Miller, linux-crypto, linux-amlogic Le Fri, Aug 19, 2022 at 08:07:52AM +0200, Jack Wang a écrit : > dma_map_sg return 0 on error. > > Cc: Corentin Labbe <clabbe@baylibre.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Hello Tested-by: Corentin Labbe <clabbe@baylibre.com> Acked-by: Corentin Labbe <clabbe@baylibre.com> Thanks Regards _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg [not found] <20220819060801.10443-1-jinpu.wang@ionos.com> 2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check Jack Wang @ 2022-08-19 6:07 ` Jack Wang 2022-08-20 17:25 ` Martin Blumenstingl 1 sibling, 1 reply; 5+ messages in thread From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw) To: linux-kernel Cc: Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, linux-mmc, linux-arm-kernel, linux-amlogic dma_map_sg return 0 on error. Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: linux-mmc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/mmc/host/meson-mx-sdhc-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c index e92e63cb5641..b32364f20c32 100644 --- a/drivers/mmc/host/meson-mx-sdhc-mmc.c +++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq) dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len, mmc_get_dma_dir(data)); - if (dma_len <= 0) { + if (!dma_len) { dev_err(mmc_dev(mmc), "dma_map_sg failed\n"); return -ENOMEM; } -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg 2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang @ 2022-08-20 17:25 ` Martin Blumenstingl 2022-08-22 5:15 ` Jinpu Wang 0 siblings, 1 reply; 5+ messages in thread From: Martin Blumenstingl @ 2022-08-20 17:25 UTC (permalink / raw) To: Jack Wang Cc: linux-kernel, Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet, linux-mmc, linux-arm-kernel, linux-amlogic Hello Jack, first of all: thank you for this patch! On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote: [...] > @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq) > > dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len, Does it also make sense to change the type of the dma_len variable from (signed) int to "unsigned int" (a few lines above)? Best regards, Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg 2022-08-20 17:25 ` Martin Blumenstingl @ 2022-08-22 5:15 ` Jinpu Wang 0 siblings, 0 replies; 5+ messages in thread From: Jinpu Wang @ 2022-08-22 5:15 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-kernel, Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet, linux-mmc, linux-arm-kernel, linux-amlogic Hi Martin, On Sat, Aug 20, 2022 at 7:26 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hello Jack, > > first of all: thank you for this patch! welcome. > > On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote: > [...] > > @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq) > > > > dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len, > Does it also make sense to change the type of the dma_len variable > from (signed) int to "unsigned int" (a few lines above)? I double checked, it seems a good idea, I will do it in v2. > > > Best regards, > Martin Thx! _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-26 12:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220819060801.10443-1-jinpu.wang@ionos.com>
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check Jack Wang
2022-08-26 12:46 ` LABBE Corentin
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
2022-08-20 17:25 ` Martin Blumenstingl
2022-08-22 5:15 ` Jinpu Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).