From: Anand Moon <linux.amoon@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Icenowy Zheng <uwu@icenowy.me>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-amlogic@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub
Date: Fri, 8 Dec 2023 16:49:57 +0530 [thread overview]
Message-ID: <CANAwSgTy4N7Q8e0OQLsFRkRDWksTSbkOetKQGygaqsQ8++U1_g@mail.gmail.com> (raw)
In-Reply-To: <1a78d453-62a2-410a-a40f-1ff0c2b62e86@linaro.org>
Hi Krzysztof,
On Fri, 8 Dec 2023 at 13:14, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/12/2023 01:24, Anand Moon wrote:
> >>>>>
> >>>>> If I move reset-gpios to required, I observe the below warning.
> >>>>>
> >>>>> DTC_CHK Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb
> >>>>> /home/alarm/linux-amlogic-5.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> >>>>> hub@1: 'reset-gpio' is a required property
> >>>>> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> >>>>
> >>>> Where are the properties defined? If you open the binding you see:
> >>>> nowhere. You cannot define properties in some variant with "true".
> >>>> Please define all of them in top-level and only narrow/constrain when
> >>>> applicable.
> >>>>
> >>> What I meant is the example below, required meant applicable for both
> >>> the binding
> >>> But it shows me the above warning.
> >>
> >> My explanation stands... So again:
> >>
> >>>> Please define all of them in top-level and only narrow/constrain when
> >>>> applicable.
> >>
> > Apologies, But I have tried this multiple times but have not been able
> > to fix the device tree warning
>
> Did you document all properties in top-level "properties:" block?
>
Yes, I have,
Can you suggest a couple of examples to follow?
I looked at some of the YAML files but could not fix my issue.
Thanks
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-12-08 11:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:44 [PATCH v6 0/2] Use onboard usb hub reset on Odroid N2 Anand Moon
2023-12-04 14:44 ` [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub Anand Moon
2023-12-06 13:53 ` Rob Herring
2023-12-06 17:14 ` Anand Moon
2023-12-07 8:30 ` Krzysztof Kozlowski
2023-12-07 12:33 ` Anand Moon
2023-12-07 12:40 ` Krzysztof Kozlowski
2023-12-08 0:24 ` Anand Moon
2023-12-08 7:44 ` Krzysztof Kozlowski
2023-12-08 11:19 ` Anand Moon [this message]
2023-12-08 12:17 ` Krzysztof Kozlowski
2023-12-12 6:22 ` Anand Moon
2023-12-12 8:40 ` Krzysztof Kozlowski
2023-12-12 11:37 ` Anand Moon
2023-12-12 11:52 ` Krzysztof Kozlowski
2023-12-12 12:51 ` Anand Moon
2023-12-12 13:09 ` Krzysztof Kozlowski
2023-12-12 13:17 ` Anand Moon
2024-04-04 4:27 ` Anand Moon
2024-04-04 6:12 ` Krzysztof Kozlowski
2024-04-04 6:32 ` Anand Moon
2024-04-04 6:34 ` Anand Moon
2023-12-04 14:44 ` [PATCH v6 2/2] arm64: dts: amlogic: Used onboard usb hub reset on odroid n2 Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANAwSgTy4N7Q8e0OQLsFRkRDWksTSbkOetKQGygaqsQ8++U1_g@mail.gmail.com \
--to=linux.amoon@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).