linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking
Date: Fri, 15 Dec 2017 10:17:30 +0100	[thread overview]
Message-ID: <CAPDyKFoLvrZ2PK7EAcoVdk4wQp81FPBEcrTcHKW5UfazzjXpcw@mail.gmail.com> (raw)
In-Reply-To: <c1c27676e9f141ace1254b40807bf2dc03f072c6.1511066652.git.arvind.yadav.cs@gmail.com>

On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
>               return -EINVAL instead of irq.
>
>  drivers/mmc/host/meson-gx-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e0862d3..32a6a22 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1208,7 +1208,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
>         }
>
>         irq = platform_get_irq(pdev, 0);
> -       if (!irq) {
> +       if (irq <= 0) {
>                 dev_err(&pdev->dev, "failed to get interrupt resource.\n");
>                 ret = -EINVAL;
>                 goto free_host;
> --
> 2.7.4
>

      parent reply	other threads:[~2017-12-15  9:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19  4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-19  4:52 ` [PATCH 2/6 v3] mmc: s3cmci: " Arvind Yadav
2017-12-15  9:17   ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-22 12:02   ` Adrian Hunter
2017-12-15  9:17   ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
2017-11-20  6:45   ` Viresh Kumar
2017-12-15  9:17   ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 6/6 v3] mmc: sunxi-mmc: " Arvind Yadav
2017-12-15  9:18   ` Ulf Hansson
2017-12-07  0:58 ` [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Kevin Hilman
2017-12-15  9:17 ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFoLvrZ2PK7EAcoVdk4wQp81FPBEcrTcHKW5UfazzjXpcw@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).