From: Ulf Hansson <ulf.hansson@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3 0/2] mmc: meson-gx: add SDIO interrupt support
Date: Mon, 29 Aug 2022 14:07:35 +0200 [thread overview]
Message-ID: <CAPDyKFqRm=RVn__3HJDk_0bBemudh_y7YEYPZe3W7iJCfP50fg@mail.gmail.com> (raw)
In-Reply-To: <e970e07d-9bb8-707d-1dc6-09fae2abbfff@baylibre.com>
On Mon, 29 Aug 2022 at 09:42, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Uffe, Heiner,
>
> On 26/08/2022 11:16, Ulf Hansson wrote:
> > On Thu, 25 Aug 2022 at 21:52, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >>
> >> Add SDIO interrupt support. Successfully tested on a S905X4-based
> >> system (V3 register layout) with a BRCM4334 SDIO wifi module
> >> (brcmfmac driver).
> >>
> >> v2:
> >> - use new SDIO interrupt API
> >> v3:
> >> - don't duplicate checking mmc->sdio_irq_pending
> >>
> >> Heiner Kallweit (2):
> >> mmc: meson: adjust and re-use constant IRQ_EN_MASK
> >> mmc: meson-gx: add SDIO interrupt support
> >>
> >> drivers/mmc/host/meson-gx-mmc.c | 84 +++++++++++++++++++++++++--------
> >> 1 file changed, 65 insertions(+), 19 deletions(-)
> >>
> >
> > Applied for next, thanks!
>
> Thanks for applying, but I was off (like many of reviewers) and I would have like
> this patchset to be tested on earlier SoCs aswell, or only enabled on S4 for now.
To actually make use of the new code, an update to the corresponding
DTS files are needed to set the cap-sdio-irq property.
If that isn't sufficient, I prefer if we make a patch on top of the
$subject series.
Kind regards
Uffe
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-08-29 12:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 19:52 [PATCH v3 0/2] mmc: meson-gx: add SDIO interrupt support Heiner Kallweit
2022-08-25 19:53 ` [PATCH v3 1/2] mmc: meson: adjust and re-use constant IRQ_EN_MASK Heiner Kallweit
2022-08-25 19:56 ` [PATCH v3 2/2] mmc: meson-gx: add SDIO interrupt support Heiner Kallweit
2022-08-26 9:16 ` [PATCH v3 0/2] " Ulf Hansson
2022-08-29 7:42 ` Neil Armstrong
2022-08-29 12:07 ` Ulf Hansson [this message]
2022-08-29 13:29 ` Neil Armstrong
2022-08-29 14:21 ` Ulf Hansson
2022-08-29 18:23 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqRm=RVn__3HJDk_0bBemudh_y7YEYPZe3W7iJCfP50fg@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).