From: Daniel Stone <daniel@fooishbar.org>
To: Helen Koike <helen.koike@collabora.com>,
Dave Airlie <airlied@gmail.com>, Sima Vetter <daniel@ffwll.ch>,
Daniel Stone <daniels@collabora.com>,
Emma Anholt <emma@anholt.net>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
David Heidelberg <david.heidelberg@collabora.com>,
Rob Clark <robdclark@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v1 0/8] drm/ci: Add support for GPU and display testing
Date: Thu, 11 Jan 2024 18:11:25 +0000 [thread overview]
Message-ID: <CAPj87rPRRfJmxTev50YqxBizyvzCUhCiymoV_bdqsZ-zvcREfA@mail.gmail.com> (raw)
In-Reply-To: <ad7cbd59-5264-96e8-5e9b-aafde8028e41@collabora.com>
Hi Vignesh,
On Wed, 10 Jan 2024 at 10:47, Vignesh Raman <vignesh.raman@collabora.com> wrote:
> On 09/01/24 19:08, Daniel Stone wrote:
> > A better sequencing would be something like:
> > 1. add ANX7625 config
> > 2. refactor _existing_ MTK display jobs to use YAML includes, change
> > the existing job name, and rename the existing xfail set, remove
> > IGT_FORCE_DRIVER from the script since it's now set by the job
> > 3. add MTK Panfrost+PVR GPU jobs with new xfails, add xfail entry to
> > MAINTAINERS
> > 4+5: same as 2+3 but for Amlogic
> > 6+7: same as 2+3 but for Rockchip
> >
> > Then the separate rename/update xfail commits just disappear, as does
> > the removal of IGT_FORCE_DRIVER, because it's just done incrementally
> > as part of the commits which change the related functionality. It's
> > extremely important that every change can work standalone, instead of
> > introducing intermediate breakage which is only fixed in later commits
> > in the series.
>
> Thank you for reviewing the patches. I agree, will follow this sequence
> and send a v2 version.
Alongside Rob's patch to add msm-specific tests to the runlist, we'd
need to add the Panfrost-specific tests. Whilst we're here, we might
as well add the vc4/v3d/etnaviv/lima tests so they can use it in
future.
Panfrost should also skip kms_.* tests - since it's not a KMS driver,
it can't run the KMS tests, so there's no point in trying.
Cheers,
Daniel
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-01-11 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 12:11 [PATCH v1 0/8] drm/ci: Add support for GPU and display testing Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 1/8] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625 Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 2/8] drm/ci: mediatek: Test both GPU and display drivers Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 3/8] drm/ci: rockchip: " Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 4/8] drm/ci: meson: " Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 5/8] drm/ci: Do not set IGT_FORCE_DRIVER based on driver name Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 6/8] MAINTAINERS: drm/ci: xfails: add entry for panfrost Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 7/8] drm/ci: Rename xfails file Vignesh Raman
2023-12-20 12:11 ` [PATCH v1 8/8] drm/ci: Update xfails Vignesh Raman
2024-01-09 13:38 ` [PATCH v1 0/8] drm/ci: Add support for GPU and display testing Daniel Stone
2024-01-10 10:47 ` Vignesh Raman
2024-01-11 18:11 ` Daniel Stone [this message]
2024-01-17 10:58 ` Vignesh Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPj87rPRRfJmxTev50YqxBizyvzCUhCiymoV_bdqsZ-zvcREfA@mail.gmail.com \
--to=daniel@fooishbar.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=david.heidelberg@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=guilherme.gallo@collabora.com \
--cc=helen.koike@collabora.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robdclark@gmail.com \
--cc=sergi.blanch.torne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).