From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 560A3D609BB for ; Tue, 16 Dec 2025 16:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CyKRPDElAQhL0DNuhi191ww4eEvcNXae4LBQQ6ZFMfA=; b=vup27XnJlbx3WY dJQuQg8IjsHbpoaLzM/n66UWVptGd/gsdQOW7wWKVyY3xJaDaSg0WR8wyHmc5MwhMdzJ5FD1FpG/S 7NhqIAB7L7oAfRJlPufKNByhWLs1ZfBtiwWXj16RQziTLc/qNPZWfAjkBp3lKEOQ4IuNUCSZWG9ik maTMeGt2q25HtilahKUkG02rvNMaxUbeR4yeNiJOATG4DZAe3qVPUV6hw0XSrhtKpbF4QUnhjzI+5 rGYOtXo/uPdSRmaI4B4tNnWafDFqvX3l92YdCsy2VpwWr2xBE+KIx/uJPIK1xaIF92gbjXkvtmyQC LSKdOplsP9CupStWA59A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVY2L-00000005XMt-0Gf7; Tue, 16 Dec 2025 16:36:33 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVY2H-00000005XLj-2ckp for linux-amlogic@lists.infradead.org; Tue, 16 Dec 2025 16:36:31 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 5F411C1A580; Tue, 16 Dec 2025 16:36:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A76266071C; Tue, 16 Dec 2025 16:36:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F316C119A904B; Tue, 16 Dec 2025 17:36:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765902982; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PzhR0G4mBnm/z0O1Hfgh44ISCPhT1HMJphLOZLV+TY0=; b=Hxcp1qe0jp9L+ZP5B2CcjRugnzvNJMFJ/9uLnc/dPwH5UC2kAbZKmRyiMLwCIMY3l1rGeB r1i0PJRzjjFJ9grjtuxiAKvLXLVgaYVMvrqPir01kIYE5+3GlMEUdCh/SeWGh8FfSmc4dD BQCAl/r7vtgA55arSrrcGj571k5Y7jabJyHmtN3hyRh7HvY9LH9G+IEVTIcBK5YF8EbLdi mePmspCgWnZbPbX9OJXUW7hcaIiZlm5vXCzrPfRFRz3YSxNhCgjgDAJf2WLsdzNMJz7Sdl go01yz6G44JOyfuUCxKxAYqzeeuqGpt1lByELY1A2jHL5QL1gBe/telVFa0/Cw== Mime-Version: 1.0 Date: Tue, 16 Dec 2025 17:36:07 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH 06/26] drm/bridge: add devm_drm_of_find_bridge Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alexey Brodkin" , "Phong LE" , "Liu Ying" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Adrien Grassein" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Chun-Kuang Hu" , "Philipp Zabel" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Anitha Chrisanthus" , "Edmund Dea" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Hui Pu" , "Thomas Petazzoni" , , , , , , , , , To: "Maxime Ripard" X-Mailer: aerc 0.20.1 References: <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-0-0db98a7fe474@bootlin.com> <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-6-0db98a7fe474@bootlin.com> <20251201-thick-jasmine-oarfish-1eceb0@houat> <20251215-mottled-dexterous-marmot-c69ad3@penduick> <20251216-cute-bandicoot-of-authority-3c492a@penduick> In-Reply-To: <20251216-cute-bandicoot-of-authority-3c492a@penduick> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251216_083629_815081_ECC0A839 X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Maxime, On Tue Dec 16, 2025 at 2:49 PM CET, Maxime Ripard wrote: [...] >> Not sure why, but it's taking a while before I grasp your ideas about this >> series and meld them with mine. I hopefully got a clear POV now, so based >> on it my plan is to rework this series to: >> >> * keep drm_of_find_bridge() but renamed to of_drm_get_bridge(), and keep >> patches 1-5 (with the changes suggested by you and Louis, nothing big >> and all already sent in v2) > > I don't think we should use that name, but on principle, yes. OK about the rename. I just had sent this email before you requested the rename. v3 is in the works with the of_drm_find_and_get_bridge() name. >> * not add devm_drm_of_find_bridge() > > Yep. > >> * add next_bridge pointer to struct drm_bridge and call >> drm_bridge_put(bridge->next_bridge) in __drm_bridge_free, document it > > We don't have to at this point, you can add next_bridge to the > drm_bridge pointer if you want, but I don't consider it a prerequisite. > If we don't we would have to create drm_bridge_funcs->destroy > implemnentations to give up the driver pointer reference though. Your > call. There's a destroy finc already, so I'm adding the next_bridge pointer in v3 along with some driver conversions, including one where the destroy hook is needed. >> * convert patches 7-26 to use bridge->next_bridge where applicable, >> or to do something different when needed > > Depending on your decision above, we'd need to either convert them to > use drm_bridge->next_bridge or create a destroy hook for them. Either > way is fine for me. > >> * maybe remove part of patches 7-26 just to reduce spam and rework effort >> in case of further iterations, to send them separately once the approach >> is accepted >> >> Does it look OK? Cool, thanks for acking. v3 is just a testing round away from being sent. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic