From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E11C05027 for ; Mon, 6 Feb 2023 17:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fozwMevxIBkBD6Xgy8qcxUfBPzDg6tp6qGk/qWoW3/8=; b=mSX/7/3R/KMsLq KmZIXb2XOyPdozwoa6EjB1o0tGoUQs9IRbtCZlDtCTNWYoekbn3H1qi1owW3ZSKh1y9bowk3u72ts jf2d5e9QMAjMow7PufveBvP+aA0DcF841j1d3eNv1TpKF6rWqOUpwZxq1OhYxlB3ArdjbIX5PGXGU 6k4FzPrmNf3BPB1J5+l5cQdW+87+cwMiEfF1gMwf4dHpGCYNAoKnn+ykAeRlxg1+EmGraWFo7RaOQ bz8q2CzksPXdm0Xp9wf6RvLQ4TmSMzPF10jC+85Ko4zPaiBz1YOjl2NUBaEJxY3AfJ2NDEney8VMv 5rYQm9x4PXlY5VT1lg5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP4re-009OSl-UY; Mon, 06 Feb 2023 17:01:10 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP4rS-009OQV-8b for linux-amlogic@lists.infradead.org; Mon, 06 Feb 2023 17:01:01 +0000 Received: by mail-ed1-x52d.google.com with SMTP id eq11so12337944edb.6 for ; Mon, 06 Feb 2023 09:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=a6q/V+E4w1GCT3UIo80p/1jk/eyzfrAH7kZCB3dF6EI=; b=uCfTnrbkPsLAWL6gOh5JY9TMsdhSIK82e1NiuB7IshsdmrWsM5Hjr6FwUqZDOfVwE5 pvNIBn/sDzqqN32lvfDoOmAh45PK1wSUkPZLuoc6AEvpCgbhlvhcegjr+D6AEUDXeYYW crvJhRIWcpDQskPdi0OoQGliNpJBpBY6VIzwBot4iZgUgiUf3fIUlETRkLbLODtr4PhJ 3TWSPMBYPdaLTxs1wac12U00iQXUDjiSDIkJN5Elr/OcQAIapmSRlT2ChNGZoaEjoLvI /JAvT3ybEZlwj5jOQ0L0qHFxsB/XJq0OisD0eI8mYh3MtxQWHtEUbqVsfi2Ox0lT3Rd+ Q6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a6q/V+E4w1GCT3UIo80p/1jk/eyzfrAH7kZCB3dF6EI=; b=E0Jc/QPdhnX7HJRm9tbYvho7sp8hsJFQCnsAMggw/XbV5ZRDWdJgTFAIW8B0sQpuSF u3jeRPbLCDG6SLvaggWy8P97HCwBGVXCBjJiqE/MJU1AxDQQU5ZQhyQ052fQCQwq1qzX U/zJc541s/pLbej598TlVwnV89iACRn9Di3j6h3byIEkuf96ZJfoIOdZTiix3ZCY2GwV H8NPCqYsbVX4l4PR+uZtrfpFZR+4u15P4dRVTTDGoLfksjY4FgrxpDcsMf0KmnOB41PF FBHIpkUrDtyibykGOV+HoS1Je28rIZRj2JtWekEO0jrNHSgqCj9kgbmQeH0pPOeZXjku rOEA== X-Gm-Message-State: AO0yUKWTwMaZDzVVSm/65fW7BIk7W+59VW7RShE03gcNM3J5plHSdo4e xNIfT5lSb3aqmAmKTfdN2Dvr+Q== X-Google-Smtp-Source: AK7set9cQX60hct3CmrqQYLoS0zKl3hJEZ9KOOgC/H19Hq6SMdqrMyY4g16B+aPSjyDEPbDCn8cC1A== X-Received: by 2002:a50:9ea9:0:b0:4a0:e323:d59c with SMTP id a38-20020a509ea9000000b004a0e323d59cmr246400edf.20.1675702854925; Mon, 06 Feb 2023 09:00:54 -0800 (PST) Received: from localhost (h-46-59-89-207.A463.priv.bahnhof.se. [46.59.89.207]) by smtp.gmail.com with ESMTPSA id c5-20020a50d645000000b004aaa656887esm2668878edj.96.2023.02.06.09.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 09:00:54 -0800 (PST) Date: Mon, 6 Feb 2023 18:00:53 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Daniel Lezcano Cc: rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume La Roque , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Miquel Raynal , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , ye xingchen , Ricardo Neri , Srinivas Pandruvada , Haowen Bai , Minghao Chi , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/QUALCOMM SUPPORT" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" Subject: Re: [PATCH] thermal: Remove core header inclusion from drivers Message-ID: References: <20230206153432.1017282-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206153432.1017282-1-daniel.lezcano@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_090058_548451_45522DCF X-CRM114-Status: GOOD ( 26.26 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Daniel, Thanks for your work. On 2023-02-06 16:34:29 +0100, Daniel Lezcano wrote: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > = > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > = > Remove this inclusion in every place where it is possible. > = > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > = > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > = > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > = > No functional changes > = > [ Applies to thermal/linux-next or linux-pm/linux-next ] > = > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/amlogic_thermal.c | 1 - > drivers/thermal/armada_thermal.c | 2 -- > drivers/thermal/broadcom/bcm2835_thermal.c | 1 - > drivers/thermal/hisi_thermal.c | 3 +-- > drivers/thermal/imx8mm_thermal.c | 1 - > drivers/thermal/imx_sc_thermal.c | 1 - > drivers/thermal/intel/intel_hfi.c | 3 ++- > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - > drivers/thermal/qoriq_thermal.c | 1 - > drivers/thermal/rcar_gen3_thermal.c | 1 - For R-Car, Reviewed-by: Niklas S=F6derlund > drivers/thermal/samsung/exynos_tmu.c | 3 +-- > drivers/thermal/st/stm_thermal.c | 1 - > drivers/thermal/tegra/tegra30-tsensor.c | 1 - > drivers/thermal/uniphier_thermal.c | 2 -- > 14 files changed, 4 insertions(+), 18 deletions(-) > = > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_= thermal.c > index d30cb791e63c..9235fda4ec1e 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -28,7 +28,6 @@ > #include > #include > = > -#include "thermal_core.h" > #include "thermal_hwmon.h" > = > #define TSENSOR_CFG_REG1 0x4 > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_th= ermal.c > index 83a4080bffc7..36653f692c80 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -19,8 +19,6 @@ > #include > #include > = > -#include "thermal_core.h" > - > /* Thermal Manager Control and Status Register */ > #define PMU_TDC0_SW_RST_MASK (0x1 << 1) > #define PMU_TM_DISABLE_OFFS 0 > diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal= /broadcom/bcm2835_thermal.c > index 3d0710c6e004..23918bb76ae6 100644 > --- a/drivers/thermal/broadcom/bcm2835_thermal.c > +++ b/drivers/thermal/broadcom/bcm2835_thermal.c > @@ -18,7 +18,6 @@ > #include > #include > = > -#include "../thermal_core.h" > #include "../thermal_hwmon.h" > = > #define BCM2835_TS_TSENSCTL 0x00 > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_therma= l.c > index 45226cab466e..62c67942293e 100644 > --- a/drivers/thermal/hisi_thermal.c > +++ b/drivers/thermal/hisi_thermal.c > @@ -16,8 +16,7 @@ > #include > #include > #include > - > -#include "thermal_core.h" > +#include > = > #define HI6220_TEMP0_LAG (0x0) > #define HI6220_TEMP0_TH (0x4) > diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_th= ermal.c > index d247b48696cb..72b5d6f319c1 100644 > --- a/drivers/thermal/imx8mm_thermal.c > +++ b/drivers/thermal/imx8mm_thermal.c > @@ -17,7 +17,6 @@ > #include > #include > = > -#include "thermal_core.h" > #include "thermal_hwmon.h" > = > #define TER 0x0 /* TMU enable */ > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_th= ermal.c > index 378f574607f7..f32e59e74623 100644 > --- a/drivers/thermal/imx_sc_thermal.c > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -13,7 +13,6 @@ > #include > #include > = > -#include "thermal_core.h" > #include "thermal_hwmon.h" > = > #define IMX_SC_MISC_FUNC_GET_TEMP 13 > diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/in= tel_hfi.c > index 6e604bda2b93..c69db6c90869 100644 > --- a/drivers/thermal/intel/intel_hfi.c > +++ b/drivers/thermal/intel/intel_hfi.c > @@ -40,10 +40,11 @@ > = > #include > = > -#include "../thermal_core.h" > #include "intel_hfi.h" > #include "thermal_interrupt.h" > = > +#include "../thermal_netlink.h" > + > /* Hardware Feedback Interface MSR configuration bits */ > #define HW_FEEDBACK_PTR_VALID_BIT BIT(0) > #define HW_FEEDBACK_CONFIG_HFI_ENABLE_BIT BIT(0) > diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/therma= l/qcom/qcom-spmi-temp-alarm.c > index e2429676d0d2..101c75d0e13f 100644 > --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > @@ -15,7 +15,6 @@ > #include > #include > = > -#include "../thermal_core.h" > #include "../thermal_hwmon.h" > = > #define QPNP_TM_REG_DIG_MAJOR 0x01 > diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_ther= mal.c > index d111e218f362..431c29c0898a 100644 > --- a/drivers/thermal/qoriq_thermal.c > +++ b/drivers/thermal/qoriq_thermal.c > @@ -13,7 +13,6 @@ > #include > #include > = > -#include "thermal_core.h" > #include "thermal_hwmon.h" > = > #define SITES_MAX 16 > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_g= en3_thermal.c > index 4ef927437842..0fd2fd077638 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -17,7 +17,6 @@ > #include > #include > = > -#include "thermal_core.h" > #include "thermal_hwmon.h" > = > /* Register offsets */ > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsu= ng/exynos_tmu.c > index 37465af59262..527d1eb0663a 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -20,11 +20,10 @@ > #include > #include > #include > +#include > = > #include > = > -#include "../thermal_core.h" > - > /* Exynos generic registers */ > #define EXYNOS_TMU_REG_TRIMINFO 0x0 > #define EXYNOS_TMU_REG_CONTROL 0x20 > diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_th= ermal.c > index e7834ccc7976..735401958f01 100644 > --- a/drivers/thermal/st/stm_thermal.c > +++ b/drivers/thermal/st/stm_thermal.c > @@ -19,7 +19,6 @@ > #include > #include > = > -#include "../thermal_core.h" > #include "../thermal_hwmon.h" > = > /* DTS register offsets */ > diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/te= gra/tegra30-tsensor.c > index 0ffe37ce7df7..b3218b71b6d9 100644 > --- a/drivers/thermal/tegra/tegra30-tsensor.c > +++ b/drivers/thermal/tegra/tegra30-tsensor.c > @@ -28,7 +28,6 @@ > = > #include > = > -#include "../thermal_core.h" > #include "../thermal_hwmon.h" > = > #define TSENSOR_SENSOR0_CONFIG0 0x0 > diff --git a/drivers/thermal/uniphier_thermal.c b/drivers/thermal/uniphie= r_thermal.c > index f8ab2ca76184..47801841b3f5 100644 > --- a/drivers/thermal/uniphier_thermal.c > +++ b/drivers/thermal/uniphier_thermal.c > @@ -17,8 +17,6 @@ > #include > #include > = > -#include "thermal_core.h" > - > /* > * block registers > * addresses are the offset from .block_base > -- = > 2.34.1 > = -- = Kind Regards, Niklas S=F6derlund _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic