[PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic, canvas property

[PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic, canvas property

[Alexander Stein]

This property was already mentioned in the old textual bindings
amlogic,meson-vpu.txt, but got dropped during conversion.
Adding it back similar to amlogic,gx-vdec.yaml.

Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
Changes in v2:
* Do not linebreak Fixes tag
* Make amlogic,canvas mandatory as it was in textual binding already
* Add amlogic,canvas to example

 .../devicetree/bindings/display/amlogic,meson-vpu.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
index 851cb0781217..047fd69e0377 100644
--- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
+++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
@@ -78,6 +78,10 @@ properties:
   interrupts:
     maxItems: 1
 
+  amlogic,canvas:
+    description: should point to a canvas provider node
+    $ref: /schemas/types.yaml#/definitions/phandle
+
   power-domains:
     maxItems: 1
     description: phandle to the associated power domain
@@ -106,6 +110,7 @@ required:
   - port@1
   - "#address-cells"
   - "#size-cells"
+  - amlogic,canvas
 
 additionalProperties: false
 
@@ -118,6 +123,7 @@ examples:
         interrupts = <3>;
         #address-cells = <1>;
         #size-cells = <0>;
+        amlogic,canvas = <&canvas>;
 
         /* CVBS VDAC output port */
         port@0 {
-- 
2.34.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property

[Martin Blumenstingl]

On Sun, Dec 19, 2021 at 10:42 AM Alexander Stein
<alexander.stein@mailbox.org> wrote:
>
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
>
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Thank you very much for this contribution!

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property

[Neil Armstrong]

Hi,

+ dri-devel@lists.freedesktop.org

Thanks for fixing this.

Le 19/12/2021 à 16:30, Martin Blumenstingl a écrit :
> On Sun, Dec 19, 2021 at 10:42 AM Alexander Stein
> <alexander.stein@mailbox.org> wrote:
>>
>> This property was already mentioned in the old textual bindings
>> amlogic,meson-vpu.txt, but got dropped during conversion.
>> Adding it back similar to amlogic,gx-vdec.yaml.
>>
>> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
>> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Thank you very much for this contribution!
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

I'll apply it to drm-misc-next next year or if another drm-misc maintainer can in the meantime, I'm ok with it.

Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property

[Rob Herring]

On Sun, 19 Dec 2021 10:41:55 +0100, Alexander Stein wrote:
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
> 
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Changes in v2:
> * Do not linebreak Fixes tag
> * Make amlogic,canvas mandatory as it was in textual binding already
> * Add amlogic,canvas to example
> 
>  .../devicetree/bindings/display/amlogic,meson-vpu.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property

[Neil Armstrong]

On 19/12/2021 10:41, Alexander Stein wrote:
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
> 
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Changes in v2:
> * Do not linebreak Fixes tag
> * Make amlogic,canvas mandatory as it was in textual binding already
> * Add amlogic,canvas to example
> 
>  .../devicetree/bindings/display/amlogic,meson-vpu.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> index 851cb0781217..047fd69e0377 100644
> --- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> @@ -78,6 +78,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  amlogic,canvas:
> +    description: should point to a canvas provider node
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
>    power-domains:
>      maxItems: 1
>      description: phandle to the associated power domain
> @@ -106,6 +110,7 @@ required:
>    - port@1
>    - "#address-cells"
>    - "#size-cells"
> +  - amlogic,canvas
>  
>  additionalProperties: false
>  
> @@ -118,6 +123,7 @@ examples:
>          interrupts = <3>;
>          #address-cells = <1>;
>          #size-cells = <0>;
> +        amlogic,canvas = <&canvas>;
>  
>          /* CVBS VDAC output port */
>          port@0 {
> 

Applying to drm-misc-fixes,

Thanks,
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic