From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/4] pwm: meson: Drop always false check from .request()
Date: Tue, 1 Feb 2022 08:47:47 +0100 [thread overview]
Message-ID: <Yfjlo4JS490V95hM@orome> (raw)
In-Reply-To: <20211108134628.120474-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 555 bytes --]
On Mon, Nov 08, 2021 at 02:46:24PM +0100, Uwe Kleine-König wrote:
> In .request() pwm_get_chip_data() returns NULL always since commit
> e926b12c611c ("pwm: Clear chip_data in pwm_put()"). (And if it didn't
> returning 0 would be wrong because then .request() wouldn't reenable
> the clk which the other driver code depends on.)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-meson.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
All four patches applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-02-01 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:46 [PATCH 1/4] pwm: meson: Drop always false check from .request() Uwe Kleine-König
2021-11-08 13:46 ` [PATCH 2/4] pwm: meson: Drop useless check for channel data being NULL Uwe Kleine-König
2021-11-20 23:34 ` Martin Blumenstingl
2021-11-08 13:46 ` [PATCH 3/4] pwm: meson: Simplify duplicated per-channel tracking Uwe Kleine-König
2021-11-20 23:35 ` Martin Blumenstingl
2021-11-08 13:46 ` [PATCH 4/4] pwm: meson: Drop always false check from .apply() Uwe Kleine-König
2021-11-20 23:35 ` Martin Blumenstingl
2021-11-20 23:34 ` [PATCH 1/4] pwm: meson: Drop always false check from .request() Martin Blumenstingl
2022-02-01 7:47 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfjlo4JS490V95hM@orome \
--to=thierry.reding@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).